Skip to content

Commit 2289eab

Browse files
committed
Added comments, evidence and assesssment to mapping and task description + Added images to matrix section + Added isImplemented to task description
1 parent 2693a31 commit 2289eab

10 files changed

Lines changed: 110 additions & 1 deletion

src/app/component/mapping/mapping.component.html

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,9 @@
127127
<th>Time</th>
128128
<th>Usefulness</th>
129129
<th>Implementation</th>
130+
<th>Assessment</th>
131+
<th>Evidence</th>
132+
<th>Comments</th>
130133
<th>Depends On</th>
131134
<th>SAMM</th>
132135
<th>ISO</th>
@@ -143,6 +146,9 @@
143146
<td>{{ item.time }}</td>
144147
<td>{{ item.usefulness }}</td>
145148
<td>{{ item.implementation }}</td>
149+
<td>{{ item.assessment }}</td>
150+
<td>{{ item.evidence }}</td>
151+
<td>{{ item.comments }}</td>
146152
<td>{{ item.dependsOn }}</td>
147153
<td>{{ item.samm2 }}</td>
148154
<td>{{ item.ISO }}</td>

src/app/component/mapping/mapping.component.ts

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,9 @@ export interface MappingElementSortedByISO {
3939
time: string;
4040
usefulness: string;
4141
dependsOn: string[];
42+
evidence: string;
43+
comments: string;
44+
assessment: string;
4245
implementation: any;
4346
}
4447

@@ -261,6 +264,16 @@ export class MappingComponent implements OnInit {
261264
];
262265
var CurrentUsefulness: string =
263266
this.generalLabels[this.YamlObject[dim][subDim][task]['usefulness']];
267+
268+
var CurrentEvidence: string =
269+
this.YamlObject[dim][subDim][task]['evidence'];
270+
271+
var CurrentComments: string =
272+
this.YamlObject[dim][subDim][task]['comments'];
273+
274+
var CurrentAssessment: string =
275+
this.YamlObject[dim][subDim][task]['assessment'];
276+
264277
var CurrentDependsOn: string[] =
265278
this.YamlObject[dim][subDim][task]['dependsOn'];
266279
try {
@@ -289,6 +302,9 @@ export class MappingComponent implements OnInit {
289302
usefulness: CurrentUsefulness,
290303
dependsOn: CurrentDependsOn,
291304
implementation: CurrentImplementation,
305+
evidence: CurrentEvidence,
306+
comments: CurrentComments,
307+
assessment: CurrentAssessment,
292308
};
293309
if (ISOArray.length == 0) {
294310
this.allMappingDataSortedByISO.push(this.temporaryMappingElement);

src/app/component/matrix/matrix.component.html

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,13 @@
3636
<!-- Dimension Column -->
3737
<ng-container matColumnDef="Dimension">
3838
<th mat-header-cell *matHeaderCellDef>Dimension</th>
39-
<td mat-cell *matCellDef="let element">{{ element.Dimension }}</td>
39+
<td mat-cell *matCellDef="let element">
40+
<img
41+
src="assets/images/{{ element.Dimension }}.png"
42+
height="40px"
43+
alt="" />
44+
{{ element.Dimension }}
45+
</td>
4046
</ng-container>
4147

4248
<!-- Sub Dimension Column -->

src/app/component/task-description/task-description.component.html

Lines changed: 48 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,12 @@ <h1>
33
{{ currentTask.dimension }} -> {{ currentTask.subDimension }}:
44
{{ currentTask.taskName }}
55
</h1>
6+
67
<div class="example-action-buttons">
78
<button mat-raised-button (click)="openall()">Expand All</button>
89
<button mat-raised-button (click)="closeall()">Collapse All</button>
910
</div>
11+
1012
<mat-accordion multi="true">
1113
<mat-expansion-panel [expanded]="true">
1214
<mat-expansion-panel-header>
@@ -16,6 +18,7 @@ <h1>
1618
</mat-expansion-panel-header>
1719
<p [innerHTML]="currentTask.description"></p>
1820
</mat-expansion-panel>
21+
1922
<mat-expansion-panel>
2023
<mat-expansion-panel-header>
2124
<mat-panel-title>
@@ -24,6 +27,7 @@ <h1>
2427
</mat-expansion-panel-header>
2528
<p [innerHTML]="currentTask.risk"></p>
2629
</mat-expansion-panel>
30+
2731
<mat-expansion-panel>
2832
<mat-expansion-panel-header>
2933
<mat-panel-title>
@@ -32,6 +36,7 @@ <h1>
3236
</mat-expansion-panel-header>
3337
<p [innerHTML]="currentTask.measure"></p>
3438
</mat-expansion-panel>
39+
3540
<mat-expansion-panel *ngIf="currentTask.implementatonGuide">
3641
<mat-expansion-panel-header>
3742
<mat-panel-title>
@@ -40,6 +45,7 @@ <h1>
4045
</mat-expansion-panel-header>
4146
<p [innerHTML]="currentTask.implementatonGuide"></p>
4247
</mat-expansion-panel>
48+
4349
<mat-expansion-panel>
4450
<mat-expansion-panel-header>
4551
<mat-panel-title>
@@ -50,6 +56,7 @@ <h1>
5056
<p>Time: {{ this.GeneralLabels[this.currentTask.time] }}</p>
5157
<p>Resources: {{ this.GeneralLabels[this.currentTask.resources] }}</p>
5258
</mat-expansion-panel>
59+
5360
<mat-expansion-panel *ngIf="currentTask.usefulness !== -1">
5461
<mat-expansion-panel-header>
5562
<mat-panel-title>
@@ -58,6 +65,25 @@ <h1>
5865
</mat-expansion-panel-header>
5966
<p>{{ this.GeneralLabels[this.currentTask.usefulness] }}</p>
6067
</mat-expansion-panel>
68+
69+
<mat-expansion-panel>
70+
<mat-expansion-panel-header>
71+
<mat-panel-title>
72+
<b>Evidence</b>
73+
</mat-panel-title>
74+
</mat-expansion-panel-header>
75+
<p [innerHTML]="currentTask.evidence"></p>
76+
</mat-expansion-panel>
77+
78+
<mat-expansion-panel>
79+
<mat-expansion-panel-header>
80+
<mat-panel-title>
81+
<b>Assessment</b>
82+
</mat-panel-title>
83+
</mat-expansion-panel-header>
84+
<p [innerHTML]="currentTask.assessment"></p>
85+
</mat-expansion-panel>
86+
6187
<mat-expansion-panel>
6288
<mat-expansion-panel-header>
6389
<mat-panel-title>
@@ -107,6 +133,7 @@ <h1>
107133
</mat-accordion>
108134
</p>
109135
</mat-expansion-panel>
136+
110137
<mat-expansion-panel>
111138
<mat-expansion-panel-header>
112139
<mat-panel-title>
@@ -138,6 +165,18 @@ <h1>
138165
</mat-accordion>
139166
</p>
140167
</mat-expansion-panel>
168+
169+
<mat-expansion-panel>
170+
<mat-expansion-panel-header>
171+
<mat-panel-title>
172+
<b>Implemented</b>
173+
</mat-panel-title>
174+
</mat-expansion-panel-header>
175+
<div
176+
*ngIf="currentTask.isImplemented; then thenBlock; else elseBlock"></div>
177+
<ng-template #thenBlock> Implemented </ng-template>
178+
<ng-template #elseBlock> Not Implemented </ng-template>
179+
</mat-expansion-panel>
141180
<mat-expansion-panel>
142181
<mat-expansion-panel-header>
143182
<mat-panel-title>
@@ -149,5 +188,14 @@ <h1>
149188
subDimension="{{ currentTask.subDimension }}"
150189
taskName="{{ currentTask.taskName }}"></app-dependency-graph>
151190
</mat-expansion-panel>
191+
192+
<mat-expansion-panel>
193+
<mat-expansion-panel-header>
194+
<mat-panel-title>
195+
<b>Comments</b>
196+
</mat-panel-title>
197+
</mat-expansion-panel-header>
198+
<p [innerHTML]="currentTask.comments"></p>
199+
</mat-expansion-panel>
152200
</mat-accordion>
153201
</div>

src/app/component/task-description/task-description.component.ts

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,10 @@ export interface taskDescription {
2727
dependsOn: string[];
2828
implementation: implementation[];
2929
usefulness: number;
30+
evidence: string;
31+
assessment: string;
32+
comments: string;
33+
isImplemented: boolean;
3034
}
3135

3236
@Component({
@@ -52,6 +56,10 @@ export class TaskDescriptionComponent implements OnInit {
5256
dependsOn: [],
5357
implementation: [],
5458
usefulness: -1,
59+
assessment: '',
60+
evidence: '',
61+
comments: '',
62+
isImplemented: false,
5563
};
5664

5765
YamlObject: any;
@@ -152,6 +160,19 @@ export class TaskDescriptionComponent implements OnInit {
152160
this.currentTask.implementation = this.defineImplementationObject(
153161
data['implementation']
154162
);
163+
164+
this.currentTask.evidence = this.defineStringValues(data['evidence'], '');
165+
166+
this.currentTask.comments = this.defineStringValues(data['comments'], '');
167+
168+
this.currentTask.assessment = this.defineStringValues(
169+
data['assessment'],
170+
''
171+
);
172+
this.currentTask.isImplemented = this.defineBooleanValues(
173+
data['isImplemented'],
174+
false
175+
);
155176
});
156177
}
157178

@@ -166,6 +187,17 @@ export class TaskDescriptionComponent implements OnInit {
166187
}
167188
}
168189

190+
defineBooleanValues(
191+
dataToCheck: boolean,
192+
valueOfDataIfUndefined: boolean
193+
): boolean {
194+
try {
195+
return dataToCheck;
196+
} catch {
197+
return valueOfDataIfUndefined;
198+
}
199+
}
200+
169201
defineStringArrayValues(
170202
dataToCheck: string[],
171203
valueOfDataIfUndefined: string[]
@@ -187,6 +219,7 @@ export class TaskDescriptionComponent implements OnInit {
187219
return valueOfDataIfUndefined;
188220
}
189221
}
222+
190223
defineImplementationObject(dataToCheck: implementation[]): implementation[] {
191224
var dataToReturn: implementation[] = [];
192225
for (var data in dataToCheck) {
478 KB
Loading
372 KB
Loading
342 KB
Loading
359 KB
Loading
566 KB
Loading

0 commit comments

Comments
 (0)