Syntax checks. Fix errors. See #68

Author: ioggstream

README.md

@@ -69,6 +69,7 @@ docker push $IMAGE_NAME
 ```
 This approach also allows teams to perform self assessment with changes tracked in a repository.
 
+
 ## Amazon EC2 Instance
 
 1. In the _EC2_ sidenav select _Instances_ and click _Launch Instance_
@@ -89,6 +90,14 @@ service docker start
 docker run -d -p 80:80 wurstbrot/dsomm:latest
 ```
 
+## Tests
+
+To run basic tests just
+
+```bash
+docker-compose -f docker-compose.dev.yaml up test-php
+```
+
 # Credits
 * The dimension _Test and Verification_ is based on Christian Schneiders [Security DevOps Maturity Model (SDOMM)](https://www.christian-schneider.net/SecurityDevOpsMaturityModel.html). _Application tests_ and _Infrastructure tests_ are added by Timo Pagel. Also, the sub-dimension _Static depth_ has been evaluated by security experts at [OWASP Stammtisch Hamburg](https://www.owasp.org/index.php/OWASP_German_Chapter_Stammtisch_Initiative/Hamburg).
 * The sub-dimension <i>Process</i> has been added after a discussion with [Francois Raynaud](https://www.linkedin.com/in/francoisraynaud/) that reactive activities are missing.

data.php

@@ -229,7 +229,7 @@ function build_table_tooltip($array, $headerWeight = 2) {
   if (IS_SHOW_EVIDENCE_TODO || $evidenceContent != "TODO")
     $html .= "<div><b>" . "Evidence" . ":</b> " . $evidenceContent . "</div>";
   $html .= "<hr />";
-  $html .= "<h$headerWeight>Usefulness and Requirements of this Activitiy"</h$headerWeight>";
+  $html .= "<h$headerWeight>Usefulness and Requirements of this Activitiy</h$headerWeight>";
   $html .= "<div><b>Usefullness:</b> " . ucfirst($mapUsefulness[$array['usefulness'] - 1]) . "</div>";
   $html .= "<div><b>Required knowledge:</b> " . ucfirst($mapKnowLedge[$array['difficultyOfImplementation']['knowledge'] - 1]) . "</div>";
   $html .= "<div><b>Required time:</b> " . ucfirst($mapTime[$array['difficultyOfImplementation']['time'] - 1]) . "</div>";

docker-compose.dev.yml

@@ -1,9 +1,15 @@
 version: "3.0"
 services:
-  dsomm:
+  dsomm: &dsomm
     build: .
     volumes:
     - .:/var/www/html
+    working_dir: /var/www/html
     ports:
     - "8080:80"
-
+  test-php:
+    <<: *dsomm
+    volumes:
+    - .:/var/www/html
+    working_dir: /var/www/html
+    entrypoint: ["/var/www/html/tests.sh"]

report-samm.php

@@ -21,7 +21,7 @@
 $old_dimension = null;
 
 
-foreach (getActions($dimensions) as list($dimension, $subdimensions, $element) {
+foreach (getActions($dimensions) as list($dimension, $subdimensions, $element)) {
     if ($dimension != $old_dimension) {
       echo "<h1>Dimension $dimension</h1>";
       $old_dimension = $dimension;