Fix indexerror in scutter

Author: ioggstream

data.php

@@ -59,6 +59,7 @@
 
 function getDifficultyOfImplementationWithDependencies($dimensions, $elementImplementation, &$allElements)
 {
+    $aggregated = ($_GET['aggregated'] ?? false) == "true" ? "true" : false;
     if ($elementImplementation == null) {
         return;
     }
@@ -69,7 +70,7 @@ function getDifficultyOfImplementationWithDependencies($dimensions, $elementImpl
     $allElements[] = $elementImplementation['difficultyOfImplementation']["time"];
     $allElements[] = $elementImplementation['difficultyOfImplementation']["resources"];
 
-    if (array_key_exists('dependsOn', $elementImplementation) && $_GET['aggregated'] == "true") {
+    if (array_key_exists('dependsOn', $elementImplementation) && $aggregated == "true") {
         foreach ($elementImplementation['dependsOn'] as $dependency) {
             $dependencyElement = getElementByName($dimensions, $dependency);
             getDifficultyOfImplementationWithDependencies($dimensions, $dependencyElement, $allElements);
@@ -87,6 +88,7 @@ function getDifficultyOfImplementationWithDependencies($dimensions, $elementImpl
 
 function getDifficultyOfImplementation($dimensions, $elementImplementation)
 {
+    $aggregated = ($_GET['aggregated'] ?? false) == "true" ? "true" : false;
     if ($elementImplementation == null) {
         return;
     }
@@ -96,7 +98,7 @@ function getDifficultyOfImplementation($dimensions, $elementImplementation)
     $value = $knowledge + $elementImplementation['difficultyOfImplementation']["time"] * 2 + $elementImplementation['difficultyOfImplementation']["resources"];
     $value = $value / 4;
 
-    if (array_key_exists('dependsOn', $elementImplementation) && $_GET['aggregated'] == "true") {
+    if (array_key_exists('dependsOn', $elementImplementation) && $aggregated == "true") {
         foreach ($elementImplementation['dependsOn'] as $dependency) {
             $dependencyElement = getElementByName($dimensions, $dependency);
             $value += getDifficultyOfImplementation($dimensions, $dependencyElement);

scutter.php

@@ -10,6 +10,8 @@
 include_once "data.php";
 include_once "functions.php";
 
+$aggregated = ($_GET['aggregated'] ?? false) == "true" ? "true" : false;
+
 
 function getJson($dimensions)
 {
@@ -21,7 +23,7 @@ function getJson($dimensions)
             foreach ($element as $activityName => $content) {
                 $values[] = array(
                     "series" => 0,
-                    "shape" => $shapes[$shape],
+                    "shape" => $shapes[$shape] ?? "square",
                     "size" => 3000,
                     "x" => getDifficultyOfImplementation($dimensions, $content),
                     "y" => $content["usefulness"],
@@ -159,16 +161,10 @@ function toggle() {
 <button id="toggleChartLabel">Toggle Label</button>
 
 <form action="?" method="get">
-<input name="aggregated" type="hidden"
 <?php
-if($_GET['aggregated'] == "true") {
-    echo "value='false'";
-}else {
-    echo "value='true'";
-}
-?>">
+    echo "<input name=\"aggregated\" type=\"hidden\" value=\"$aggregated\" />";
+?>
 
-</input>
     <button id="">
         <?php
         if($_GET['aggregated'] == "true") {