Merge pull request #189 from covexo/issue-62

Resolve #62

Author: FabianKramm

cmd/up.go

@@ -103,27 +103,31 @@ func (cmd *UpCmd) Run(cobraCmd *cobra.Command, args []string) {
 	log.StartFileLogging()
 
 	workdir, err := os.Getwd()
-
 	if err != nil {
 		log.Fatalf("Unable to determine current workdir: %s", err.Error())
 	}
 
 	cmd.workdir = workdir
 
 	configExists, _ := configutil.ConfigExists()
-
 	if !configExists {
 		initCmd := &InitCmd{
 			flags: InitCmdFlagsDefault,
 		}
 
 		initCmd.Run(nil, []string{})
 	}
+
 	cmd.kubectl, err = kubectl.NewClient()
+	if err != nil {
+		log.Fatalf("Unable to create new kubectl client: %v", err)
+	}
 
+	err = cmd.ensureNamespace()
 	if err != nil {
-		log.Fatalf("Unable to create new kubectl client: %s", err.Error())
+		log.Fatalf("Unable to create release namespace: %v", err)
 	}
+
 	cmd.initHelm()
 
 	if cmd.flags.initRegistry {
@@ -133,7 +137,7 @@ func (cmd *UpCmd) Run(cobraCmd *cobra.Command, args []string) {
 			log.StopWait()
 
 			if err != nil {
-				log.Fatalf("Docker registry error: %s", err.Error())
+				log.Fatalf("Docker registry error: %v", err)
 			}
 
 			log.Done("Docker registry started")
@@ -149,7 +153,6 @@ func (cmd *UpCmd) Run(cobraCmd *cobra.Command, args []string) {
 			cmd.buildImage()
 
 			err = configutil.SaveConfig()
-
 			if err != nil {
 				log.Fatalf("Config saving error: %s", err.Error())
 			}
@@ -181,6 +184,28 @@ func (cmd *UpCmd) Run(cobraCmd *cobra.Command, args []string) {
 	cmd.enterTerminal()
 }
 
+func (cmd *UpCmd) ensureNamespace() error {
+	config := configutil.GetConfig(false)
+	releaseNamespace := *config.DevSpace.Release.Namespace
+
+	// Check if registry namespace exists
+	_, err := cmd.kubectl.CoreV1().Namespaces().Get(releaseNamespace, metav1.GetOptions{})
+	if err != nil {
+		// Create registry namespace
+		_, err = cmd.kubectl.CoreV1().Namespaces().Create(&k8sv1.Namespace{
+			ObjectMeta: metav1.ObjectMeta{
+				Name: releaseNamespace,
+			},
+		})
+
+		if err != nil {
+			return err
+		}
+	}
+
+	return nil
+}
+
 func (cmd *UpCmd) shouldRebuild(buildFlagChanged bool) bool {
 	config := configutil.GetConfig(false)
 	mustRebuild := true

pkg/devspace/clients/helm/client.go

@@ -198,6 +198,22 @@ func ensureTiller(kubectlClient *kubernetes.Clientset, config *v1.Config, upgrad
 		ImageSpec:      "gcr.io/kubernetes-helm/tiller:v2.9.1",
 		ServiceAccount: tillerSA.ObjectMeta.Name,
 	}
+
+	// Check if tiller namespace exists
+	_, err := kubectlClient.CoreV1().Namespaces().Get(tillerNamespace, metav1.GetOptions{})
+	if err != nil {
+		// Create tiller namespace
+		_, err := kubectlClient.CoreV1().Namespaces().Create(&k8sv1.Namespace{
+			ObjectMeta: metav1.ObjectMeta{
+				Name: tillerNamespace,
+			},
+		})
+
+		if err != nil {
+			return err
+		}
+	}
+
 	_, tillerCheckErr := kubectlClient.ExtensionsV1beta1().Deployments(tillerNamespace).Get(TillerDeploymentName, metav1.GetOptions{})
 
 	// Tiller is not there
@@ -488,13 +504,13 @@ func (helmClientWrapper *HelmClientWrapper) InstallChartByPath(releaseName strin
 			return nil, err
 		}
 		chartDownloader := &helmdownloader.Manager{
-			/*		Out:        i.out,
-					ChartPath:  i.chartPath,
-					HelmHome:   settings.Home,
-					Keyring:    defaultKeyring(),
-					SkipUpdate: false,
-					Getters:    getter.All(settings),
-			*/
+		/*		Out:        i.out,
+				ChartPath:  i.chartPath,
+				HelmHome:   settings.Home,
+				Keyring:    defaultKeyring(),
+				SkipUpdate: false,
+				Getters:    getter.All(settings),
+		*/
 		}
 		err = chartDownloader.Update()
 

pkg/devspace/registry/registry.go

@@ -35,7 +35,22 @@ func InitRegistry(kubectl *kubernetes.Clientset, helm *helm.HelmClientWrapper) e
 		registryReleaseName := *registry.Release.Name
 		registryReleaseNamespace := *registry.Release.Namespace
 
-		_, err := helm.InstallChartByName(registryReleaseName, registryReleaseNamespace, "stable/docker-registry", "", registry.Release.Values)
+		// Check if registry namespace exists
+		_, err := kubectl.CoreV1().Namespaces().Get(registryReleaseNamespace, metav1.GetOptions{})
+		if err != nil {
+			// Create registry namespace
+			_, err = kubectl.CoreV1().Namespaces().Create(&k8sv1.Namespace{
+				ObjectMeta: metav1.ObjectMeta{
+					Name: registryReleaseNamespace,
+				},
+			})
+
+			if err != nil {
+				return err
+			}
+		}
+
+		_, err = helm.InstallChartByName(registryReleaseName, registryReleaseNamespace, "stable/docker-registry", "", registry.Release.Values)
 
 		if err != nil {
 			return fmt.Errorf("Unable to initialize docker registry: %s", err.Error())