Merge pull request #155 from covexo/dont-redeploy

Resolve #143

Author: FabianKramm

cmd/up.go

@@ -62,7 +62,7 @@ var UpFlagsDefault = &UpCmdFlags{
 	initRegistry:   true,
 	build:          true,
 	sync:           true,
-	deploy:         true,
+	deploy:         false,
 	portforwarding: true,
 	noSleep:        false,
 }
@@ -146,8 +146,10 @@ func (cmd *UpCmd) Run(cobraCmd *cobra.Command, args []string) {
 		log.Fatalf("Unable to create new kubectl client: %s", err.Error())
 	}
 
+	var shouldRebuild bool
+
 	if cmd.flags.build {
-		shouldRebuild := cmd.shouldRebuild(cobraCmd.Flags().Changed("build"))
+		shouldRebuild = cmd.shouldRebuild(cobraCmd.Flags().Changed("build"))
 
 		if shouldRebuild {
 			cmd.buildImage()
@@ -164,7 +166,7 @@ func (cmd *UpCmd) Run(cobraCmd *cobra.Command, args []string) {
 		}
 	}
 
-	if cmd.flags.deploy {
+	if cmd.flags.deploy || shouldRebuild {
 		cmd.deployChart()
 	} else {
 		cmd.initHelm()

pkg/devspace/sync/sync_config_test.go

@@ -100,6 +100,8 @@ func createFileAndWait(from, to, postfix string) error {
 	ioutil.WriteFile(filenameFrom, []byte(fileContents), 0666)
 
 	for i := 0; i < 50; i++ {
+		time.Sleep(time.Millisecond * 100)
+
 		if _, err := os.Stat(filenameTo); err == nil {
 			data, err := ioutil.ReadFile(filenameTo)
 			if err != nil {
@@ -111,8 +113,6 @@ func createFileAndWait(from, to, postfix string) error {
 
 			return nil
 		}
-
-		time.Sleep(time.Millisecond * 100)
 	}
 
 	return fmt.Errorf("Created file %s wasn't correctly synced to %s", filenameFrom, filenameTo)