Skip to content

Commit 48dbc5f

Browse files
author
gentele
committed
resolves #57
addresses #30 addresses #108
1 parent 8fba538 commit 48dbc5f

9 files changed

Lines changed: 346 additions & 149 deletions

File tree

Gopkg.lock

Lines changed: 11 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

cmd/init.go

Lines changed: 28 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import (
1111
"github.com/covexo/devspace/pkg/devspace/generator"
1212
"github.com/covexo/devspace/pkg/util/log"
1313
"github.com/covexo/devspace/pkg/util/randutil"
14-
"github.com/imdario/mergo"
1514
homedir "github.com/mitchellh/go-homedir"
1615

1716
"github.com/covexo/devspace/pkg/devspace/config/v1"
@@ -111,7 +110,7 @@ func (cmd *InitCmd) Run(cobraCmd *cobra.Command, args []string) {
111110
} else {
112111
cmd.config = configutil.GetConfigInstance()
113112
}
114-
mergo.Merge(cmd.config, &v1.Config{
113+
configutil.Merge(cmd.config, &v1.Config{
115114
Version: configutil.String("v1"),
116115
DevSpace: &v1.DevSpaceConfig{
117116
Release: &v1.Release{
@@ -122,12 +121,23 @@ func (cmd *InitCmd) Run(cobraCmd *cobra.Command, args []string) {
122121
Images: &map[string]*v1.ImageConfig{
123122
"default": &v1.ImageConfig{
124123
Name: configutil.String("devspace"),
124+
Build: &v1.BuildConfig{
125+
Engine: &v1.BuildEngine{
126+
Docker: &v1.DockerBuildEngine{
127+
Enabled: configutil.Bool(true),
128+
},
129+
},
130+
},
131+
Registry: configutil.String("default"),
125132
},
126133
},
127134
Registries: &map[string]*v1.RegistryConfig{
128135
"default": &v1.RegistryConfig{
129136
Auth: &v1.RegistryAuth{},
130137
},
138+
"internal": &v1.RegistryConfig{
139+
Auth: &v1.RegistryAuth{},
140+
},
131141
},
132142
})
133143
cmd.overwriteConfig = configutil.GetOverwriteConfig()
@@ -413,6 +423,20 @@ func (cmd *InitCmd) configureRegistry() {
413423
cmd.defaultRegistry.URL = registryURL
414424
internalRegistryConfig = nil
415425
} else {
426+
imageMap := *cmd.config.Images
427+
defaultImageConf, defaultImageExists := imageMap["default"]
428+
429+
if defaultImageExists {
430+
defaultImageConf.Registry = configutil.String("internal")
431+
}
432+
433+
if internalRegistryConfig == nil {
434+
internalRegistryConfig = &v1.InternalRegistry{
435+
Release: &v1.Release{},
436+
}
437+
cmd.config.Services.InternalRegistry = internalRegistryConfig
438+
}
439+
416440
if internalRegistryConfig.Release.Name == nil {
417441
internalRegistryConfig.Release.Name = configutil.String("devspace-registry")
418442
}
@@ -422,13 +446,13 @@ func (cmd *InitCmd) configureRegistry() {
422446
}
423447
overwriteRegistryMap := *cmd.overwriteConfig.Registries
424448

425-
overwriteRegistryConfig, overwriteRegistryConfigFound := overwriteRegistryMap["default"]
449+
overwriteRegistryConfig, overwriteRegistryConfigFound := overwriteRegistryMap["internal"]
426450

427451
if !overwriteRegistryConfigFound {
428452
overwriteRegistryConfig = &v1.RegistryConfig{
429453
Auth: &v1.RegistryAuth{},
430454
}
431-
overwriteRegistryMap["default"] = overwriteRegistryConfig
455+
overwriteRegistryMap["internal"] = overwriteRegistryConfig
432456
}
433457
registryAuth := overwriteRegistryConfig.Auth
434458

0 commit comments

Comments
 (0)