Fix some potential test problems

Author: FabianKramm

pkg/devspace/sync/downstream.go

@@ -52,7 +52,7 @@ func (d *downstream) startShell() error {
 	} else {
 		var err error
 
-		cmd := exec.Command("bash", "-c", "sh")
+		cmd := exec.Command("sh")
 
 		d.stdinPipe, err = cmd.StdinPipe()
 		if err != nil {

pkg/devspace/sync/sync_config.go

@@ -54,7 +54,6 @@ type SyncConfig struct {
 	verbose bool
 
 	stopOnce sync.Once
-	stopped  bool
 
 	// Used for testing
 	testing   bool
@@ -96,7 +95,7 @@ func (s *SyncConfig) Error(err error) {
 		syncLog.WithKey("local", s.WatchPath).WithKey("container", s.DestPath).Errorf("Error: %v, Stack: %v", err, errors.ErrorStack(err))
 	}
 
-	if s.stopped == false && s.errorChan != nil {
+	if s.errorChan != nil {
 		s.errorChan <- err
 	}
 }
@@ -404,8 +403,6 @@ func (s *SyncConfig) sendChangesToUpstream(changes []*fileInformation) {
 // Stop stops the sync process
 func (s *SyncConfig) Stop() {
 	s.stopOnce.Do(func() {
-		s.stopped = true
-
 		if s.upstream != nil && s.upstream.interrupt != nil {
 			close(s.upstream.interrupt)
 

pkg/devspace/sync/upstream.go

@@ -56,7 +56,7 @@ func (u *upstream) startShell() error {
 	} else {
 		var err error
 
-		cmd := exec.Command("bash", "-c", "sh")
+		cmd := exec.Command("sh")
 
 		u.stdinPipe, err = cmd.StdinPipe()
 		if err != nil {