Automatically detect expose ports from dockerfile

Author: FabianKramm

cmd/init.go

@@ -9,6 +9,7 @@ import (
 	"github.com/covexo/devspace/pkg/devspace/config/generated"
 	"github.com/covexo/devspace/pkg/devspace/kubectl"
 
+	"github.com/covexo/devspace/pkg/util/dockerfile"
 	"github.com/covexo/devspace/pkg/util/kubeconfig"
 
 	"github.com/covexo/devspace/pkg/devspace/cloud"
@@ -186,7 +187,9 @@ func (cmd *InitCmd) Run(cobraCmd *cobra.Command, args []string) {
 			cmd.configureDevSpace()
 		}
 
+		cmd.addDefaultPorts()
 		cmd.addDefaultSyncConfig()
+
 		cmd.configureRegistry()
 
 		err := configutil.SaveConfig()
@@ -308,6 +311,36 @@ func (cmd *InitCmd) configureDevSpace() {
 	config.Cluster.Namespace = namespace
 }
 
+func (cmd *InitCmd) addDefaultPorts() {
+	dockerfilePath := filepath.Join(cmd.workdir, "Dockerfile")
+	ports, err := dockerfile.GetPorts(dockerfilePath)
+	if err != nil {
+		log.Warnf("Error parsing dockerfile %s: %v", dockerfilePath, err)
+		return
+	}
+	if len(ports) == 0 {
+		return
+	}
+
+	portMappings := []*v1.PortMapping{}
+	for _, port := range ports {
+		portMappings = append(portMappings, &v1.PortMapping{
+			LocalPort:  &port,
+			RemotePort: &port,
+		})
+	}
+
+	config := configutil.GetConfig()
+	config.DevSpace.Ports = &[]*v1.PortForwardingConfig{
+		{
+			LabelSelector: &map[string]*string{
+				"release": configutil.String(configutil.DefaultDevspaceDeploymentName),
+			},
+			PortMappings: &portMappings,
+		},
+	}
+}
+
 func (cmd *InitCmd) addDefaultSyncConfig() {
 	config := configutil.GetConfig()
 

cmd/up.go

@@ -332,6 +332,12 @@ func (cmd *UpCmd) buildAndDeploy() {
 	// Build image if necessary
 	mustRedeploy := cmd.buildImages(generatedConfig)
 
+	// Save Config
+	err = generated.SaveConfig(generatedConfig)
+	if err != nil {
+		log.Fatalf("Error saving config: %v", err)
+	}
+
 	// Deploy all defined deployments
 	if config.DevSpace.Deployments != nil {
 		for _, deployConfig := range *config.DevSpace.Deployments {

pkg/util/dockerfile/get.go

@@ -0,0 +1,65 @@
+package dockerfile
+
+import (
+	"bytes"
+	"io/ioutil"
+	"regexp"
+	"strconv"
+	"strings"
+)
+
+var findExposePortsRegEx = regexp.MustCompile("$EXPOSE\\s(.*)^")
+
+// GetPorts retrieves all the exported ports from a dockerfile
+func GetPorts(filename string) ([]int, error) {
+	data, err := ioutil.ReadFile(filename)
+	if err != nil {
+		return nil, err
+	}
+
+	data = NormalizeNewlines(data)
+	lines := strings.Split(string(data), "\n")
+	ports := []int{}
+
+	for _, line := range lines {
+		match := findExposePortsRegEx.FindStringSubmatch(line)
+		if match == nil || len(match) != 2 {
+			continue
+		}
+
+		portStrings := strings.Split(match[1], " ")
+
+	OUTER:
+		for _, port := range portStrings {
+			if port == "" {
+				continue
+			}
+
+			intPort, err := strconv.Atoi(strings.Split(port, "/")[0])
+			if err != nil {
+				return nil, err
+			}
+
+			// Check if port already exists
+			for _, existingPort := range ports {
+				if existingPort == intPort {
+					continue OUTER
+				}
+			}
+
+			ports = append(ports, intPort)
+		}
+	}
+
+	return ports, nil
+}
+
+// NormalizeNewlines normalizes \r\n (windows) and \r (mac)
+// into \n (unix)
+func NormalizeNewlines(d []byte) []byte {
+	// replace CR LF \r\n (windows) with LF \n (unix)
+	d = bytes.Replace(d, []byte{13, 10}, []byte{10}, -1)
+	// replace CF \r (mac) with LF \n (unix)
+	d = bytes.Replace(d, []byte{13}, []byte{10}, -1)
+	return d
+}