Skip to content

Commit 6bec399

Browse files
authored
Merge pull request #278 from covexo/reset-removes-deockerignore
Reset removes .dockerignore
2 parents f121360 + 54ae9ef commit 6bec399

2 files changed

Lines changed: 26 additions & 1 deletion

File tree

cmd/reset.go

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ type ResetCmd struct {
2727
// ResetCmdFlags holds the command flags
2828
type ResetCmdFlags struct {
2929
deleteDockerfile bool
30+
deleteDockerignore bool
3031
deleteChart bool
3132
deleteRegistry bool
3233
deleteTiller bool
@@ -150,6 +151,20 @@ func (cmd *ResetCmd) Run(cobraCmd *cobra.Command, args []string) {
150151
}
151152
}
152153

154+
if cmd.flags.deleteDockerignore {
155+
err = cmd.deleteDockerignore()
156+
157+
if err != nil {
158+
log.Failf("Error deleting .dockerignore: %s", err.Error())
159+
160+
if cmd.shouldContinue() == false {
161+
return
162+
}
163+
} else {
164+
log.Done("Successfully deleted .dockerignore")
165+
}
166+
}
167+
153168
if cmd.flags.deleteDevspaceFolder {
154169
err = cmd.deleteDevspaceFolder()
155170

@@ -194,6 +209,12 @@ func (cmd *ResetCmd) determineResetExtent() {
194209
ValidationRegexPattern: "^(y|n)$",
195210
}) == "y"
196211

212+
cmd.flags.deleteDockerignore = *stdinutil.GetFromStdin(&stdinutil.GetFromStdinParams{
213+
Question: "Should the .dockerignore be removed? (y/n)",
214+
DefaultValue: "y",
215+
ValidationRegexPattern: "^(y|n)$",
216+
}) == "y"
217+
197218
cmd.flags.deleteChart = *stdinutil.GetFromStdin(&stdinutil.GetFromStdinParams{
198219
Question: "Should the Chart (chart/*) be removed? (y/n)",
199220
DefaultValue: "y",
@@ -291,6 +312,10 @@ func (cmd *ResetCmd) deleteDockerfile() error {
291312
return os.Remove(path.Join(cmd.workdir, "Dockerfile"))
292313
}
293314

315+
func (cmd *ResetCmd) deleteDockerignore() error {
316+
return os.Remove(path.Join(cmd.workdir, ".dockerignore"))
317+
}
318+
294319
func (cmd *ResetCmd) deleteChart() error {
295320
return os.RemoveAll(path.Join(cmd.workdir, "chart"))
296321
}

pkg/util/log/stdout_logger.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ func (s *stdoutLogger) writeMessage(fnType logFunctionType, message string) {
9191

9292
fnInformation.stream.Write([]byte(message))
9393

94-
if s.loadingText != nil {
94+
if s.loadingText != nil && fnType != fatalFn {
9595
s.loadingText.Start()
9696
}
9797
}

0 commit comments

Comments
 (0)