Check if we can access namespaces

Author: FabianKramm

cmd/up.go

@@ -140,7 +140,10 @@ func (cmd *UpCmd) Run(cobraCmd *cobra.Command, args []string) {
 		log.Fatalf("Unable to create new kubectl client: %v", err)
 	}
 
-	cmd.ensureNamespace()
+	err = cmd.ensureNamespace()
+	if err != nil {
+		log.Fatalf("Unable to create namespace: %v", err)
+	}
 
 	err = cmd.ensureClusterRoleBinding()
 	if err != nil {
@@ -196,16 +199,21 @@ func (cmd *UpCmd) Run(cobraCmd *cobra.Command, args []string) {
 	enterTerminal(cmd.kubectl, cmd.pod, cmd.flags.container, args)
 }
 
-func (cmd *UpCmd) ensureNamespace() {
+func (cmd *UpCmd) ensureNamespace() error {
 	config := configutil.GetConfig(false)
 	releaseNamespace := *config.DevSpace.Release.Namespace
 
-	// Create release namespace and ignore errors
-	_, _ = cmd.kubectl.CoreV1().Namespaces().Create(&k8sv1.Namespace{
-		ObjectMeta: metav1.ObjectMeta{
-			Name: releaseNamespace,
-		},
-	})
+	_, err := cmd.kubectl.CoreV1().Namespaces().Get(releaseNamespace, metav1.GetOptions{})
+	if err != nil {
+		// Create release namespace
+		_, err = cmd.kubectl.CoreV1().Namespaces().Create(&k8sv1.Namespace{
+			ObjectMeta: metav1.ObjectMeta{
+				Name: releaseNamespace,
+			},
+		})
+	}
+
+	return err
 }
 
 func (cmd *UpCmd) ensureClusterRoleBinding() error {

pkg/devspace/clients/helm/tiller.go

@@ -36,14 +36,20 @@ func ensureTiller(kubectlClient *kubernetes.Clientset, config *v1.Config, upgrad
 		ServiceAccount: TillerServiceAccountName,
 	}
 
-	// Create tiller namespace & ignore any errors
-	kubectlClient.CoreV1().Namespaces().Create(&k8sv1.Namespace{
-		ObjectMeta: metav1.ObjectMeta{
-			Name: tillerNamespace,
-		},
-	})
+	_, err := kubectlClient.CoreV1().Namespaces().Get(tillerNamespace, metav1.GetOptions{})
+	if err != nil {
+		// Create tiller namespace
+		_, err = kubectlClient.CoreV1().Namespaces().Create(&k8sv1.Namespace{
+			ObjectMeta: metav1.ObjectMeta{
+				Name: tillerNamespace,
+			},
+		})
+		if err != nil {
+			return err
+		}
+	}
 
-	_, err := kubectlClient.ExtensionsV1beta1().Deployments(tillerNamespace).Get(TillerDeploymentName, metav1.GetOptions{})
+	_, err = kubectlClient.ExtensionsV1beta1().Deployments(tillerNamespace).Get(TillerDeploymentName, metav1.GetOptions{})
 	if err != nil {
 		// Create tiller server
 		err = createTiller(kubectlClient, config, tillerOptions)

pkg/devspace/registry/create.go

@@ -22,15 +22,21 @@ func createRegistry(kubectl *kubernetes.Clientset, helm *helm.HelmClientWrapper,
 	registryReleaseNamespace := *internalRegistry.Release.Namespace
 	registryReleaseValues := internalRegistry.Release.Values
 
-	// Create registry namespace & ignore errors
-	kubectl.CoreV1().Namespaces().Create(&k8sv1.Namespace{
-		ObjectMeta: metav1.ObjectMeta{
-			Name: registryReleaseNamespace,
-		},
-	})
+	_, err := kubectl.CoreV1().Namespaces().Get(registryReleaseNamespace, metav1.GetOptions{})
+	if err != nil {
+		// Create registryReleaseNamespace
+		_, err = kubectl.CoreV1().Namespaces().Create(&k8sv1.Namespace{
+			ObjectMeta: metav1.ObjectMeta{
+				Name: registryReleaseNamespace,
+			},
+		})
+		if err != nil {
+			return err
+		}
+	}
 
 	// Deploy the registry
-	_, err := helm.InstallChartByName(registryReleaseName, registryReleaseNamespace, "stable/docker-registry", "", registryReleaseValues)
+	_, err = helm.InstallChartByName(registryReleaseName, registryReleaseNamespace, "stable/docker-registry", "", registryReleaseValues)
 	if err != nil {
 		return fmt.Errorf("Unable to initialize docker registry: %s", err.Error())
 	}