Skip to content

Commit 9a5d9c0

Browse files
committed
Fix internal registry issues
1 parent 5e72ee2 commit 9a5d9c0

5 files changed

Lines changed: 6 additions & 5 deletions

File tree

pkg/devspace/config/configutil/get.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,15 +68,16 @@ func GetConfig() *v1.Config {
6868

6969
err := loadConfig(configRaw, ConfigPath)
7070
if err != nil {
71-
log.Fatalf("Unable to load config: %v. Please run `devspace init -r` to correct your config", err)
71+
log.Errorf("Loading config: %v", err)
72+
log.Fatal("Please run `devspace init -r` to repair your config")
7273
}
7374

7475
//ignore error as overwrite.yaml is optional
7576
loadConfig(overwriteConfigRaw, OverwriteConfigPath)
7677

7778
merge(config, configRaw, unsafe.Pointer(&config), unsafe.Pointer(configRaw))
78-
merge(config, overwriteConfig, unsafe.Pointer(&config), unsafe.Pointer(overwriteConfig))
7979
merge(overwriteConfig, overwriteConfigRaw, unsafe.Pointer(&overwriteConfig), unsafe.Pointer(overwriteConfigRaw))
80+
merge(config, overwriteConfig, unsafe.Pointer(&config), unsafe.Pointer(overwriteConfig))
8081

8182
if config.DevSpace.Release != nil && config.DevSpace.Release.Namespace == nil {
8283
config.DevSpace.Release.Namespace = String("default")

pkg/devspace/configure/registry.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -188,6 +188,7 @@ func InternalRegistry() error {
188188
}
189189

190190
internalRegistryConfig.Release.Values = &registryReleaseValues
191+
config.Registries = &overwriteRegistryMap
191192

192193
return nil
193194
}

pkg/devspace/image/build.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,6 @@ func Build(client *kubernetes.Clientset, generatedConfig *generated.Config, imag
8080
return false, err
8181
}
8282

83-
log.Info(registryURL, *imageConf.Name)
84-
8583
if len(registryURL) > 0 {
8684
// Crop registry Url from imageName
8785
imageName = imageName[len(registryURL)+1:]

pkg/devspace/registry/create.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,7 @@ func createOrUpdateRegistrySecret(kubectl *kubernetes.Clientset, internalRegistr
8888
registryReleaseNamespace := *internalRegistry.Release.Namespace
8989

9090
registryAuth := registryConfig.Auth
91+
9192
htpasswdSecretName := registryReleaseName + "-docker-registry-secret"
9293
htpasswdSecret, err := kubectl.Core().Secrets(registryReleaseNamespace).Get(htpasswdSecretName, metav1.GetOptions{})
9394
if err != nil {

pkg/devspace/registry/registry.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ func GetImageURL(generatedConfig *generated.Config, imageConfig *v1.ImageConfig,
148148
if imageConfig.Tag != nil {
149149
image = image + ":" + *imageConfig.Tag
150150
} else {
151-
image = image + ":" + generatedConfig.ImageTags[image]
151+
image = image + ":" + generatedConfig.ImageTags[*imageConfig.Name]
152152
}
153153
}
154154

0 commit comments

Comments
 (0)