Skip to content

Commit a0d1ce7

Browse files
authored
Merge pull request #151 from covexo/minikube
Minikube
2 parents 82f06d4 + bb1ae87 commit a0d1ce7

8 files changed

Lines changed: 487 additions & 258 deletions

File tree

Gopkg.lock

Lines changed: 5 additions & 184 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/devspace/sync/downstream.go

Lines changed: 39 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import (
66
"io"
77
"io/ioutil"
88
"os"
9+
"os/exec"
910
"path"
1011
"strconv"
1112
"strings"
@@ -37,15 +38,41 @@ func (d *downstream) start() error {
3738
}
3839

3940
func (d *downstream) startShell() error {
40-
stdinPipe, stdoutPipe, stderrPipe, err := kubectl.Exec(d.config.Kubectl, d.config.Pod, d.config.Container.Name, []string{"sh"}, false, nil)
41+
if d.config.testing == false {
42+
stdinPipe, stdoutPipe, stderrPipe, err := kubectl.Exec(d.config.Kubectl, d.config.Pod, d.config.Container.Name, []string{"sh"}, false, nil)
4143

42-
if err != nil {
43-
return errors.Trace(err)
44-
}
44+
if err != nil {
45+
return errors.Trace(err)
46+
}
47+
48+
d.stdinPipe = stdinPipe
49+
d.stdoutPipe = stdoutPipe
50+
d.stderrPipe = stderrPipe
51+
} else {
52+
var err error
53+
54+
cmd := exec.Command("bash", "-c", "sh")
55+
56+
d.stdinPipe, err = cmd.StdinPipe()
57+
if err != nil {
58+
return err
59+
}
4560

46-
d.stdinPipe = stdinPipe
47-
d.stdoutPipe = stdoutPipe
48-
d.stderrPipe = stderrPipe
61+
d.stdoutPipe, err = cmd.StdoutPipe()
62+
if err != nil {
63+
return err
64+
}
65+
66+
d.stderrPipe, err = cmd.StderrPipe()
67+
if err != nil {
68+
return err
69+
}
70+
71+
err = cmd.Start()
72+
if err != nil {
73+
return err
74+
}
75+
}
4976

5077
return nil
5178
}
@@ -347,18 +374,19 @@ func (d *downstream) createFolders(createFolders []*fileInformation) {
347374
}
348375

349376
for _, element := range createFolders {
350-
if fileMap[element.Name] == nil && element.IsDirectory {
377+
if element.IsDirectory {
351378
if numCreateFolders <= 3 {
352379
d.config.Logln("[Downstream] Create folder: " + element.Name)
353380
}
354381

355382
err := os.MkdirAll(path.Join(d.config.WatchPath, element.Name), 0755)
356-
357383
if err != nil {
358-
d.config.Logln(err)
384+
d.config.Error(err)
359385
}
360386

361-
d.config.fileIndex.CreateDirInFileMap(element.Name)
387+
if fileMap[element.Name] == nil {
388+
d.config.fileIndex.CreateDirInFileMap(element.Name)
389+
}
362390
}
363391
}
364392
}

0 commit comments

Comments
 (0)