Skip to content

Commit a47642f

Browse files
author
gentele
committed
resolve #315
1 parent d1ee89d commit a47642f

4 files changed

Lines changed: 10 additions & 15 deletions

File tree

cmd/init.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -218,6 +218,7 @@ func (cmd *InitCmd) initChartGenerator() {
218218

219219
func (cmd *InitCmd) useCloudProvider() bool {
220220
config := configutil.GetConfig()
221+
overwriteConfig := configutil.GetOverwriteConfig()
221222
providerConfig, err := cloud.ParseCloudConfig()
222223
if err != nil {
223224
log.Fatalf("Error loading cloud config: %v", err)
@@ -256,7 +257,7 @@ func (cmd *InitCmd) useCloudProvider() bool {
256257
config.Cluster.CloudProvider = &cloudProviderSelected
257258

258259
log.StartWait("Logging into cloud provider " + providerConfig[cloudProviderSelected].Host + cloud.LoginEndpoint + "...")
259-
err := cloud.Update(providerConfig, config, addToContext, true)
260+
err := cloud.Update(providerConfig, *config.Cluster.CloudProvider, overwriteConfig, addToContext, true)
260261
log.StopWait()
261262
if err != nil {
262263
log.Fatalf("Couldn't authenticate to DevSpace Cloud: %v", err)
@@ -281,7 +282,7 @@ func (cmd *InitCmd) useCloudProvider() bool {
281282
config.Cluster.CloudProvider = configutil.String(cloud.DevSpaceCloudProviderName)
282283

283284
log.StartWait("Logging into cloud provider " + providerConfig[cloud.DevSpaceCloudProviderName].Host + cloud.LoginEndpoint + "...")
284-
err := cloud.Update(providerConfig, config, addToContext, true)
285+
err := cloud.Update(providerConfig, *config.Cluster.CloudProvider, overwriteConfig, addToContext, true)
285286
log.StopWait()
286287
if err != nil {
287288
log.Fatalf("Couldn't authenticate to DevSpace Cloud: %v", err)

pkg/devspace/cloud/login.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -112,9 +112,7 @@ func Login(provider *Provider) (string, *api.Cluster, *api.AuthInfo, error) {
112112
}
113113

114114
// Update updates the cloud provider information if necessary
115-
func Update(providerConfig ProviderConfig, dsConfig *v1.Config, useKubeContext, switchKubeContext bool) error {
116-
cloudProvider := *dsConfig.Cluster.CloudProvider
117-
115+
func Update(providerConfig ProviderConfig, cloudProvider string, dsConfig *v1.Config, useKubeContext, switchKubeContext bool) error {
118116
// Don't update anything if we don't use a cloud provider
119117
if cloudProvider == "" {
120118
return nil

pkg/devspace/config/configutil/get.go

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -124,14 +124,7 @@ func SetDefaultsOnce() {
124124
}
125125

126126
if deployConfig.Namespace == nil {
127-
defaultDeployments := *defaultConfig.DevSpace.Deployments
128-
defaultValue := String("")
129-
130-
defaultDeployments = append(defaultDeployments, &v1.DeploymentConfig{
131-
Namespace: defaultValue,
132-
})
133-
defaultConfig.DevSpace.Deployments = &defaultDeployments
134-
deployConfig.Namespace = defaultValue
127+
deployConfig.Namespace = String("")
135128
}
136129

137130
if deployConfig.Helm != nil {
@@ -157,9 +150,11 @@ func SetDefaultsOnce() {
157150
}
158151

159152
if needTiller && config.Tiller == nil {
160-
config.Tiller = &v1.TillerConfig{
153+
defaultConfig.Tiller = &v1.TillerConfig{
161154
Namespace: &defaultNamespace,
162155
}
156+
157+
config.Tiller = defaultConfig.Tiller
163158
}
164159
}
165160

@@ -174,6 +169,7 @@ func SetDefaultsOnce() {
174169
}
175170

176171
if config.InternalRegistry != nil {
172+
defaultConfig.InternalRegistry.Namespace = &defaultNamespace
177173
config.InternalRegistry.Namespace = &defaultNamespace
178174
}
179175
})

pkg/devspace/kubectl/client.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ func loadCloudConfig(config *v1.Config, log log.Logger) error {
155155
}
156156

157157
log.StartWait("Login to cloud provider")
158-
err = cloud.Update(providerConfig, config, config.Cluster.APIServer == nil, false)
158+
err = cloud.Update(providerConfig, *config.Cluster.CloudProvider, config, config.Cluster.APIServer == nil, false)
159159
log.StopWait()
160160
if err != nil {
161161
log.Warnf("Couldn't update cloud provider %s information: %v", *config.Cluster.CloudProvider, err)

0 commit comments

Comments
 (0)