Check if find command found anything

Author: FabianKramm

pkg/devspace/sync/downstream.go

@@ -101,15 +101,20 @@ func (d *downstream) mainLoop() error {
 
 	for {
 		removeFiles := d.cloneFileMap()
+		removeFilesLen := len(removeFiles)
 
 		// Check for changes remotely
 		createFiles, err := d.collectChanges(removeFiles)
 		if err != nil {
 			return errors.Trace(err)
 		}
 
-		amountChanges := len(createFiles) + len(removeFiles)
+		// There is an issue with collect changes, hence we return an error
+		if removeFilesLen == len(removeFiles) {
+			return errors.New("Sync cannot execute find command remotely")
+		}
 
+		amountChanges := len(createFiles) + len(removeFiles)
 		if lastAmountChanges > 0 && amountChanges == lastAmountChanges {
 			err = d.applyChanges(createFiles, removeFiles)
 			if err != nil {
@@ -150,6 +155,131 @@ func (d *downstream) cloneFileMap() map[string]*fileInformation {
 	return mapClone
 }
 
+func (d *downstream) collectChanges(removeFiles map[string]*fileInformation) ([]*fileInformation, error) {
+	createFiles := make([]*fileInformation, 0, 128)
+
+	// Write find command to stdin pipe
+	cmd := getFindCommand(d.config.DestPath)
+	_, err := d.stdinPipe.Write([]byte(cmd))
+	if err != nil {
+		return nil, errors.Trace(err)
+	}
+
+	buf := make([]byte, 0, 512)
+	overlap := ""
+	done := false
+
+	for done == false {
+		n, err := d.stdoutPipe.Read(buf[:cap(buf)])
+		buf = buf[:n]
+
+		if n == 0 {
+			if err == nil {
+				continue
+			}
+			if err == io.EOF {
+				return nil, errors.Trace(fmt.Errorf("[Downstream] Stream closed unexpectedly"))
+			}
+
+			return nil, errors.Trace(err)
+		}
+
+		// Error reading from stdout
+		if err != nil && err != io.EOF {
+			return nil, errors.Trace(err)
+		}
+
+		done, overlap, err = d.parseLines(string(buf), overlap, &createFiles, removeFiles)
+		if err != nil {
+			if _, ok := err.(parsingError); ok {
+				time.Sleep(time.Second * 4)
+				return d.collectChanges(removeFiles)
+			}
+
+			// No trace here because it could be a parsing error
+			return nil, errors.Trace(err)
+		}
+	}
+
+	return createFiles, nil
+}
+
+func (d *downstream) parseLines(buffer, overlap string, createFiles *[]*fileInformation, removeFiles map[string]*fileInformation) (bool, string, error) {
+	lines := strings.Split(buffer, "\n")
+
+	for index, element := range lines {
+		line := ""
+
+		if index == 0 {
+			if len(lines) > 1 {
+				line = overlap + element
+			} else {
+				overlap += element
+			}
+		} else if index == len(lines)-1 {
+			overlap = element
+		} else {
+			line = element
+		}
+
+		if line == EndAck || overlap == EndAck {
+			return true, overlap, nil
+		} else if line == ErrorAck || overlap == ErrorAck {
+			return true, "", parsingError{
+				msg: "Parsing Error",
+			}
+		} else if line != "" {
+			err := d.evaluateFile(line, createFiles, removeFiles)
+
+			if err != nil {
+				return true, "", errors.Trace(err)
+			}
+		}
+	}
+
+	return false, overlap, nil
+}
+
+func (d *downstream) evaluateFile(fileline string, createFiles *[]*fileInformation, removeFiles map[string]*fileInformation) error {
+	d.config.fileIndex.fileMapMutex.Lock()
+	defer d.config.fileIndex.fileMapMutex.Unlock()
+
+	fileInformation, err := parseFileInformation(fileline, d.config.DestPath)
+
+	// Error parsing line
+	if err != nil {
+		return errors.Trace(err)
+	}
+
+	// No file found
+	if fileInformation == nil {
+		return nil
+	}
+
+	// File found don't delete it
+	delete(removeFiles, fileInformation.Name)
+
+	// Update mode, gid & uid if exists
+	if d.config.fileIndex.fileMap[fileInformation.Name] != nil {
+		d.config.fileIndex.fileMap[fileInformation.Name].RemoteMode = fileInformation.RemoteMode
+		d.config.fileIndex.fileMap[fileInformation.Name].RemoteGID = fileInformation.RemoteGID
+		d.config.fileIndex.fileMap[fileInformation.Name].RemoteUID = fileInformation.RemoteUID
+	}
+
+	// Exclude symlinks
+	if fileInformation.IsSymbolicLink {
+		// Add them to the fileMap though
+		d.config.fileIndex.fileMap[fileInformation.Name] = fileInformation
+	}
+
+	// Should we download the file / folder?
+	if shouldDownload(fileInformation, d.config) {
+		*createFiles = append(*createFiles, fileInformation)
+	}
+
+	return nil
+}
+
 func (d *downstream) applyChanges(createFiles []*fileInformation, removeFiles map[string]*fileInformation) error {
 	var err error
 
@@ -384,129 +514,3 @@ func (d *downstream) createFolders(createFolders []*fileInformation) {
 		}
 	}
 }
-
-func (d *downstream) collectChanges(removeFiles map[string]*fileInformation) ([]*fileInformation, error) {
-	createFiles := make([]*fileInformation, 0, 128)
-
-	// Write find command to stdin pipe
-	cmd := getFindCommand(d.config.DestPath)
-	_, err := d.stdinPipe.Write([]byte(cmd))
-	if err != nil {
-		return nil, errors.Trace(err)
-	}
-
-	buf := make([]byte, 0, 512)
-	overlap := ""
-	done := false
-
-	for done == false {
-		n, err := d.stdoutPipe.Read(buf[:cap(buf)])
-		buf = buf[:n]
-
-		if n == 0 {
-			if err == nil {
-				continue
-			}
-
-			if err == io.EOF {
-				return nil, errors.Trace(fmt.Errorf("[Downstream] Stream closed unexpectedly"))
-			}
-
-			return nil, errors.Trace(err)
-		}
-
-		// Error reading from stdout
-		if err != nil && err != io.EOF {
-			return nil, errors.Trace(err)
-		}
-
-		done, overlap, err = d.parseLines(string(buf), overlap, &createFiles, removeFiles)
-		if err != nil {
-			if _, ok := err.(parsingError); ok {
-				time.Sleep(time.Second * 4)
-				return d.collectChanges(removeFiles)
-			}
-
-			// No trace here because it could be a parsing error
-			return nil, errors.Trace(err)
-		}
-	}
-
-	return createFiles, nil
-}
-
-func (d *downstream) parseLines(buffer, overlap string, createFiles *[]*fileInformation, removeFiles map[string]*fileInformation) (bool, string, error) {
-	lines := strings.Split(buffer, "\n")
-
-	for index, element := range lines {
-		line := ""
-
-		if index == 0 {
-			if len(lines) > 1 {
-				line = overlap + element
-			} else {
-				overlap += element
-			}
-		} else if index == len(lines)-1 {
-			overlap = element
-		} else {
-			line = element
-		}
-
-		if line == EndAck || overlap == EndAck {
-			return true, overlap, nil
-		} else if line == ErrorAck || overlap == ErrorAck {
-			return true, "", parsingError{
-				msg: "Parsing Error",
-			}
-		} else if line != "" {
-			err := d.evaluateFile(line, createFiles, removeFiles)
-
-			if err != nil {
-				return true, "", errors.Trace(err)
-			}
-		}
-	}
-
-	return false, overlap, nil
-}
-
-func (d *downstream) evaluateFile(fileline string, createFiles *[]*fileInformation, removeFiles map[string]*fileInformation) error {
-	d.config.fileIndex.fileMapMutex.Lock()
-	defer d.config.fileIndex.fileMapMutex.Unlock()
-
-	fileInformation, err := parseFileInformation(fileline, d.config.DestPath)
-
-	// Error parsing line
-	if err != nil {
-		return errors.Trace(err)
-	}
-
-	// No file found
-	if fileInformation == nil {
-		return nil
-	}
-
-	// File found don't delete it
-	delete(removeFiles, fileInformation.Name)
-
-	// Update mode, gid & uid if exists
-	if d.config.fileIndex.fileMap[fileInformation.Name] != nil {
-		d.config.fileIndex.fileMap[fileInformation.Name].RemoteMode = fileInformation.RemoteMode
-		d.config.fileIndex.fileMap[fileInformation.Name].RemoteGID = fileInformation.RemoteGID
-		d.config.fileIndex.fileMap[fileInformation.Name].RemoteUID = fileInformation.RemoteUID
-	}
-
-	// Exclude symlinks
-	if fileInformation.IsSymbolicLink {
-		// Add them to the fileMap though
-		d.config.fileIndex.fileMap[fileInformation.Name] = fileInformation
-	}
-
-	// Should we download the file / folder?
-	if shouldDownload(fileInformation, d.config) {
-		*createFiles = append(*createFiles, fileInformation)
-	}
-
-	return nil
-}