Skip to content

Commit c7b4bf4

Browse files
author
gentele
committed
fix codeclimate
1 parent 8e2ad15 commit c7b4bf4

3 files changed

Lines changed: 4 additions & 3 deletions

File tree

cmd/up.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -298,7 +298,7 @@ func (cmd *UpCmd) buildImages(buildFlagChanged bool) bool {
298298
log.Fatal(registryErr)
299299
}
300300
var buildErr error
301-
var imageBuilder builder.BuilderInterface
301+
var imageBuilder builder.Interface
302302

303303
buildInfo := "Building image '%s' with engine '%s'"
304304

pkg/devspace/builder/interface.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@ package builder
22

33
import "github.com/docker/docker/api/types"
44

5-
type BuilderInterface interface {
5+
// Interface defines methods for builders (e.g. docker, kaniko)
6+
type Interface interface {
67
Authenticate(username, password string, checkCredentialsStore bool) (*types.AuthConfig, error)
78
BuildImage(contextPath, dockerfilePath string, options *types.ImageBuildOptions) error
89
PushImage() error

pkg/devspace/builder/kaniko/kaniko.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,7 @@ func (b *Builder) BuildImage(contextPath, dockerfilePath string, options *types.
237237
return nil
238238
}
239239

240-
// PushImage is required to implement builder.BuilderInterface
240+
// PushImage is required to implement builder.Interface
241241
func (b *Builder) PushImage() error {
242242
return nil
243243
}

0 commit comments

Comments
 (0)