Skip to content

Commit dcdcfe2

Browse files
author
gentele
committed
resolve #57
1 parent 79f2616 commit dcdcfe2

4 files changed

Lines changed: 20 additions & 6 deletions

File tree

cmd/init.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ func (cmd *InitCmd) Run(cobraCmd *cobra.Command, args []string) {
140140
},
141141
},
142142
})
143-
cmd.overwriteConfig = configutil.GetOverwriteConfig()
143+
cmd.overwriteConfig = configutil.GetOverwriteConfig(false)
144144

145145
imageMap := *cmd.config.Images
146146
cmd.defaultImage, _ = imageMap["default"]

cmd/up.go

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,7 @@ func (cmd *UpCmd) shouldRebuild(imageConf *v1.ImageConfig, dockerfilePath string
256256
// returns true when one of the images had to be rebuild
257257
func (cmd *UpCmd) buildImages(buildFlagChanged bool) bool {
258258
re := false
259-
config := configutil.GetConfig(true)
259+
config := configutil.GetConfig(false)
260260

261261
for imageName, imageConf := range *config.Images {
262262
dockerfilePath := "./Dockerfile"
@@ -317,7 +317,9 @@ func (cmd *UpCmd) buildImages(buildFlagChanged bool) bool {
317317
if registryConf.Auth.Password != nil {
318318
password = *registryConf.Auth.Password
319319
}
320+
log.StartWait("Authenticating (" + *registryConf.URL + ")")
320321
buildErr = dockerBuilder.Authenticate(username, password, len(username) == 0)
322+
log.StopWait()
321323

322324
if buildErr == nil {
323325
buildOptions := &types.ImageBuildOptions{}
@@ -327,10 +329,14 @@ func (cmd *UpCmd) buildImages(buildFlagChanged bool) bool {
327329
buildOptions.BuildArgs = *imageConf.Build.Engine.Docker.Options.BuildArgs
328330
}
329331
}
332+
log.StartWait("Building Docker image")
330333
buildErr = dockerBuilder.BuildImage(contextPath, dockerfilePath, buildOptions)
334+
log.StopWait()
331335

332336
if buildErr == nil {
337+
log.StartWait("Pushing Docker image")
333338
buildErr = dockerBuilder.PushImage()
339+
log.StopWait()
334340
}
335341
}
336342
}

pkg/devspace/config/configutil/get.go

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,14 +46,18 @@ func ConfigExists() (bool, error) {
4646
//GetConfig returns the config merged from .devspace/config.yaml and .devspace/overwrite.yaml
4747
func GetConfig(reload bool) *v1.Config {
4848
if !configLoaded || reload {
49+
if reload {
50+
config = makeConfig()
51+
configRaw = makeConfig()
52+
}
4953
configLoaded = true
5054

5155
err := loadConfig(configRaw, configPath)
5256

5357
if err != nil {
5458
log.Fatal("Unable to load config.")
5559
}
56-
GetOverwriteConfig()
60+
GetOverwriteConfig(false)
5761

5862
merge(config, configRaw, unsafe.Pointer(&config), unsafe.Pointer(configRaw))
5963
merge(config, overwriteConfig, unsafe.Pointer(&config), unsafe.Pointer(overwriteConfig))
@@ -66,8 +70,12 @@ func GetConfig(reload bool) *v1.Config {
6670
}
6771

6872
//GetOverwriteConfig returns the config retrieved from .devspace/overwrite.yaml
69-
func GetOverwriteConfig() *v1.Config {
70-
if !overwriteConfigLoaded {
73+
func GetOverwriteConfig(reload bool) *v1.Config {
74+
if !overwriteConfigLoaded || reload {
75+
if reload {
76+
overwriteConfig = makeConfig()
77+
overwriteConfigRaw = makeConfig()
78+
}
7179
overwriteConfigLoaded = true
7280

7381
//ignore error as overwrite.yaml is optional

pkg/devspace/config/v1/image.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ type BuildConfig struct {
1313
ContextPath *string `yaml:"contextPath"`
1414
DockerfilePath *string `yaml:"dockerfilePath"`
1515
Engine *BuildEngine `yaml:"engine"`
16-
LatestTimestamp *string `yaml:"latestTime"`
16+
LatestTimestamp *string `yaml:"latestTimestamp"`
1717
}
1818

1919
//BuildEngine defines which build engine to use

0 commit comments

Comments
 (0)