Properly classify recursion error on Python <=3.4

Author: dflook

.config/corpus_report.markdownlint.yaml

@@ -0,0 +1,3 @@
+# Markdownlint configuration for corpus test reports
+# Disable line length rule since tables naturally exceed 80 characters
+MD013: false

.github/workflows/test_corpus.yaml

@@ -144,4 +144,11 @@ jobs:
           volumes: |
             /corpus-results:/corpus-results
           run: |
-            python3.13 workflow/corpus_test/generate_report.py /corpus-results ${{ inputs.ref }} ${{ steps.ref.outputs.commit }} ${{ inputs.base-ref }} ${{ steps.base-ref.outputs.commit }} >> $GITHUB_STEP_SUMMARY
+            python3.13 workflow/corpus_test/generate_report.py /corpus-results ${{ inputs.ref }} ${{ steps.ref.outputs.commit }} ${{ inputs.base-ref }} ${{ steps.base-ref.outputs.commit }} | tee -a $GITHUB_STEP_SUMMARY > report.md
+
+      - name: Lint Report
+        uses: DavidAnson/markdownlint-cli2-action@05f32210e84442804257b2a6f20b273450ec8265 # v19
+        continue-on-error: true
+        with:
+          config: '.config/corpus_report.markdownlint.yaml'
+          globs: 'report.md'

corpus_test/generate_report.py

@@ -76,7 +76,7 @@ def add(self, result: Result):
             self.recursion_error_count += 1
         elif result.outcome == 'UnstableMinification':
             self.unstable_minification_count += 1
-        elif result.outcome.startswith('Exception') is not is_syntax_error(self.python_version, result):
+        elif result.outcome.startswith('Exception') and not is_syntax_error(self.python_version, result):
             self.exception_count += 1
 
     @property
@@ -101,13 +101,13 @@ def larger_than_original(self) -> Iterable[Result]:
     def recursion_error(self) -> Iterable[Result]:
         """Return those entries that have a recursion error"""
         for result in self.entries.values():
-            if result.outcome == 'RecursionError':
+            if is_recursion_error(self.python_version, result):
                 yield result
 
     def exception(self) -> Iterable[Result]:
         """Return those entries that have an exception"""
         for result in self.entries.values():
-            if result.outcome.startswith('Exception'):
+            if result.outcome.startswith('Exception') and not is_syntax_error(self.python_version, result) and not is_recursion_error(self.python_version, result):
                 yield result
 
     def unstable_minification(self) -> Iterable[Result]:
@@ -271,7 +271,7 @@ def report_exceptions(results_dir: str, python_versions: list[str], minifier_sha
             yield f'| {entry.corpus_entry} | {python_version} | {entry.outcome} |'
 
     if not exceptions_found:
-        yield ' None | | |'
+        yield '| None | | |'
 
 
 def report_larger_than_base(results_dir: str, python_versions: list[str], minifier_sha: str, base_sha: str) -> str:
@@ -387,7 +387,7 @@ def report(results_dir: str, minifier_ref: str, minifier_sha: str, base_ref: str
                 f'| {format_difference(summary.larger_than_original(), base_summary.larger_than_original())} ' +
                 f'| {format_difference(summary.recursion_error(), base_summary.recursion_error())} ' +
                 f'| {format_difference(summary.unstable_minification(), base_summary.unstable_minification())} ' +
-                f'| {format_difference(summary.exception(), base_summary.exception())} '
+                f'| {format_difference(summary.exception(), base_summary.exception())} |'
         )
 
     if ENHANCED_REPORT: