Address linting warnings

Author: dflook

test/test_bind_names.py

@@ -778,7 +778,7 @@ class LazyList:
     assert_namespace_tree(source, expected_namespaces)
 
 
-def test_class_namespace_undefined_nonlocal_name_disallow_rename():
+def test_class_namespace_undefined_nonlocal_name_disallow_rename_2():
     source = '''
 class LazyList:
     MyAttribute = MyNonLocal

test/test_folding.py

@@ -26,7 +26,7 @@ def run_test(source, expected):
 
 
 @pytest.mark.parametrize(
-    'source,expected', [
+    ('source', 'expected'), [
         ('True | True', 'True'),
         ('True | False', 'True'),
         ('False | True', 'True'),
@@ -87,7 +87,7 @@ def test_bool(source, expected):
 
 
 @pytest.mark.parametrize(
-    'source,expected', [
+    ('source', 'expected'), [
         ('10 + 10', '20'),
         ('10 + 0', '10'),
         ('0 + 10', '10'),
@@ -116,7 +116,7 @@ def test_int(source, expected):
 
 
 @pytest.mark.parametrize(
-    'source,expected', [
+    ('source', 'expected'), [
         ('10/10', '10/10'),
         ('5+5/10', '5+5/10'),
         ('2*5/10', '10/10'),
@@ -134,7 +134,7 @@ def test_int_not_eval(source, expected):
 
 
 @pytest.mark.parametrize(
-    'source,expected', [
+    ('source', 'expected'), [
         ('"Hello" + "World"', '"Hello" + "World"'),
         ('"Hello" * 5', '"Hello" * 5'),
         ('b"Hello" + b"World"', 'b"Hello" + b"World"'),

test/test_fstring.py

@@ -12,7 +12,6 @@
         'f"{1=!r:.4}"',
         'f"{1=:.4}"',
         'f"{1=!s:.4}"',
-        'f"{1=:.4}"',
         'f"{1}"',
         'f"{1=}"',
         'f"{1=!s}"',

test/test_hoist_literals.py

@@ -22,8 +22,8 @@ def hoist(source):
     add_namespace(module)
     bind_names(module)
     resolve_names(module)
-    allow_rename_locals(module, False)
-    allow_rename_globals(module, False)
+    allow_rename_locals(module, rename_locals=False)
+    allow_rename_globals(module, rename_globals=False)
     rename_literals(module)
     rename(module)
     print(unparse(module))

test/test_match_rename.py

@@ -16,15 +16,15 @@
 )
 
 
-def do_rename(source, locals, globals):
+def do_rename(source, allow_locals, allow_globals):
     # This will raise if the source file can't be parsed
     module = ast.parse(source, 'test_match_rename')
     add_namespace(module)
     bind_names(module)
     resolve_names(module)
 
-    allow_rename_locals(module, locals)
-    allow_rename_globals(module, globals)
+    allow_rename_locals(module, allow_locals)
+    allow_rename_globals(module, allow_globals)
 
     rename_literals(module)
     rename(module)
@@ -70,7 +70,7 @@ def C():
 '''
 
     expected_ast = ast.parse(expected)
-    actual_ast = do_rename(source, locals=False, globals=True)
+    actual_ast = do_rename(source, allow_locals=False, allow_globals=True)
     assert_code(expected_ast, actual_ast)
 
 
@@ -109,7 +109,7 @@ def func(expensive_rename):
 '''
 
     expected_ast = ast.parse(expected)
-    actual_ast = do_rename(source, locals=True, globals=False)
+    actual_ast = do_rename(source, allow_locals=True, allow_globals=False)
     assert_code(expected_ast, actual_ast)
 
 
@@ -142,7 +142,7 @@ def func(expensive_rename):
     '''
 
     expected_ast = ast.parse(expected)
-    actual_ast = do_rename(source, locals=True, globals=False)
+    actual_ast = do_rename(source, allow_locals=True, allow_globals=False)
     assert_code(expected_ast, actual_ast)
 
 
@@ -180,7 +180,7 @@ def C(expensive_rename):
         '''
 
     expected_ast = ast.parse(expected)
-    actual_ast = do_rename(source, locals=False, globals=True)
+    actual_ast = do_rename(source, allow_locals=False, allow_globals=True)
     assert_code(expected_ast, actual_ast)
 
 
@@ -213,7 +213,7 @@ def func(expensive_rename):
         '''
 
     expected_ast = ast.parse(expected)
-    actual_ast = do_rename(source, locals=True, globals=False)
+    actual_ast = do_rename(source, allow_locals=True, allow_globals=False)
     assert_code(expected_ast, actual_ast)
 
 
@@ -246,7 +246,7 @@ def B(expensive_rename):
         '''
 
     expected_ast = ast.parse(expected)
-    actual_ast = do_rename(source, locals=False, globals=True)
+    actual_ast = do_rename(source, allow_locals=False, allow_globals=True)
     assert_code(expected_ast, actual_ast)
 
 
@@ -303,7 +303,7 @@ class A: pass
             '''
 
     expected_ast = ast.parse(expected)
-    actual_ast = do_rename(source, locals=True, globals=False)
+    actual_ast = do_rename(source, allow_locals=True, allow_globals=False)
     assert_code(expected_ast, actual_ast)
 
 
@@ -358,5 +358,5 @@ class Local: pass
                 '''
 
     expected_ast = ast.parse(expected)
-    actual_ast = do_rename(source, locals=False, globals=True)
+    actual_ast = do_rename(source, allow_locals=False, allow_globals=True)
     assert_code(expected_ast, actual_ast)

test/test_nonlocal.py

@@ -88,13 +88,13 @@ def patch():
     # First check we understand the behavior
     unminified_locals = {}
     exec(test_code, {}, unminified_locals)
-    assert unminified_locals['result'] == True
+    assert unminified_locals['result'] is True
 
     minified = python_minifier.minify(test_code, rename_locals=True)
     print(minified)
     minified_locals = {}
     exec(minified, {}, minified_locals)
-    assert minified_locals['result'] == True
+    assert minified_locals['result'] is True
 
 
 def test_nonlocal_import_alias():
@@ -118,10 +118,10 @@ def patch():
     # First check we understand the behavior
     unminified_locals = {}
     exec(test_code, {}, unminified_locals)
-    assert unminified_locals['result'] == True
+    assert unminified_locals['result'] is True
 
     minified = python_minifier.minify(test_code, rename_locals=True)
     print(minified)
     minified_locals = {}
     exec(minified, {}, minified_locals)
-    assert minified_locals['result'] == True
+    assert minified_locals['result'] is True

test/test_rename_builtins.py

@@ -18,8 +18,8 @@ def do_rename(source):
     bind_names(module)
     resolve_names(module)
 
-    allow_rename_locals(module, True)
-    allow_rename_globals(module, True)
+    allow_rename_locals(module, rename_locals=True)
+    allow_rename_globals(module, rename_globals=True)
 
     rename(module)
 

test/test_rename_locals.py

@@ -22,8 +22,8 @@ def rename_locals(source):
     bind_names(module)
     resolve_names(module)
 
-    allow_rename_locals(module, True)
-    allow_rename_globals(module, False)
+    allow_rename_locals(module, rename_locals=True)
+    allow_rename_globals(module, rename_globals=False)
 
     rename(module)