Skip to content

Commit 5ab63cb

Browse files
committed
Rework parseLED function to use switch case
1 parent a0a8945 commit 5ab63cb

1 file changed

Lines changed: 17 additions & 12 deletions

File tree

src/XInput.cpp

Lines changed: 17 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -344,23 +344,28 @@ void XInputGamepad::parseLED(uint8_t leds) {
344344
if (leds > 0x0D) return; // Not a known pattern
345345

346346
ledPattern = (XInputLEDPattern) leds; // Save pattern
347-
if (ledPattern == XInputLEDPattern::Off || ledPattern == XInputLEDPattern::Blinking) {
347+
switch (ledPattern) {
348+
case(XInputLEDPattern::Off):
349+
case(XInputLEDPattern::Blinking):
348350
player = 0; // Not connected
349-
}
350-
else if (ledPattern == XInputLEDPattern::On1 || ledPattern == XInputLEDPattern::Flash1) {
351+
break;
352+
case(XInputLEDPattern::On1):
353+
case(XInputLEDPattern::Flash1):
351354
player = 1;
352-
}
353-
else if (ledPattern == XInputLEDPattern::On2 || ledPattern == XInputLEDPattern::Flash2) {
355+
break;
356+
case(XInputLEDPattern::On2):
357+
case(XInputLEDPattern::Flash2):
354358
player = 2;
355-
}
356-
else if (ledPattern == XInputLEDPattern::On3 || ledPattern == XInputLEDPattern::Flash3) {
359+
break;
360+
case(XInputLEDPattern::On3):
361+
case(XInputLEDPattern::Flash3):
357362
player = 3;
358-
}
359-
else if (ledPattern == XInputLEDPattern::On4 || ledPattern == XInputLEDPattern::Flash4) {
363+
break;
364+
case(XInputLEDPattern::On4):
365+
case(XInputLEDPattern::Flash4):
360366
player = 4;
361-
}
362-
else {
363-
return; // Pattern doesn't affect player #
367+
break;
368+
default: return; // Pattern doesn't affect player #
364369
}
365370
}
366371

0 commit comments

Comments
 (0)