Skip to content

Commit 77b8a42

Browse files
committed
Remove getLEDPatternID function
This is a redundant wrapper around the existing function, just with the type cast already done. Better to simplify and let the user take care of casting if need-be.
1 parent c1e05b7 commit 77b8a42

3 files changed

Lines changed: 5 additions & 10 deletions

File tree

keywords.txt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,7 @@ getPlayer KEYWORD2
4444
getRumble KEYWORD2
4545
getRumbleLeft KEYWORD2
4646
getRumbleRight KEYWORD2
47-
48-
getLEDPatternID KEYWORD2
47+
getLEDPattern KEYWORD2
4948

5049
setReceiveCallback KEYWORD2
5150

src/XInput.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -313,10 +313,6 @@ XInputLEDPattern XInputGamepad::getLEDPattern() const {
313313
return ledPattern;
314314
}
315315

316-
uint8_t XInputGamepad::getLEDPatternID() const {
317-
return (uint8_t)ledPattern;
318-
}
319-
320316
void XInputGamepad::setReceiveCallback(RecvCallbackType cback) {
321317
recvCallback = cback;
322318
}

src/XInput.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -101,11 +101,11 @@ class XInputGamepad {
101101

102102
// Received Data
103103
uint8_t getPlayer() const; // Player # assigned to the controller (0 is unassigned)
104+
104105
uint16_t getRumble() const; // Rumble motors. MSB is large weight, LSB is small
105-
uint8_t getRumbleLeft() const; // Large rumble motor, left grip
106-
uint8_t getRumbleRight() const; // Small rumble motor, right grip
107-
108-
uint8_t getLEDPatternID() const; // Returns LED pattern ID #
106+
uint8_t getRumbleLeft() const; // Large rumble motor, left grip
107+
uint8_t getRumbleRight() const; // Small rumble motor, right grip
108+
109109
XInputLEDPattern getLEDPattern() const; // Returns LED pattern type
110110

111111
// Received Data Callback

0 commit comments

Comments
 (0)