From 1c4ec1999eed460900a08e72e558601daef03a74 Mon Sep 17 00:00:00 2001 From: Guillermo Gutierrez Almazor Date: Fri, 17 Apr 2026 16:24:37 +0200 Subject: [PATCH 1/2] chore: sync listCharges fixture with certificate-purchase entry --- tests/fixtures/v2/api/listCharges/success.http | 2 +- tests/service/billing_test.py | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/fixtures/v2/api/listCharges/success.http b/tests/fixtures/v2/api/listCharges/success.http index 70e5d038..851d232e 100644 --- a/tests/fixtures/v2/api/listCharges/success.http +++ b/tests/fixtures/v2/api/listCharges/success.http @@ -9,4 +9,4 @@ cache-control: no-store, must-revalidate, private, max-age=0 x-request-id: a57a87c8-626a-4361-9fb8-b55ca9be8e5d x-runtime: 0.060526 -{"data":[{"invoiced_at":"2023-08-17T05:53:36Z","total_amount":"14.50","balance_amount":"0.00","reference":"1-2","state":"collected","items":[{"description":"Register bubble-registered.com","amount":"14.50","product_id":1,"product_type":"domain-registration","product_reference":"bubble-registered.com"}]},{"invoiced_at":"2023-08-17T05:57:53Z","total_amount":"14.50","balance_amount":"0.00","reference":"2-2","state":"refunded","items":[{"description":"Register example.com","amount":"14.50","product_id":2,"product_type":"domain-registration","product_reference":"example.com"}]},{"invoiced_at":"2023-10-24T07:49:05Z","total_amount":"1099999.99","balance_amount":"0.00","reference":"4-2","state":"collected","items":[{"description":"Test Line Item 1","amount":"99999.99","product_id":null,"product_type":"manual","product_reference":null},{"description":"Test Line Item 2","amount":"1000000.00","product_id":null,"product_type":"manual","product_reference":null}]}],"pagination":{"current_page":1,"per_page":30,"total_entries":3,"total_pages":1}} +{"data":[{"invoiced_at":"2023-08-17T05:53:36Z","total_amount":"14.50","balance_amount":"0.00","reference":"1-2","state":"collected","items":[{"description":"Register bubble-registered.com","amount":"14.50","product_id":1,"product_type":"domain-registration","product_reference":"bubble-registered.com"}]},{"invoiced_at":"2023-08-17T05:57:53Z","total_amount":"14.50","balance_amount":"0.00","reference":"2-2","state":"refunded","items":[{"description":"Register example.com","amount":"14.50","product_id":2,"product_type":"domain-registration","product_reference":"example.com"}]},{"invoiced_at":"2023-10-24T07:49:05Z","total_amount":"1099999.99","balance_amount":"0.00","reference":"4-2","state":"collected","items":[{"description":"Test Line Item 1","amount":"99999.99","product_id":null,"product_type":"manual","product_reference":null},{"description":"Test Line Item 2","amount":"1000000.00","product_id":null,"product_type":"manual","product_reference":null}]},{"invoiced_at":"2023-10-24T09:00:00Z","total_amount":"20.00","balance_amount":"0.00","reference":"5-2","state":"collected","items":[{"description":"Purchase Certificate www.bubble-registered.com","amount":"20.00","product_id":42,"product_type":"certificate-purchase","product_reference":"42"}]}],"pagination":{"current_page":1,"per_page":30,"total_entries":4,"total_pages":1}} diff --git a/tests/service/billing_test.py b/tests/service/billing_test.py index ef56dc35..f2ce3460 100644 --- a/tests/service/billing_test.py +++ b/tests/service/billing_test.py @@ -19,6 +19,7 @@ def test_list_charges_success(self): Charge({"invoiced_at": "2023-08-17T05:53:36Z","total_amount": "14.50","balance_amount": "0.00","reference": "1-2","state": "collected","items":[{"description": "Register bubble-registered.com","amount": "14.50","product_id": 1,"product_type": "domain-registration","product_reference": "bubble-registered.com"}]}), Charge({"invoiced_at": "2023-08-17T05:57:53Z","total_amount": "14.50","balance_amount": "0.00","reference": "2-2","state": "refunded","items":[{"description": "Register example.com","amount": "14.50","product_id": 2,"product_type": "domain-registration","product_reference": "example.com"}]}), Charge({"invoiced_at": "2023-10-24T07:49:05Z","total_amount": "1099999.99","balance_amount": "0.00","reference": "4-2","state": "collected","items":[{"description": "Test Line Item 1","amount": "99999.99","product_id": None,"product_type": "manual","product_reference":None},{"description": "Test Line Item 2","amount": "1000000.00","product_id": None,"product_type": "manual","product_reference":None}]}), + Charge({"invoiced_at": "2023-10-24T09:00:00Z","total_amount": "20.00","balance_amount": "0.00","reference": "5-2","state": "collected","items":[{"description": "Purchase Certificate www.bubble-registered.com","amount": "20.00","product_id": 42,"product_type": "certificate-purchase","product_reference": "42"}]}), ]) @responses.activate From 902d74f873e044c7eff7d83d271b1499ceaecce7 Mon Sep 17 00:00:00 2001 From: Guillermo Gutierrez Almazor Date: Sat, 18 Apr 2026 09:30:31 +0200 Subject: [PATCH 2/2] chore: add CHANGELOG entry for listCharges fixture sync --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index f11aa915..65bd7918 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,10 @@ This project uses [Semantic Versioning 2.0.0](http://semver.org/), the format is ## main +### Changed + +- Updated the `listCharges` test fixture to include a certificate purchase entry demonstrating that `product_reference` is a string even when it represents a numeric ID. (#502) + ### Removed - **BREAKING**: Removed the deprecated `contact_id` field from the `Certificate` struct and from `LetsencryptCertificateInput`. The field was deprecated on 2022-05-17 and is no longer required for certificate operations.