Skip to content

Commit 4e25e5c

Browse files
authored
Merge pull request #6941 from vvoland/milestone-validate
gha: Add milestone validation workflow
2 parents f31b8b2 + efbbc0c commit 4e25e5c

3 files changed

Lines changed: 37 additions & 2 deletions

File tree

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
1+
name: validate-milestone
2+
3+
permissions:
4+
contents: read
5+
6+
on:
7+
pull_request:
8+
types: [opened, synchronize, milestoned, demilestoned, edited]
9+
10+
jobs:
11+
validate-milestone:
12+
runs-on: ubuntu-24.04
13+
timeout-minutes: 5
14+
steps:
15+
- name: Checkout
16+
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
17+
with:
18+
sparse-checkout: VERSION
19+
20+
- name: Validate milestone matches VERSION
21+
run: |
22+
expected=$(cat VERSION)
23+
milestone="${{ github.event.pull_request.milestone.title }}"
24+
25+
if [[ -z "$milestone" ]]; then
26+
echo "::error::PR must have a milestone set (expected: $expected)"
27+
exit 1
28+
fi
29+
30+
if [[ "$milestone" != "$expected" ]]; then
31+
echo "::error::Milestone '$milestone' does not match VERSION '$expected'"
32+
exit 1
33+
fi
34+
35+
echo "Milestone: $milestone ✓"

VERSION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
29.4.0-dev
1+
29.4.1

docker.Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ CACHE_VOLUME_NAME := docker-cli-dev-cache
1919
ifeq ($(DOCKER_CLI_GO_BUILD_CACHE),y)
2020
DOCKER_CLI_MOUNTS += -v "$(CACHE_VOLUME_NAME):/root/.cache/go-build"
2121
endif
22-
VERSION = $(shell cat VERSION)
22+
VERSION ?= $(shell cat VERSION)-dev
2323
ENVVARS = -e VERSION=$(VERSION) -e GITCOMMIT -e PLATFORM -e TESTFLAGS -e TESTDIRS -e GOOS -e GOARCH -e GOARM -e ENGINE_VERSION
2424

2525
# Some Dockerfiles use features that are only supported with BuildKit enabled

0 commit comments

Comments
 (0)