Skip to content

Commit 6e93279

Browse files
committed
Fix regression when mounting volumes
Caused by docker/docker-py@77fec67
1 parent 9e1dfcf commit 6e93279

2 files changed

Lines changed: 10 additions & 1 deletion

File tree

fig/service.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,10 @@ def start_container(self, container=None, volumes_from=None, **override_options)
222222
for volume in options['volumes']:
223223
if ':' in volume:
224224
external_dir, internal_dir = volume.split(':')
225-
volume_bindings[os.path.abspath(external_dir)] = internal_dir
225+
volume_bindings[os.path.abspath(external_dir)] = {
226+
'bind': internal_dir,
227+
'ro': False,
228+
}
226229

227230
privileged = options.get('privileged', False)
228231

tests/service_test.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,12 @@ def test_create_container_with_unspecified_volume(self):
114114
service.start_container(container)
115115
self.assertIn('/var/db', container.inspect()['Volumes'])
116116

117+
def test_create_container_with_specified_volume(self):
118+
service = self.create_service('db', volumes=['/tmp:/host-tmp'])
119+
container = service.create_container()
120+
service.start_container(container)
121+
self.assertIn('/host-tmp', container.inspect()['Volumes'])
122+
117123
def test_recreate_containers(self):
118124
service = self.create_service(
119125
'db',

0 commit comments

Comments
 (0)