Merge pull request #2466 from dgageot/dont-retry

Don't retry SQLITE_CANTOPEN (14) errors

Author: dgageot

pkg/session/store.go

@@ -374,6 +374,15 @@ func NewSQLiteSessionStore(path string) (Store, error) {
 			return nil, err
 		}
 
+		// Don't attempt recovery if we couldn't even open/create the database file
+		// (e.g., permission denied, read-only filesystem, missing directory).
+		// The backup+retry dance can't fix a filesystem-level problem, and would just
+		// wrap the real error in a confusing "migration failed even after database reset"
+		// message.
+		if sqliteutil.IsCantOpenError(err) {
+			return nil, err
+		}
+
 		// If migrations failed, try to recover by backing up the database and starting fresh
 		slog.Warn("Failed to open session store, attempting recovery", "error", err)
 

pkg/session/store_test.go

@@ -358,6 +358,12 @@ func TestNewSQLiteSessionStore_DirectoryNotWritable(t *testing.T) {
 
 	assert.Contains(t, err.Error(), "cannot create database")
 	assert.Contains(t, err.Error(), "permission denied or file cannot be created")
+
+	// We should surface the real "cannot create database" error directly instead of
+	// running the backup+retry recovery path (which cannot fix a filesystem-level
+	// problem and would only wrap the real error in a confusing "migration failed"
+	// message).
+	assert.NotContains(t, err.Error(), "migration failed")
 }
 
 func TestUpdateSession_LazyCreation(t *testing.T) {