Skip to content

Commit 3691c8c

Browse files
committed
fixed test
1 parent fffdd17 commit 3691c8c

2 files changed

Lines changed: 10 additions & 7 deletions

File tree

src/Admin/src/Controller/AdminController.php

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737
use Psr\Http\Message\ResponseInterface;
3838
use Throwable;
3939

40+
use function json_decode;
4041
use function password_verify;
4142

4243
class AdminController extends AbstractActionController
@@ -80,13 +81,13 @@ public function addAction(): ResponseInterface
8081
} catch (ORMException $e) {
8182
$this->logErrors($e, Message::CREATE_ADMIN);
8283
return new JsonResponse(
83-
['message' => $e->getMessage()],
84+
['message' => $e->getMessage()],
8485
StatusCodeInterface::STATUS_INTERNAL_SERVER_ERROR
8586
);
8687
} catch (Throwable $e) {
8788
$this->logErrors($e, Message::CREATE_ADMIN);
8889
return new JsonResponse(
89-
['message' => Message::AN_ERROR_OCCURRED],
90+
['message' => Message::AN_ERROR_OCCURRED],
9091
StatusCodeInterface::STATUS_INTERNAL_SERVER_ERROR
9192
);
9293
}
@@ -133,7 +134,7 @@ public function editAction(): ResponseInterface
133134
} catch (ORMException $e) {
134135
$this->logErrors($e, Message::UPDATE_ADMIN);
135136
return new JsonResponse(
136-
['message' => $e->getMessage()],
137+
['message' => $e->getMessage()],
137138
StatusCodeInterface::STATUS_INTERNAL_SERVER_ERROR
138139
);
139140
} catch (Throwable $e) {
@@ -387,7 +388,8 @@ public function listLoginsAction(): ResponseInterface
387388
return new JsonResponse($result);
388389
}
389390

390-
public function logErrors(Throwable|Exception $e, string $message) {
391+
public function logErrors(Throwable|Exception $e, string $message)
392+
{
391393
$this->logger->err($message, [
392394
'error' => $e->getMessage(),
393395
'file' => $e->getFile(),

test/Unit/Admin/InputFilter/EditAdminInputFilterTest.php

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ public function testWillValidateIdentity(): void
1919
$inputFilter->init();
2020

2121
$inputFilter->setData([
22+
'identity' => 'testIdentity',
2223
'password' => 'password',
2324
'passwordConfirm' => 'password',
2425
'firstName' => 'firstName',
@@ -41,7 +42,7 @@ public function testWillValidateIdentity(): void
4142
AdminRole::ROLE_ADMIN,
4243
],
4344
]);
44-
$this->assertTrue($inputFilter->isValid());
45+
$this->assertFalse($inputFilter->isValid());
4546

4647
$inputFilter->setData([
4748
'identity' => '',
@@ -54,7 +55,7 @@ public function testWillValidateIdentity(): void
5455
AdminRole::ROLE_ADMIN,
5556
],
5657
]);
57-
$this->assertTrue($inputFilter->isValid());
58+
$this->assertFalse($inputFilter->isValid());
5859

5960
$inputFilter->setData([
6061
'identity' => ' ',
@@ -67,7 +68,7 @@ public function testWillValidateIdentity(): void
6768
AdminRole::ROLE_ADMIN,
6869
],
6970
]);
70-
$this->assertTrue($inputFilter->isValid());
71+
$this->assertFalse($inputFilter->isValid());
7172

7273
$inputFilter->setData([
7374
'identity' => 'id',

0 commit comments

Comments
 (0)