fixed updating login logs

Signed-off-by: Claudiu Pintiuta <claudiupintiuta@gmail.com>

Author: pinclau

src/Admin/src/Controller/AdminController.php

@@ -244,11 +244,13 @@ public function loginAction(): ResponseInterface
                 $adapter->setIdentity($data['username']);
                 $adapter->setCredential($data['password']);
                 $authResult = $this->authenticationService->authenticate();
-                $logAdmin   = $this->adminService->logAdminVisit($this->getServerParams(), $data['username']);
                 if ($authResult->isValid()) {
                     $identity = $authResult->getIdentity();
-                    $logAdmin->setLoginStatus(AdminLogin::LOGIN_SUCCESS);
-                    $this->adminService->getAdminRepository()->saveAdminVisit($logAdmin);
+                    $this->adminService->logAdminVisit(
+                        $this->getServerParams(),
+                        $data['username'],
+                        AdminLogin::LOGIN_SUCCESS
+                    );
                     if ($identity->getStatus() === Admin::STATUS_INACTIVE) {
                         $this->authenticationService->clearIdentity();
                         $this->messenger->addError('Admin is inactive', 'user-login');
@@ -260,8 +262,11 @@ public function loginAction(): ResponseInterface
 
                     return new RedirectResponse($this->router->generateUri('dashboard'));
                 } else {
-                    $logAdmin->setLoginStatus(AdminLogin::LOGIN_FAIL);
-                    $this->adminService->getAdminRepository()->saveAdminVisit($logAdmin);
+                    $this->adminService->logAdminVisit(
+                        $this->getServerParams(),
+                        $data['username'],
+                        AdminLogin::LOGIN_FAIL
+                    );
                     $this->messenger->addData('shouldRebind', true);
                     $this->forms->saveState($form);
                     $this->messenger->addError($authResult->getMessages(), 'user-login');

src/Admin/src/Service/AdminService.php

@@ -193,7 +193,7 @@ public function updateAdmin(Admin $admin, array $data): Admin
         return $admin;
     }
 
-    public function logAdminVisit(array $serverParams, string $name): AdminLogin
+    public function logAdminVisit(array $serverParams, string $name, string $status): AdminLogin
     {
         /**
          * For device information
@@ -228,6 +228,7 @@ public function logAdminVisit(array $serverParams, string $name): AdminLogin
             ->setClientName(null)
             ->setClientEngine(null)
             ->setClientVersion(null)
+            ->setLoginStatus($status)
             ->setIdentity($name);
 
         return $this->adminRepository->saveAdminVisit($adminLogin);

src/Admin/src/Service/AdminServiceInterface.php

@@ -50,7 +50,7 @@ public function createAdmin(array $data): Admin;
      */
     public function updateAdmin(Admin $admin, array $data): Admin;
 
-    public function logAdminVisit(array $serverParams, string $name): AdminLogin;
+    public function logAdminVisit(array $serverParams, string $name, string $status): AdminLogin;
 
     public function getAdminFormProcessedRoles(): array;
 }