Merge pull request #42 from dotnet/cleanconsole

Clean Console messages.

Author: Priya91

src/CodeFormatter/Program.cs

@@ -19,7 +19,7 @@ private static int Main(string[] args)
         {
             if (args.Length < 1)
             {
-                Console.WriteLine("CodeFormatter <project or solution> [<rule types>] [/file <filename>]");
+                Console.WriteLine("CodeFormatter <project or solution> [<rule types>] [/file <filename>] [/nocopyright]");
                 Console.WriteLine("    <rule types> - Rule types to use in addition to the default ones.");
                 Console.WriteLine("                   Use ConvertTests to convert MSTest tests to xUnit.");
                 Console.WriteLine("    <filename> - Only apply changes to files with specified name.");
@@ -74,7 +74,6 @@ private static async Task RunAsync(string projectOrSolutionPath, IEnumerable<str
         {
             var workspace = MSBuildWorkspace.Create();
             var engine = FormattingEngine.Create(ruleTypes, filenames);
-            engine.Verbose = true;
             if (disableCopright)
             {
                 engine.CopyrightHeader = ImmutableArray<string>.Empty;

src/Microsoft.DotNet.CodeFormatting/FormattingEngineImplementation.cs

@@ -26,7 +26,6 @@ internal sealed class FormattingEngineImplementation : IFormattingEngine
         private readonly IEnumerable<ILocalSemanticFormattingRule> _localSemanticRules;
         private readonly IEnumerable<IGlobalSemanticFormattingRule> _globalSemanticRules;
         private readonly Stopwatch _watch = new Stopwatch();
-        private bool _verbose;
 
         public ImmutableArray<string> CopyrightHeader
         {
@@ -40,12 +39,6 @@ public IFormatLogger FormatLogger
             set { _options.FormatLogger = value; }
         }
 
-        public bool Verbose
-        {
-            get { return _verbose; }
-            set { _verbose = value; }
-        }
-
         [ImportingConstructor]
         internal FormattingEngineImplementation(
             Options options,
@@ -161,15 +154,7 @@ private void StartDocument()
         private void EndDocument(Document document)
         {
             _watch.Stop();
-            if (_verbose && _watch.Elapsed.TotalSeconds > 1)
-            {
-                FormatLogger.WriteLine();
-                FormatLogger.WriteLine("    {0} {1} seconds", document.Name, _watch.Elapsed.TotalSeconds);
-            }
-            else
-            {
-                FormatLogger.Write(".");
-            }
+            FormatLogger.WriteLine("    {0} {1} seconds", document.Name, _watch.Elapsed.TotalSeconds);
         }
 
         /// <summary>
@@ -202,7 +187,6 @@ private async Task<Solution> RunSyntaxPass(Solution originalSolution, IReadOnlyL
                 }
             }
 
-            FormatLogger.WriteLine();
             return currentSolution;
         }
 
@@ -224,7 +208,6 @@ private async Task<Solution> RunLocalSemanticPass(Solution solution, IReadOnlyLi
                 solution = await RunLocalSemanticPass(solution, documentIds, localSemanticRule, cancellationToken);
             }
 
-            FormatLogger.WriteLine();
             return solution;
         }
 
@@ -251,7 +234,6 @@ private async Task<Solution> RunLocalSemanticPass(Solution originalSolution, IRe
                 }
             }
 
-            FormatLogger.WriteLine();
             return currentSolution;
         }
 
@@ -263,7 +245,6 @@ private async Task<Solution> RunGlobalSemanticPass(Solution solution, IReadOnlyL
                 solution = await RunGlobalSemanticPass(solution, documentIds, globalSemanticRule, cancellationToken);
             }
 
-            FormatLogger.WriteLine();
             return solution;
         }
 
@@ -284,7 +265,6 @@ private async Task<Solution> RunGlobalSemanticPass(Solution solution, IReadOnlyL
                 EndDocument(document);
             }
 
-            FormatLogger.WriteLine();
             return solution;
         }
     }

src/Microsoft.DotNet.CodeFormatting/IFormatLogger.cs

@@ -31,8 +31,10 @@ public void WriteLine(string format, params object[] args)
 
         public void WriteErrorLine(string format, params object[] args)
         {
+            Console.ForegroundColor = ConsoleColor.Red;
             Console.Write("Error: ");
             Console.WriteLine(format, args);
+            Console.ResetColor();
         }
 
         public void WriteLine()

src/Microsoft.DotNet.CodeFormatting/IFormattingEngine.cs

@@ -13,7 +13,6 @@ namespace Microsoft.DotNet.CodeFormatting
     public interface IFormattingEngine
     {
         ImmutableArray<string> CopyrightHeader { get; set; }
-        bool Verbose { get; set; }
         Task FormatSolutionAsync(Solution solution, CancellationToken cancellationToken);
         Task FormatProjectAsync(Project porject, CancellationToken cancellationToken);
     }