Add C# interop tests for obsolete field/event/method/property filtering

Fix issue number to #13512. Add ObsoleteMembersClass to CSharp_Analysis
with obsolete and non-obsolete members. Add 6 C# interop completion tests
verifying all obsolete member types are consistently hidden.

Agent-Logs-Url: https://github.com/dotnet/fsharp/sessions/1d21d452-3f55-4d56-898c-0b50980050b5

Co-authored-by: abonie <20281641+abonie@users.noreply.github.com>

Author: 2 people

docs/release-notes/.FSharp.Compiler.Service/11.0.100.md

@@ -17,7 +17,7 @@
 * Fix `YieldFromFinal`/`ReturnFromFinal` being incorrectly called in non-tail positions (`for`, `use`, `use!`, `try/with` handler). ([Issue #19402](https://github.com/dotnet/fsharp/issues/19402), [PR #19403](https://github.com/dotnet/fsharp/pull/19403))
 * Fixed how the source ranges of warn directives are reported (as trivia) in the parser output (by not reporting leading spaces). ([Issue #19405](https://github.com/dotnet/fsharp/issues/19405), [PR #19408]((https://github.com/dotnet/fsharp/pull/19408)))
 * Fix UoM value type `ToString()` returning garbage values when `--checknulls+` is enabled, caused by double address-taking in codegen. ([Issue #19435](https://github.com/dotnet/fsharp/issues/19435), [PR #19440](https://github.com/dotnet/fsharp/pull/19440))
-* Fix completion inconsistently showing some obsolete members (fields and events) while hiding others (methods and properties). All obsolete members are now consistently hidden by default. ([Issue #13693](https://github.com/dotnet/fsharp/issues/13693), [PR #19506](https://github.com/dotnet/fsharp/pull/19506))
+* Fix completion inconsistently showing some obsolete members (fields and events) while hiding others (methods and properties). All obsolete members are now consistently hidden by default. ([Issue #13512](https://github.com/dotnet/fsharp/issues/13512), [PR #19506](https://github.com/dotnet/fsharp/pull/19506))
 
 ### Added
 

tests/FSharp.Compiler.Service.Tests/Checker.fs

@@ -162,6 +162,11 @@ module Checker =
         let parseResults, checkResults = getParseAndCheckResults context.Source
         checkResults.GetCodeCompletionSuggestions(context, parseResults, options)
 
+    let getCompletionInfoWithCompilerAndCompletionOptions (compilerOptions: string array) (completionOptions: FSharpCodeCompletionOptions) (markedSource: string) =
+        let context = getCompletionContext markedSource
+        let parseResults, checkResults = getParseAndCheckResultsWithOptions compilerOptions context.Source
+        checkResults.GetCodeCompletionSuggestions(context, parseResults, completionOptions)
+
     let getCompletionInfo markedSource =
         getCompletionInfoWithOptions FSharpCodeCompletionOptions.Default markedSource
 

tests/FSharp.Compiler.Service.Tests/CompletionTests.fs

@@ -691,7 +691,7 @@ exception E
 try () with E{caret}
 """
 
-        // https://github.com/dotnet/fsharp/issues/13693
+        // https://github.com/dotnet/fsharp/issues/13512
         [<Fact>]
         let ``Event - Instance 01`` () =
             assertItem "Ev" """
@@ -702,7 +702,7 @@ type T() =
 T().{caret}
 """
 
-        // https://github.com/dotnet/fsharp/issues/13693
+        // https://github.com/dotnet/fsharp/issues/13512
         [<Fact>]
         let ``Event - Static 01`` () =
             assertItem "Ev" """
@@ -713,6 +713,64 @@ type T() =
 T.{caret}
 """
 
+        /// Helper to assert completion with a reference to the CSharp_Analysis assembly
+        let private assertCSharpInteropItem name source =
+            let csharpAssembly = PathRelativeToTestAssembly "CSharp_Analysis.dll"
+            let compilerOptions = [| $"-r:{csharpAssembly}" |]
+            [allowObsoleteOptions; disallowObsoleteOptions]
+            |> List.iter (fun completionOptions ->
+                let contains = completionOptions.SuggestObsoleteSymbols
+                let info = Checker.getCompletionInfoWithCompilerAndCompletionOptions compilerOptions completionOptions source
+                assertItemsWithNames contains [name] info
+            )
+
+        // https://github.com/dotnet/fsharp/issues/13512
+        [<Fact>]
+        let ``CSharp - Obsolete field is hidden`` () =
+            assertCSharpInteropItem "ObsoleteField" """
+open FSharp.Compiler.Service.Tests
+ObsoleteMembersClass.{caret}
+"""
+
+        // https://github.com/dotnet/fsharp/issues/13512
+        [<Fact>]
+        let ``CSharp - Obsolete method is hidden`` () =
+            assertCSharpInteropItem "ObsoleteMethod" """
+open FSharp.Compiler.Service.Tests
+ObsoleteMembersClass.{caret}
+"""
+
+        // https://github.com/dotnet/fsharp/issues/13512
+        [<Fact>]
+        let ``CSharp - Obsolete property is hidden`` () =
+            assertCSharpInteropItem "ObsoleteProperty" """
+open FSharp.Compiler.Service.Tests
+ObsoleteMembersClass.{caret}
+"""
+
+        // https://github.com/dotnet/fsharp/issues/13512
+        [<Fact>]
+        let ``CSharp - Obsolete event is hidden`` () =
+            assertCSharpInteropItem "ObsoleteEvent" """
+open FSharp.Compiler.Service.Tests
+ObsoleteMembersClass.{caret}
+"""
+
+        // https://github.com/dotnet/fsharp/issues/13512
+        [<Fact>]
+        let ``CSharp - Non-obsolete members are always shown`` () =
+            let csharpAssembly = PathRelativeToTestAssembly "CSharp_Analysis.dll"
+            let compilerOptions = [| $"-r:{csharpAssembly}" |]
+            let source = """
+open FSharp.Compiler.Service.Tests
+ObsoleteMembersClass.{caret}
+"""
+            [allowObsoleteOptions; disallowObsoleteOptions]
+            |> List.iter (fun completionOptions ->
+                let info = Checker.getCompletionInfoWithCompilerAndCompletionOptions compilerOptions completionOptions source
+                assertItemsWithNames true ["NonObsoleteField"; "NonObsoleteMethod"; "NonObsoleteProperty"; "NonObsoleteEvent"] info
+            )
+
 
     module PatternNameSuggestions =
         let private suggestPatternNames = { FSharpCodeCompletionOptions.Default with SuggestPatternNames = true }

tests/service/data/CSharp_Analysis/CSharpClass.cs

@@ -155,4 +155,25 @@ public class DummyClass
         {
         }
     }
+
+    /// <summary>
+    /// Class with obsolete members for testing completion filtering (issue #13512).
+    /// </summary>
+    public class ObsoleteMembersClass
+    {
+        [Obsolete("Field is obsolete")] public static readonly int ObsoleteField = 1;
+
+        [Obsolete("Method is obsolete")]
+        public static void ObsoleteMethod()
+        {
+        }
+
+        [Obsolete("Property is obsolete")] public static int ObsoleteProperty => 1;
+        [Obsolete("Event is obsolete")] public static event EventHandler ObsoleteEvent;
+
+        public static readonly int NonObsoleteField = 2;
+        public static void NonObsoleteMethod() { }
+        public static int NonObsoleteProperty => 2;
+        public static event EventHandler NonObsoleteEvent;
+    }
 }