From a6d81769e280d7e2fb8774b971d8d33e499bb7f4 Mon Sep 17 00:00:00 2001 From: David Wengier Date: Mon, 18 May 2026 07:55:34 +1000 Subject: [PATCH 1/4] Update Roslyn to 5.8.0-1.26267.2 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- CHANGELOG.md | 9 +++++++++ package.json | 2 +- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index fbdc35225..358468b9f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,15 @@ - Debug from .csproj and .sln [#5876](https://github.com/dotnet/vscode-csharp/issues/5876) # 2.143.x +* Update Roslyn to 5.8.0-1.26267.2 (PR: [#](https://github.com/dotnet/vscode-csharp/pull/)) + * Centralize commit character definitions and fix cross-deserialization equality (PR: [#83732](https://github.com/dotnet/roslyn/pull/83732)) + * Fix racecondition on UnsuedDirectiveCache.Set (PR: [#83693](https://github.com/dotnet/roslyn/pull/83693)) + * Fix progress reporting to report done on dispose (PR: [#83686](https://github.com/dotnet/roslyn/pull/83686)) + * Fix single line script tag formatting (PR: [#83721](https://github.com/dotnet/roslyn/pull/83721)) + * Implement type hierarchy LSP methods in Razor (PR: [#83637](https://github.com/dotnet/roslyn/pull/83637)) + * Razor support for Implement Interface (PR: [#83636](https://github.com/dotnet/roslyn/pull/83636)) + * Razor support for Implement Abstract Class (PR: [#83638](https://github.com/dotnet/roslyn/pull/83638)) + * feat(LSP): add IsOptionServiceAvailable opt-in for CodeActionWithOptions filtering (PR: [#83650](https://github.com/dotnet/roslyn/pull/83650)) # 2.142.x * Update Roslyn to 5.8.0-1.26262.9 (PR: [#9293](https://github.com/dotnet/vscode-csharp/pull/9293)) diff --git a/package.json b/package.json index 9b1afc893..283952ad5 100644 --- a/package.json +++ b/package.json @@ -40,7 +40,7 @@ "workspace" ], "defaults": { - "roslyn": "5.8.0-1.26262.10", + "roslyn": "5.8.0-1.26267.2", "omniSharp": "1.39.14", "razorOmnisharp": "7.0.0-preview.23363.1", "xamlTools": "18.7.11727.258" From 44b995aa2ea55b9fc073ae107d2efdbaf2ac996b Mon Sep 17 00:00:00 2001 From: David Wengier Date: Mon, 18 May 2026 07:56:12 +1000 Subject: [PATCH 2/4] Update changelog with PR number Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 358468b9f..44047574b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,7 +4,7 @@ - Debug from .csproj and .sln [#5876](https://github.com/dotnet/vscode-csharp/issues/5876) # 2.143.x -* Update Roslyn to 5.8.0-1.26267.2 (PR: [#](https://github.com/dotnet/vscode-csharp/pull/)) +* Update Roslyn to 5.8.0-1.26267.2 (PR: [#9321](https://github.com/dotnet/vscode-csharp/pull/9321)) * Centralize commit character definitions and fix cross-deserialization equality (PR: [#83732](https://github.com/dotnet/roslyn/pull/83732)) * Fix racecondition on UnsuedDirectiveCache.Set (PR: [#83693](https://github.com/dotnet/roslyn/pull/83693)) * Fix progress reporting to report done on dispose (PR: [#83686](https://github.com/dotnet/roslyn/pull/83686)) From a984a7fb1b5f4ef13602eb4cd0d8624c324c8241 Mon Sep 17 00:00:00 2001 From: David Wengier Date: Mon, 18 May 2026 07:57:54 +1000 Subject: [PATCH 3/4] Apply suggestion from @davidwengier --- CHANGELOG.md | 2 -- 1 file changed, 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 44047574b..80dcc0562 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,9 +5,7 @@ # 2.143.x * Update Roslyn to 5.8.0-1.26267.2 (PR: [#9321](https://github.com/dotnet/vscode-csharp/pull/9321)) - * Centralize commit character definitions and fix cross-deserialization equality (PR: [#83732](https://github.com/dotnet/roslyn/pull/83732)) * Fix racecondition on UnsuedDirectiveCache.Set (PR: [#83693](https://github.com/dotnet/roslyn/pull/83693)) - * Fix progress reporting to report done on dispose (PR: [#83686](https://github.com/dotnet/roslyn/pull/83686)) * Fix single line script tag formatting (PR: [#83721](https://github.com/dotnet/roslyn/pull/83721)) * Implement type hierarchy LSP methods in Razor (PR: [#83637](https://github.com/dotnet/roslyn/pull/83637)) * Razor support for Implement Interface (PR: [#83636](https://github.com/dotnet/roslyn/pull/83636)) From 67e0d15e94031e2915f0fd140ea12a9520ee5e77 Mon Sep 17 00:00:00 2001 From: David Wengier Date: Mon, 18 May 2026 08:01:14 +1000 Subject: [PATCH 4/4] Clarify Roslyn update PR description Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- .github/skills/update-roslyn-version/SKILL.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/skills/update-roslyn-version/SKILL.md b/.github/skills/update-roslyn-version/SKILL.md index d39193957..8124b0f71 100644 --- a/.github/skills/update-roslyn-version/SKILL.md +++ b/.github/skills/update-roslyn-version/SKILL.md @@ -158,6 +158,8 @@ This will output a list of PRs in the format needed for the changelog: * (PR: [#](https://github.com/dotnet/roslyn/pull/)) ``` +Keep the raw output from `roslyn-tools pr-finder`; you'll use it unchanged in the pull request description in Step 10. + ### Step 7: Update CHANGELOG.md Add an entry to `CHANGELOG.md` under the current version section (e.g., `# 2.121.x`): @@ -174,7 +176,7 @@ Note: Leave the PR number blank initially (just `[#]`) - it will be updated afte ### Step 8: Filter Changelog Entries -Review the changelog entries and remove any PRs that obviously don't affect VS Code. Remove entries that are: +Review the changelog entries in `CHANGELOG.md` and remove any PRs that obviously don't affect VS Code. Remove entries that are: - **Infrastructure/Build changes**: CI/CD pipelines, build scripts, Azure DevOps configurations - **Visual Studio-only changes**: Features or fixes specific to Visual Studio IDE (not VS Code) @@ -203,6 +205,7 @@ git push -u origin update/roslyn- Create a pull request on GitHub: - Title: `Update roslyn to ` - Base: `main` +- Description/body: the raw, unfiltered output from `roslyn-tools pr-finder` in Step 6, including the compare link and full PR list exactly as produced by the tool. Do not apply the Step 8 changelog filtering to the PR description. ### Step 11: Update Changelog with PR Number