Skip to content

Commit e73bdc4

Browse files
committed
Change :logger key to use refset
Change :logger key to use refset in order to make the logger optional.
1 parent 77b0bd6 commit e73bdc4

2 files changed

Lines changed: 8 additions & 8 deletions

File tree

src/duct/module/sql.clj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@
33

44
(defmethod ig/expand-key :duct.module/sql [_ _]
55
{:duct.database.sql/hikaricp
6-
{:logger (ig/ref :duct/logger)
6+
{:logger (ig/refset :duct/logger)
77
:jdbcUrl (ig/var 'jdbc-url)}
88
:duct.migrator/ragtime
9-
{:logger (ig/ref :duct/logger)
9+
{:logger (ig/refset :duct/logger)
1010
:database (ig/ref :duct.database/sql)
1111
:strategy (ig/profile
1212
:main :raise-error

test/duct/module/sql_test.clj

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,10 @@
99
(testing "main config"
1010
(is (= {:duct.database.sql/hikaricp
1111
{:jdbcUrl "jdbc:sqlite:"
12-
:logger (ig/ref :duct/logger)}
12+
:logger (ig/refset :duct/logger)}
1313
:duct.migrator/ragtime
1414
{:database (ig/ref :duct.database/sql)
15-
:logger (ig/ref :duct/logger)
15+
:logger (ig/refset :duct/logger)
1616
:strategy :raise-error
1717
:migrations-file "migrations.edn"}}
1818
(-> {:duct.module/sql {}}
@@ -22,10 +22,10 @@
2222
(testing "repl config"
2323
(is (= {:duct.database.sql/hikaricp
2424
{:jdbcUrl "jdbc:sqlite:"
25-
:logger (ig/ref :duct/logger)}
25+
:logger (ig/refset :duct/logger)}
2626
:duct.migrator/ragtime
2727
{:database (ig/ref :duct.database/sql)
28-
:logger (ig/ref :duct/logger)
28+
:logger (ig/refset :duct/logger)
2929
:strategy :rebase
3030
:migrations-file "migrations.edn"}}
3131
(-> {:duct.module/sql {}}
@@ -35,10 +35,10 @@
3535
(testing "test config"
3636
(is (= {:duct.database.sql/hikaricp
3737
{:jdbcUrl "jdbc:sqlite:"
38-
:logger (ig/ref :duct/logger)}
38+
:logger (ig/refset :duct/logger)}
3939
:duct.migrator/ragtime
4040
{:database (ig/ref :duct.database/sql)
41-
:logger (ig/ref :duct/logger)
41+
:logger (ig/refset :duct/logger)
4242
:strategy :rebase
4343
:migrations-file "migrations.edn"}}
4444
(-> {:duct.module/sql {}}

0 commit comments

Comments
 (0)