Merge pull request #9 from dylibso/required-vs-nullable

bhelx · web-flow · commit 60242c8849d6 · 2024-11-11T08:22:31.000-06:00
Support nullable vs required
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -17,7 +17,7 @@
     "typescript": "^5.3.2"
   },
   "dependencies": {
-    "@dylibso/xtp-bindgen": "1.0.0-rc.8",
+    "@dylibso/xtp-bindgen": "1.0.0-rc.11",
     "ejs": "^3.1.10"
   }
 }
diff --git a/src/index.ts b/src/index.ts
@@ -55,7 +55,7 @@ function toPythonType(property: Property): string {
   }
 
   if (!tp) throw new Error("Cant convert property to Python type: " + property.type)
-  if (!property.nullable) return tp
+  if (!property.nullable && !property.required) return tp
   return `Optional[${tp}]`
 }
 

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ function toPythonType(property: Property): string {`
`55`	`55`	`}`
`56`	`56`
`57`	`57`	`if (!tp) throw new Error("Cant convert property to Python type: " + property.type)`
`58`		`- if (!property.nullable) return tp`
	`58`	`+ if (!property.nullable && !property.required) return tp`
`59`	`59`	return `Optional[${tp}]`
`60`	`60`	`}`
`61`	`61`