Add cross join

Author: adamzapasnik

lib/sqlite_ecto/connection.ex

@@ -276,12 +276,16 @@ if Code.ensure_loaded?(Sqlitex.Server) do
       [?\s | intersperse_map(joins, ?\s, fn
         %JoinExpr{on: %QueryExpr{expr: expr}, qual: qual, ix: ix, source: source} ->
           {join, name} = get_source(query, sources, ix, source)
-          [join_qual(qual), join, " AS ", name, " ON " | expr(expr, sources, query)]
+          [join_qual(qual), join, " AS ", name, join_on(qual, expr, sources, query)]
       end)]
     end
 
+    defp join_on(:cross, true, _sources, _query), do: []
+    defp join_on(_qual, expr, sources, query), do: [" ON " | expr(expr, sources, query)]
+
     defp join_qual(:inner), do: "INNER JOIN "
     defp join_qual(:left), do: "LEFT JOIN "
+    defp join_qual(:cross), do: "CROSS JOIN "
     defp join_qual(mode), do: raise ArgumentError, "join `#{inspect mode}` not supported by SQLite"
 
     defp where(%Query{wheres: wheres} = query, sources) do

test/sqlite_ecto_test.exs

@@ -660,10 +660,9 @@ defmodule Sqlite.Ecto2.Test do
   end
 
   test "cross join" do
-    assert_raise ArgumentError, "join `:cross` not supported by SQLite", fn ->
-      query = from(p in Schema, cross_join: c in Schema2, select: {p.id, c.id}) |> normalize()
-      all(query)
-    end
+    query = from(p in Schema, cross_join: c in Schema2, select: {p.id, c.id}) |> normalize()
+    assert all(query) ==
+           "SELECT s0.\"id\", s1.\"id\" FROM \"schema\" AS s0 CROSS JOIN \"schema2\" AS s1"
   end
 
   test "join produces correct bindings" do