Skip to content

Commit 2bc37d4

Browse files
committed
Upgrade ember-cli to 2.15
1 parent d1d9f93 commit 2bc37d4

9 files changed

Lines changed: 116 additions & 101 deletions

File tree

app/index.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,9 @@
1010
{{content-for 'head'}}
1111

1212
<link rel="icon" type="image/x-icon" href="favicon.ico">
13-
<link rel="stylesheet" href="{{rootURL}}loader.css">
14-
<link rel="stylesheet" href="{{rootURL}}assets/vendor.css">
15-
<link rel="stylesheet" href="{{rootURL}}assets/ember-twiddle.css">
13+
<link integrity="" rel="stylesheet" href="{{rootURL}}loader.css">
14+
<link integrity="" rel="stylesheet" href="{{rootURL}}assets/vendor.css">
15+
<link integrity="" rel="stylesheet" href="{{rootURL}}assets/ember-twiddle.css">
1616
<link href='//fonts.googleapis.com/css?family=Maven+Pro:400,500,700' rel='stylesheet' type='text/css'>
1717

1818
{{content-for 'head-footer'}}

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
"ember-ajax": "^3.0.0",
3030
"ember-api-actions": "~0.1.8",
3131
"ember-autoresize": "~0.6.1",
32-
"ember-cli": "2.14.2",
32+
"ember-cli": "2.15.1",
3333
"ember-cli-app-version": "^3.0.0",
3434
"ember-cli-babel": "^6.12.0",
3535
"ember-cli-bootstrap-sassy": "~0.5.8",
@@ -44,7 +44,7 @@
4444
"ember-cli-fastboot": "^1.0.0",
4545
"ember-cli-file-creator": "~0.4.0",
4646
"ember-cli-htmlbars": "^2.0.1",
47-
"ember-cli-htmlbars-inline-precompile": "~0.4.4",
47+
"ember-cli-htmlbars-inline-precompile": "^1.0.0",
4848
"ember-cli-inject-live-reload": "^1.7.0",
4949
"ember-cli-jstree": "^1.0.9",
5050
"ember-cli-legacy-blueprints": "~0.2.1",
@@ -72,7 +72,7 @@
7272
"ember-resolver": "^4.0.0",
7373
"ember-responsive": "^2.0.8",
7474
"ember-route-action-helper": "^2.0.6",
75-
"ember-source": "~2.14.1",
75+
"ember-source": "~2.15.0",
7676
"ember-test-helpers": "~0.6.3",
7777
"eslint-plugin-ember": "^5.1.0",
7878
"ivy-codemirror": "^2.1.0",

tests/acceptance/columns-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,5 +93,5 @@ test('you can add and remove columns', function(assert) {
9393
});
9494

9595
function urlHas(text) {
96-
return decodeURIComponent(window.location.search).indexOf(text) > 0;
96+
return decodeURIComponent(currentURL()).indexOf(text) > 0;
9797
}

tests/acceptance/fork-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ test('can fork a gist', function(assert) {
4545
andThen(function() {
4646
assert.equal(find('.test-unsaved-indicator').length, 0, "No unsaved indicator shown");
4747

48-
let url = window.location.href;
48+
let url = currentURL();
4949
let route = url.substr(url.lastIndexOf('/'));
5050
assert.equal(route, '/bd9d8d69-a674-4e0f-867c-c8796ed151a0');
5151
});

tests/acceptance/gist-test.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import moduleForAcceptance from 'ember-twiddle/tests/helpers/module-for-acceptan
33
import { findMapText } from 'ember-twiddle/tests/helpers/util';
44
import ErrorMessages from 'ember-twiddle/utils/error-messages';
55
import { stubValidSession } from 'ember-twiddle/tests/helpers/torii';
6-
6+
import { timeout } from 'ember-concurrency';
77

88
const firstColumn = '.code:eq(0)';
99
const firstFilePicker = firstColumn + ' .dropdown-toggle';
@@ -322,6 +322,10 @@ test('unsaved indicator', function(assert) {
322322
fillIn(firstColumnTextarea, "\"some text\";");
323323
triggerEvent(firstColumnTextarea, "blur");
324324

325+
andThen(function() {
326+
return timeout(10);
327+
});
328+
325329
andThen(function() {
326330
assert.equal(find(indicator).length, 1, "Unsaved indicator reappears after editing");
327331
});

tests/acceptance/routing-test.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ test('Able to do routing in a gist', function(assert) {
8888

8989
andThen(() => {
9090
assert.equal(find(addressBar).val(), '/', "Correct URL is shown in address bar 0");
91-
assert.ok(decodeURIComponent(window.location.search).indexOf("route=") === -1, "URL is not added to route query string parameter 0");
91+
assert.ok(decodeURIComponent(currentURL()).indexOf("route=") === -1, "URL is not added to route query string parameter 0");
9292

9393
this.registerWaiter();
9494
iframe_window = outputPane();
@@ -98,7 +98,7 @@ test('Able to do routing in a gist', function(assert) {
9898
andThen(() => {
9999
assert.equal(outputContents(outletText), 'About Page', 'About Link leads to About Page being displayed');
100100
assert.equal(find(addressBar).val(), '/about', "Correct URL is shown in address bar 1");
101-
assert.ok(decodeURIComponent(window.location.search).indexOf("route=/about") > 0, "URL is added to route query string parameter 1");
101+
assert.ok(decodeURIComponent(currentURL()).indexOf("route=/about") > 0, "URL is added to route query string parameter 1");
102102

103103
this.registerWaiter();
104104
iframe_window.click(iframe_window.find(indexLink));
@@ -107,7 +107,7 @@ test('Able to do routing in a gist', function(assert) {
107107
andThen(() => {
108108
assert.equal(outputContents(outletText), 'Main Page', 'Index Link leads to Main Page being displayed');
109109
assert.equal(find(addressBar).val(), '/', "Correct URL is shown in address bar 2");
110-
assert.ok(decodeURIComponent(window.location.search).indexOf("route=") === -1, "URL is not added to route query string parameter 2");
110+
assert.ok(decodeURIComponent(currentURL()).indexOf("route=") === -1, "URL is not added to route query string parameter 2");
111111
});
112112
});
113113

tests/helpers/wait-for-loaded-iframe.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ export default function(app, url) {
3838

3939
let times = 0;
4040

41-
return andThen(function tryVisit() {
41+
andThen(function tryVisit() {
4242
url = url || "/";
4343

4444
if (times++ >= 10) {
@@ -49,4 +49,10 @@ export default function(app, url) {
4949
run.later(tryVisit, 10)
5050
}
5151
});
52+
53+
return andThen(function() {
54+
return new RSVP.Promise(function (resolve) {
55+
run.later(resolve, 10);
56+
});
57+
});
5258
}

tests/helpers/wait-for-unloaded-iframe.js

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
import Ember from 'ember';
22
import wait from 'ember-test-helpers/wait';
3+
import RSVP from 'rsvp';
34

4-
const { Test } = Ember;
5+
const { Test, run } = Ember;
56

67
function hasNoIframe() {
78
return this.app.testHelpers.find('iframe').length > 0;
@@ -13,5 +14,10 @@ export default function(app) {
1314

1415
return wait().then(() => {
1516
Test.unregisterWaiter(ctx, hasNoIframe);
17+
return RSVP.resolve();
18+
}).then(() => {
19+
return new RSVP.Promise(function (resolve) {
20+
run.later(resolve, 10);
21+
});
1622
});
17-
}
23+
}

0 commit comments

Comments
 (0)