Skip to content

Commit 7607b84

Browse files
authored
Merge pull request #544 from Gaurav0/ember_cli_2_11
Upgrade to Ember CLI 2.11
2 parents 3c3b8cb + b5d195a commit 7607b84

16 files changed

Lines changed: 539 additions & 435 deletions

File tree

app/components/dummy-app.js

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,11 @@ export default Ember.Component.extend(ResizeMixin, {
2222
this.element.removeChild(this.element.firstElementChild);
2323
}
2424

25+
let oldIframe = document.getElementById(this.iframeId);
26+
if (oldIframe) {
27+
oldIframe.parentNode.removeChild(oldIframe);
28+
}
29+
2530
let ifrm = document.createElement('iframe');
2631
ifrm.id = this.iframeId;
2732
let supportsSrcDoc = ('srcdoc' in ifrm);
@@ -60,5 +65,14 @@ export default Ember.Component.extend(ResizeMixin, {
6065
width: width,
6166
height: height
6267
});
63-
})
68+
}),
69+
70+
willDestroyElement() {
71+
this._super(...arguments);
72+
73+
let oldIframe = document.getElementById(this.iframeId);
74+
if (oldIframe) {
75+
oldIframe.parentNode.removeChild(oldIframe);
76+
}
77+
}
6478
});

app/components/file-editor-column.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,19 +43,19 @@ export default Ember.Component.extend({
4343

4444
valueUpdated(value, __, changeObj) {
4545
const isUserChange = changeObj.origin !== 'setValue';
46-
this.attrs.contentChanged(isUserChange, value);
46+
this.get('contentChanged')(isUserChange, value);
4747
},
4848

4949
removeColumn(col) {
50-
this.attrs.removeColumn(col);
50+
this.get('removeColumn')(col);
5151
},
5252

5353
addColumn() {
54-
this.attrs.addColumn();
54+
this.get('addColumn')();
5555
},
5656

5757
showFileTree() {
58-
this.attrs.showFileTree();
58+
this.get('showFileTree')();
5959
}
6060
}
6161
});

app/components/run-or-live-reload.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,11 @@ export default Ember.Component.extend({
1111

1212
actions: {
1313
runNowClicked() {
14-
this.attrs.runNow();
14+
this.get('runNow')();
1515
},
1616

1717
liveReloadClicked(checked) {
18-
this.attrs.liveReloadChanged(checked);
18+
this.get('liveReloadChanged')(checked);
1919
}
2020
}
2121
});

app/mixins/app-builder.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,8 @@ export default Ember.Mixin.create({
2626
console.error(errors);
2727
}
2828
}
29-
}),
29+
yield timeout(100);
30+
}).enqueue(),
3031

3132
rebuildApp: task(function *() {
3233
if (this.get('isLiveReload')) {

app/services/ember-cli.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -265,8 +265,10 @@ export default Ember.Service.extend({
265265
// avoids security error
266266
appJS += "window.history.pushState = function() {}; window.history.replaceState = function() {}; window.sessionStorage = undefined;";
267267

268-
// qunit
269-
appJS += "window.QUnit = window.parent.QUnit;";
268+
// Use parent's version of QUnit in Ember.testing mode
269+
if (testing) {
270+
appJS += "window.QUnit = window.parent.QUnit;";
271+
}
270272

271273
// Hide toolbar since it is not working
272274
appCSS += `\n#qunit-testrunner-toolbar, #qunit-tests a[href] { display: none; }\n`;

app/templates/components/file-editor-column.hbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,6 @@
5252
fixedGutter=true
5353
lineWrapping=true
5454
tabSize=2)
55-
valueUpdated="valueUpdated"
55+
valueUpdated=(action "valueUpdated")
5656
}}
5757
{{/if}}

blueprints/twiddle.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"version": "0.12.1",
2+
"version": "0.12.2",
33
"EmberENV": {
44
"FEATURES": {}
55
},

bower.json

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
{
22
"name": "ember-twiddle",
3-
"version": "0.12.1",
3+
"version": "0.12.2",
44
"dependencies": {
5-
"ember": "~2.10.2",
6-
"ember-cli-shims": "0.1.3",
75
"jquery": "1.11.3",
86
"codemirror": "~5.19.0",
97
"bootstrap-sass": "~3.3.5",
@@ -17,7 +15,6 @@
1715
},
1816
"resolutions": {
1917
"codemirror": "~5.19.0",
20-
"ember": "~2.10.2",
2118
"FakeXMLHttpRequest": "^1.3.0",
2219
"route-recognizer": "^0.2.3"
2320
}

ember-cli-build.js

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ module.exports = function(defaults) {
6363
}
6464
}
6565
},
66-
babel: {
66+
'ember-cli-babel': {
6767
includePolyfill: !isFastboot
6868
},
6969

@@ -87,7 +87,7 @@ module.exports = function(defaults) {
8787
app.import('vendor/polyfill.js', { prepend: true });
8888
}
8989

90-
app.import('bower_components/ember/ember-template-compiler.js');
90+
app.import('vendor/ember/ember-template-compiler.js');
9191
app.import('bower_components/babel/browser.js');
9292
app.import('vendor/shims/babel.js');
9393
app.import('vendor/shims/path.js');
@@ -123,6 +123,9 @@ module.exports = function(defaults) {
123123
});
124124

125125
var bowerTree = funnel('bower_components');
126+
var shimsTree = funnel('node_modules/ember-cli-shims/vendor/ember-cli-shims' , {
127+
destDir: 'ember-cli-shims'
128+
});
126129

127130
var baseResolverTree = funnel('node_modules/ember-resolver/addon', {
128131
destDir: 'ember-resolver'
@@ -147,7 +150,7 @@ module.exports = function(defaults) {
147150
var finalQUnitTree = buildAddonTree('ember-qunit');
148151
var finalTestHelpersTree = buildAddonTree('ember-test-helpers');
149152

150-
var mergedDepsTree = mergeTrees([bowerTree, transpiledInitializersTree, transpiledResolverTree, emberDataShims]);
153+
var mergedDepsTree = mergeTrees([bowerTree, shimsTree, transpiledInitializersTree, transpiledResolverTree, emberDataShims]);
151154

152155
var twiddleVendorTree = concat(mergedDepsTree, {
153156
inputFiles: [

mirage/fixtures/ember-data.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
export default {
22
"status": "build_success",
33
"status_date": "2016-03-21T01:55:42.140Z",
4-
"addon_js": "//canary-addons.ember-twiddle.com/ember-2.11.0/ember-data/2.11.3/addon.js",
5-
"addon_css": "//canary-addons.ember-twiddle.com/ember-2.11.0/ember-data/2.11.3/addon.css",
4+
"addon_js": "//canary-addons.ember-twiddle.com/ember-2.12.0/ember-data/2.12.1/addon.js",
5+
"addon_css": "//canary-addons.ember-twiddle.com/ember-2.12.0/ember-data/2.12.1/addon.css",
66
"errors": null,
77
"ember_errors": null
88
};

0 commit comments

Comments
 (0)