Skip to content

Commit befcf4f

Browse files
authored
Merge pull request #703 from Gaurav0/update_blueprints
Update blueprints
2 parents 03771b9 + 51f0417 commit befcf4f

8 files changed

Lines changed: 31 additions & 21 deletions

File tree

.eslintrc.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,12 @@
11
module.exports = {
22
root: true,
3+
parser: 'babel-eslint',
34
parserOptions: {
45
ecmaVersion: 2018,
5-
sourceType: 'module'
6+
sourceType: 'module',
7+
ecmaFeatures: {
8+
legacyDecorators: true
9+
}
610
},
711
plugins: [
812
'ember'
Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
import Ember from 'ember';
1+
import Controller from '@ember/controller';
22

3-
export default Ember.Controller.extend({
4-
appName: 'Ember Twiddle'
5-
});
3+
export default class ApplicationController extends Controller {
4+
appName = 'Ember Twiddle';
5+
}

blueprints/application_template.hbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<h1>Welcome to {{appName}}</h1>
1+
<h1>Welcome to {{this.appName}}</h1>
22
<br>
33
<br>
44
{{outlet}}

blueprints/model.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,5 @@ import attr from 'ember-data/attr';
44
import { belongsTo, hasMany } from 'ember-data/relationships';
55
*/
66

7-
export default Model.extend({
8-
});
7+
export default class extends Model {
8+
}

lib/get-ember-cli-blueprints.js

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
// own blueprints
66
function getEmberCLIBlueprints() {
77
const fs = require('fs');
8-
const path = require('path');
98
let fileMap = {};
109

1110
let blueprintFiles = {
@@ -23,19 +22,14 @@ function getEmberCLIBlueprints() {
2322
'route-test': 'route-test/qunit-rfc-232-files/__root__/__testType__/__path__/__test__.js',
2423
'service-test': 'service-test/qunit-rfc-232-files/__root__/__testType__/__path__/__test__.js',
2524
'component-test': 'component-test/qunit-rfc-232-files/__root__/__testType__/__path__/__test__.js',
26-
'acceptance-test': 'acceptance-test/qunit-rfc-232-files/tests/acceptance/__name__-test.js'
27-
}
28-
},
29-
"legacyBlueprintFiles": {
30-
"path": path.dirname(require.resolve('ember-cli-legacy-blueprints')),
31-
"files": {
25+
'acceptance-test': 'acceptance-test/qunit-rfc-232-files/tests/acceptance/__name__-test.js',
3226
'component-hbs': 'component/files/__root__/__templatepath__/__templatename__.hbs',
3327
'component-js': 'component/files/__root__/__path__/__name__.js',
3428
'controller': 'controller/files/__root__/__path__/__name__.js',
3529
'route': 'route/files/__root__/__path__/__name__.js',
3630
'service': 'service/files/__root__/__path__/__name__.js',
3731
'template': 'template/files/__root__/__path__/__name__.hbs',
38-
'helper': 'helper/files/__root__/helpers/__name__.js'
32+
'helper': 'helper/files/__root__/__collection__/__name__.js'
3933
}
4034
}
4135
}

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
"@ember/test-helpers": "^1.7.1",
2626
"@rollup/plugin-commonjs": "^11.0.2",
2727
"@rollup/plugin-json": "^4.0.2",
28+
"babel-eslint": "^10.0.3",
2829
"babel-plugin-debug-macros": "^0.3.3",
2930
"babel-plugin-ember-modules-api-polyfill": "^2.12.0",
3031
"broccoli-asset-rev": "^3.0.0",

tests/unit/services/ember-cli-test.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ module('Unit | Service | ember cli', function(hooks) {
7474
});
7575

7676
test("buildProperties() works as expected with replacements", function (assert) {
77-
assert.expect(5);
77+
assert.expect(4);
7878

7979
var service = this.owner.lookup('service:ember-cli');
8080
var props = service.buildProperties('helper', {
@@ -85,7 +85,6 @@ module('Unit | Service | ember cli', function(hooks) {
8585
assert.ok(props.content, 'has content');
8686
assert.ok(props.content.indexOf('<%=') === -1, 'No replacement tags in content');
8787
assert.ok(props.content.indexOf('myHelper(params') !== -1, 'Replacements worked');
88-
assert.ok(props.content.indexOf('helper(myHelper)') !== -1, 'Replacements worked if multiple');
8988
});
9089

9190
test('compileHbs includes moduleName', function(assert) {

yarn.lock

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,7 @@
255255
esutils "^2.0.2"
256256
js-tokens "^4.0.0"
257257

258-
"@babel/parser@^7.3.4", "@babel/parser@^7.8.6":
258+
"@babel/parser@^7.3.4", "@babel/parser@^7.7.0", "@babel/parser@^7.8.6":
259259
version "7.8.6"
260260
resolved "https://registry.yarnpkg.com/@babel/parser/-/parser-7.8.6.tgz#ba5c9910cddb77685a008e3c587af8d27b67962c"
261261
integrity sha512-trGNYSfwq5s0SgM1BMEB8hX3NDmO7EP2wsDGDexiaKMB92BaRpS+qZfpkMqUBhcsOTBwNy9B/jieo4ad/t/z2g==
@@ -784,7 +784,7 @@
784784
"@babel/parser" "^7.8.6"
785785
"@babel/types" "^7.8.6"
786786

787-
"@babel/traverse@^7.1.6", "@babel/traverse@^7.2.4", "@babel/traverse@^7.3.4", "@babel/traverse@^7.8.3", "@babel/traverse@^7.8.4", "@babel/traverse@^7.8.6":
787+
"@babel/traverse@^7.1.6", "@babel/traverse@^7.2.4", "@babel/traverse@^7.3.4", "@babel/traverse@^7.7.0", "@babel/traverse@^7.8.3", "@babel/traverse@^7.8.4", "@babel/traverse@^7.8.6":
788788
version "7.8.6"
789789
resolved "https://registry.yarnpkg.com/@babel/traverse/-/traverse-7.8.6.tgz#acfe0c64e1cd991b3e32eae813a6eb564954b5ff"
790790
integrity sha512-2B8l0db/DPi8iinITKuo7cbPznLCEk0kCxDoB9/N6gGNg/gxOXiR/IcymAFPiBwk5w6TtQ27w4wpElgp9btR9A==
@@ -799,7 +799,7 @@
799799
globals "^11.1.0"
800800
lodash "^4.17.13"
801801

802-
"@babel/types@^7.1.6", "@babel/types@^7.3.2", "@babel/types@^7.3.4", "@babel/types@^7.4.0", "@babel/types@^7.8.3", "@babel/types@^7.8.6":
802+
"@babel/types@^7.1.6", "@babel/types@^7.3.2", "@babel/types@^7.3.4", "@babel/types@^7.4.0", "@babel/types@^7.7.0", "@babel/types@^7.8.3", "@babel/types@^7.8.6":
803803
version "7.8.6"
804804
resolved "https://registry.yarnpkg.com/@babel/types/-/types-7.8.6.tgz#629ecc33c2557fcde7126e58053127afdb3e6d01"
805805
integrity sha512-wqz7pgWMIrht3gquyEFPVXeXCti72Rm8ep9b5tQKz9Yg9LzJA3HxosF1SB3Kc81KD1A3XBkkVYtJvCKS2Z/QrA==
@@ -1924,6 +1924,18 @@ babel-core@^6.24.1, babel-core@^6.26.0, babel-core@^6.26.3:
19241924
slash "^1.0.0"
19251925
source-map "^0.5.7"
19261926

1927+
babel-eslint@^10.0.3:
1928+
version "10.1.0"
1929+
resolved "https://registry.yarnpkg.com/babel-eslint/-/babel-eslint-10.1.0.tgz#6968e568a910b78fb3779cdd8b6ac2f479943232"
1930+
integrity sha512-ifWaTHQ0ce+448CYop8AdrQiBsGrnC+bMgfyKFdi6EsPLTAWG+QfyDeM6OH+FmWnKvEq5NnBMLvlBUPKQZoDSg==
1931+
dependencies:
1932+
"@babel/code-frame" "^7.0.0"
1933+
"@babel/parser" "^7.7.0"
1934+
"@babel/traverse" "^7.7.0"
1935+
"@babel/types" "^7.7.0"
1936+
eslint-visitor-keys "^1.0.0"
1937+
resolve "^1.12.0"
1938+
19271939
babel-generator@^6.26.0:
19281940
version "6.26.1"
19291941
resolved "https://registry.yarnpkg.com/babel-generator/-/babel-generator-6.26.1.tgz#1844408d3b8f0d35a404ea7ac180f087a601bd90"

0 commit comments

Comments
 (0)