Remove unnecessary computed

Author: kategengler

app/controllers/project-version/classes/class.js

@@ -1,8 +1,6 @@
-// eslint-disable-next-line ember/no-computed-properties-in-native-classes
-import { action, computed, set, get } from '@ember/object';
+import { action } from '@ember/object';
 import { service } from '@ember/service';
 import Controller from '@ember/controller';
-import { A } from '@ember/array';
 import { capitalize } from '@ember/string';
 import { isEmpty } from '@ember/utils';
 import { parentName } from '../../../utils/parent-name';
@@ -26,19 +24,16 @@ export default class ClassController extends Controller {
   @service
   metaStore;
 
-  @computed(
-    'filterData.{showInherited,showProtected,showPrivate,showDeprecated}',
-  )
   get visibilityFilter() {
     let appliedFilters = filterTypes
       .reduce((filters, filter) => {
-        let filterValue = get(this, `filterData.show${capitalize(filter)}`)
+        let filterValue = this.filterData[`show${capitalize(filter)}`]
           ? filter
           : null;
         filters.push(filterValue);
         return filters;
-      }, A())
-      .compact();
+      }, [])
+      .filter(Boolean);
 
     if (isEmpty(appliedFilters)) {
       return DEFAULT_FILTER;
@@ -48,30 +43,27 @@ export default class ClassController extends Controller {
   }
 
   set visibilityFilter(value = '') {
-    let filters = A(value.split(','));
+    let filters = value.split(',');
     filterTypes.forEach((filter) => {
-      let enabled = filters.indexOf(filter) > -1;
-      set(this, `filterData.show${capitalize(filter)}`, enabled);
+      this.filterData[`show${capitalize(filter)}`] =
+        filters.indexOf(filter) > -1;
     });
   }
 
-  @computed('legacyModuleMappings.mappings', 'model.{module,name}')
   get hasImportExample() {
     return this.legacyModuleMappings.hasClassMapping(
       this.model.name,
       this.model.module,
     );
   }
 
-  @computed('legacyModulemappings.mappings', 'model.{module,name}')
   get module() {
     return this.legacyModuleMappings.getModule(
       this.model.name,
       this.model.module,
     );
   }
 
-  @computed('metaStore.availableProjectVersions', 'model.project.id')
   get allVersions() {
     return this.metaStore.availableProjectVersions[this.model.project.id];
   }

app/services/meta-store.js

@@ -1,6 +1,5 @@
 import Service from '@ember/service';
 import { isPresent } from '@ember/utils';
-import { set } from '@ember/object';
 import { A } from '@ember/array';
 import getCompactVersion from 'ember-api-docs/utils/get-compact-version';
 import getLastVersion from 'ember-api-docs/utils/get-last-version';
@@ -17,7 +16,7 @@ export default class MetaStoreService extends Service {
     let projectRevMap = this.projectRevMap;
     if (!isPresent(projectRevMap[projectVersionKey])) {
       projectRevMap[projectVersionKey] = projectRevDoc;
-      set(this, 'projectRevMap', projectRevMap);
+      this.projectRevMap = projectRevMap;
     }
   }