Skip to content

Commit 9c4a14e

Browse files
committed
Lint fixes
1 parent 75f010e commit 9c4a14e

10 files changed

Lines changed: 13 additions & 19 deletions

File tree

app/registry.d.ts

Lines changed: 0 additions & 9 deletions
This file was deleted.

app/routes/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ export default class IndexRoute extends Route {
2222
includes: 'project-version',
2323
});
2424
foundProject = 'ember-data';
25-
} catch (e) {
25+
} catch {
2626
foundProject = 'ember-cli';
2727
}
2828
}

app/routes/project-version/functions/function.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ export default class FunctionRoute extends Route {
3737
'class',
3838
`${project}-${projectVersion}-${className}`.toLowerCase(),
3939
);
40-
} catch (e) {
40+
} catch {
4141
try {
4242
fnModule = await this.store.findRecord(
4343
'namespace',

app/services/legacy-module-mappings.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ export default class LegacyModuleMappingsService extends Service {
1717
try {
1818
let newMappings = this.buildMappings(legacyMappings);
1919
this.mappings = newMappings;
20-
} catch (e) {
20+
} catch {
2121
this.mappings = [];
2222
}
2323
}

config/fastboot.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
/* eslint-disable n/no-unsupported-features/node-builtins */
2+
13
module.exports = function () {
24
return {
35
buildSandboxGlobals(defaultGlobals) {

eslint.config.mjs

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ import js from '@eslint/js';
1717

1818
import ember from 'eslint-plugin-ember/recommended';
1919
import eslintConfigPrettier from 'eslint-config-prettier';
20-
import qunit from 'eslint-plugin-qunit';
20+
import eslintPluginQunitRecommended from 'eslint-plugin-qunit/configs/recommended';
2121
import n from 'eslint-plugin-n';
2222

2323
import babelParser from '@babel/eslint-parser';
@@ -70,9 +70,7 @@ export default [
7070
},
7171
{
7272
files: ['tests/**/*-test.{js,gjs}'],
73-
plugins: {
74-
qunit,
75-
},
73+
...eslintPluginQunitRecommended,
7674
},
7775
/**
7876
* CJS node files
@@ -89,7 +87,10 @@ export default [
8987
'.stylelintrc.js',
9088
'.template-lintrc.js',
9189
'ember-cli-build.js',
90+
'prember-urls.js',
91+
'lib/api-docs-data/**/*.js',
9292
],
93+
...n.configs['flat/recommended-script'],
9394
plugins: {
9495
n,
9596
},
@@ -107,6 +108,7 @@ export default [
107108
*/
108109
{
109110
files: ['**/*.mjs'],
111+
...n.configs['flat/recommended-module'],
110112
plugins: {
111113
n,
112114
},

tests/acceptance/function-test.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable qunit/no-assert-equal */
21
import { module, test } from 'qunit';
32
import { setupApplicationTest } from 'ember-qunit';
43
import { visit } from '@ember/test-helpers';

tests/acceptance/switch-project-test.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ async function ensureVersionsExist(assert) {
3030
module('Acceptance | Switch Project', function (hooks) {
3131
setupApplicationTest(hooks);
3232

33+
// eslint-disable-next-line qunit/require-expect
3334
test('Can switch projects back and forth', async function (assert) {
3435
assert.expect(9);
3536
await visit('/');
@@ -47,6 +48,7 @@ module('Acceptance | Switch Project', function (hooks) {
4748
assert.dom(find('.spec-ember-data')).hasClass('active');
4849
});
4950

51+
// eslint-disable-next-line qunit/require-expect
5052
test('Can open class after switching projects back and forth', async function (assert) {
5153
assert.expect(10);
5254
await visit('/');

tests/integration/components/class-field-description-test.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable qunit/no-assert-equal */
21
import EmberObject from '@ember/object';
32
import { module, test } from 'qunit';
43
import { setupRenderingTest } from 'ember-qunit';

tests/unit/controllers/project-version-test.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import { module, test } from 'qunit';
2-
/* eslint-disable ember/no-restricted-resolver-tests */
32
import { setupTest } from 'ember-qunit';
43
import { findEndingRoute } from 'ember-api-docs/controllers/project-version';
54

0 commit comments

Comments
 (0)