Replace post model with note to increase clarity

cvx · cvx · commit 2895a7f670b9 · 2019-06-19T16:23:38.000+02:00
diff --git a/tests/dummy/app/models/note.js b/tests/dummy/app/models/note.js
diff --git a/tests/dummy/app/pods/docs/network-mocking/template.md b/tests/dummy/app/pods/docs/network-mocking/template.md
@@ -6,27 +6,27 @@ It makes sense that we would also want to mock the network while running FastBoo
 
 FastBoot Testing exposes an API for intercepting requests made from your FastBoot app.
 
-The following example shows how to mock a test that fetches blog post data.
+The following example shows how to mock a test that fetches note data.
 
 ```js
 import { module, test } from 'qunit';
 import { setup, visit, mockServer } from 'ember-cli-fastboot-testing/test-support';
 
-module('Fastboot | Blog post page', function(hooks) {
+module('Fastboot | Note page', function(hooks) {
   setup(hooks);
 
-  test('it can render a blog post', async function(assert) {
-    await mockServer.get('/api/posts/1', {
+  test('it can render a note', async function(assert) {
+    await mockServer.get('/api/notes/1', {
       data: {
-        type: 'post',
+        type: 'note',
         id: '1',
         attributes: {
           title: 'Hello world!'
         }
       }
     });
 
-    await visit('/posts/1');
+    await visit('/notes/1');
 
     assert.dom('[data-test-id="title"]').hasText("Hello world!");
   });
@@ -38,14 +38,14 @@ The `mockServer#get` method maps a URL to a response for the lifecycle of the te
 By default, the `mockServer` will use a status code of 200. However, an optional status code can be passed in as the third parameter.
 
 ```js
-test('it renders the 404 page when it cannot fetch a blog post', async function(assert) {
+test('it renders the 404 page when it cannot fetch a note', async function(assert) {
   await mockServer.get(
-    '/api/posts/1',
-    { error: 'Post not found' },
+    '/api/notes/1',
+    { error: 'Note not found' },
     404
   );
 
-  await visit('/posts/1');
+  await visit('/notes/1');
 
   assert.dom('[data-test-id="page-not-found"]').exists();
 });
diff --git a/tests/dummy/app/pods/examples/network/notes/index/route.js b/tests/dummy/app/pods/examples/network/notes/index/route.js
@@ -3,7 +3,7 @@ import Route from '@ember/routing/route';
 export default Route.extend({
 
   async model() {
-    return this.store.findAll('post');
+    return this.store.findAll('note');
   }
 
 });
diff --git a/tests/dummy/app/pods/examples/network/notes/index/template.hbs b/tests/dummy/app/pods/examples/network/notes/index/template.hbs
@@ -0,0 +1,7 @@
+The data loaded from the server is:
+
+{{#each model as |note|}}
+  <div data-test-id="title-{{note.id}}">
+    {{note.title}}
+  </div>
+{{/each}}
diff --git a/tests/dummy/app/pods/examples/network/notes/note/route.js b/tests/dummy/app/pods/examples/network/notes/note/route.js
diff --git a/tests/dummy/app/pods/examples/network/notes/note/template.hbs b/tests/dummy/app/pods/examples/network/notes/note/template.hbs
diff --git a/tests/dummy/app/pods/examples/network/other/get-request/route.js b/tests/dummy/app/pods/examples/network/other/get-request/route.js
@@ -4,7 +4,7 @@ import fetch from 'fetch';
 export default Route.extend({
 
   async model() {
-    let response = await fetch('/api/posts', { method: 'post' });
+    let response = await fetch('/api/notes', { method: 'post' });
     return await response.json();
   }
 
diff --git a/tests/dummy/app/pods/examples/network/other/get-request/template.hbs b/tests/dummy/app/pods/examples/network/other/get-request/template.hbs
@@ -1,7 +1,7 @@
 The data loaded from the server is:
 
-{{#each model as |post|}}
-  <div data-test-id="title-{{post.id}}">
-    {{post.title}}
+{{#each model as |note|}}
+  <div data-test-id="title-{{note.id}}">
+    {{note.title}}
   </div>
 {{/each}}
diff --git a/tests/dummy/app/pods/examples/network/other/post-request/route.js b/tests/dummy/app/pods/examples/network/other/post-request/route.js
@@ -4,7 +4,7 @@ import fetch from 'fetch';
 export default Route.extend({
 
   async model() {
-    let response = await fetch('/api/posts', { method: 'post' });
+    let response = await fetch('/api/notes', { method: 'post' });
     return await response.json();
   }
 
diff --git a/tests/dummy/app/pods/examples/network/other/post-request/template.hbs b/tests/dummy/app/pods/examples/network/other/post-request/template.hbs
@@ -1,7 +1,7 @@
 The data loaded from the server is:
 
-{{#each model as |post|}}
-  <div data-test-id="title-{{post.id}}">
-    {{post.title}}
+{{#each model as |note|}}
+  <div data-test-id="title-{{note.id}}">
+    {{note.title}}
   </div>
 {{/each}}
diff --git a/tests/dummy/app/pods/examples/network/posts/index/template.hbs b/tests/dummy/app/pods/examples/network/posts/index/template.hbs
diff --git a/tests/dummy/app/router.js b/tests/dummy/app/router.js
@@ -29,8 +29,8 @@ Router.map(function() {
     this.route('request-object');
 
     this.route('network', function() {
-      this.route('posts', function() {
-        this.route('post', { path: ':post_id' });
+      this.route('notes', function() {
+        this.route('note', { path: ':note_id' });
       });
 
       this.route('other', function() {
diff --git a/tests/dummy/mirage/config.js b/tests/dummy/mirage/config.js
@@ -15,11 +15,11 @@ export default function() {
   /*
     Shorthand cheatsheet:
 
-    this.get('/posts');
-    this.post('/posts');
-    this.get('/posts/:id');
-    this.put('/posts/:id'); // or this.patch
-    this.del('/posts/:id');
+    this.get('/notes');
+    this.post('/notes');
+    this.get('/notes/:id');
+    this.put('/notes/:id'); // or this.patch
+    this.del('/notes/:id');
 
     http://www.ember-cli-mirage.com/docs/v0.4.x/shorthands/
   */
diff --git a/tests/dummy/mirage/scenarios/default.js b/tests/dummy/mirage/scenarios/default.js
@@ -5,5 +5,5 @@ export default function(/* server */) {
     This data will not be loaded in your tests.
   */
 
-  // server.createList('post', 10);
+  // server.createList('note', 10);
 }
diff --git a/tests/fastboot/network-mocking-test.js b/tests/fastboot/network-mocking-test.js
@@ -10,17 +10,17 @@ module('Fastboot | network mocking', function(hooks) {
   });
 
   test('it can mock an array of models', async function(assert) {
-    await mockServer.get('/api/posts', {
+    await mockServer.get('/api/notes', {
       data: [
         {
-          type: 'post',
+          type: 'note',
           id: '1',
           attributes: {
-            title: 'test post'
+            title: 'test note'
           }
         },
         {
-          type: 'post',
+          type: 'note',
           id: '2',
           attributes: {
             title: 'test 2'
@@ -29,31 +29,31 @@ module('Fastboot | network mocking', function(hooks) {
       ]
     });
 
-    await visit('/examples/network/posts');
+    await visit('/examples/network/notes');
 
-    assert.dom('[data-test-id="title-1"]').hasText("test post")
+    assert.dom('[data-test-id="title-1"]').hasText("test note")
     assert.dom('[data-test-id="title-2"]').hasText("test 2")
   });
 
   test('it can mock a single model', async function(assert) {
-    await mockServer.get('/api/posts/1', {
+    await mockServer.get('/api/notes/1', {
       data: {
-        type: "posts",
+        type: "note",
         id: "1",
         attributes: {
-          title: 'test post'
+          title: 'test note'
         }
       }
     });
 
-    await visit('/examples/network/posts/1');
+    await visit('/examples/network/notes/1');
 
-    assert.dom('[data-test-id="title"]').hasText("test post");
+    assert.dom('[data-test-id="title"]').hasText("test note");
   });
 
   test('it can mock 404s', async function(assert) {
     await mockServer.get(
-      '/api/posts/1',
+      '/api/notes/1',
       {
         errors: [
           { title: "Not found" }
@@ -62,28 +62,28 @@ module('Fastboot | network mocking', function(hooks) {
       404
     );
 
-    await visit('/examples/network/posts/1');
+    await visit('/examples/network/notes/1');
 
-    assert.dom().includesText('Ember Data Request GET /api/posts/1 returned a 404');
+    assert.dom().includesText('Ember Data Request GET /api/notes/1 returned a 404');
   });
 
   test('it can mock a get request', async function(assert) {
-    await mockServer.post('/api/posts', [
-      { id: 1, title: 'get post'},
+    await mockServer.post('/api/notes', [
+      { id: 1, title: 'get note'},
     ]);
 
     await visit('/examples/network/other/get-request');
 
-    assert.dom('[data-test-id="title-1"]').hasText("get post")
+    assert.dom('[data-test-id="title-1"]').hasText("get note")
   });
 
   test('it can mock a post request', async function(assert) {
-    await mockServer.post('/api/posts', [
-      { id: 1, title: 'post post'},
+    await mockServer.post('/api/notes', [
+      { id: 1, title: 'post note'},
     ]);
 
     await visit('/examples/network/other/post-request');
 
-    assert.dom('[data-test-id="title-1"]').hasText("post post")
+    assert.dom('[data-test-id="title-1"]').hasText("post note")
   });
 });

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@ import Route from '@ember/routing/route';`
`3`	`3`	`export default Route.extend({`
`4`	`4`
`5`	`5`	`async model() {`
`6`		`- return this.store.findAll('post');`
	`6`	`+ return this.store.findAll('note');`
`7`	`7`	`}`
`8`	`8`
`9`	`9`	`});`
Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@ import fetch from 'fetch';`
`4`	`4`	`export default Route.extend({`
`5`	`5`
`6`	`6`	`async model() {`
`7`		`- let response = await fetch('/api/posts', { method: 'post' });`
	`7`	`+ let response = await fetch('/api/notes', { method: 'post' });`
`8`	`8`	`return await response.json();`
`9`	`9`	`}`
`10`	`10`