Skip to content

Commit ec61dbe

Browse files
authored
Merge pull request #799 from embermap/revert-fastboot-peer-dep
Revert fastboot as peerDependency, allows v3 and v4 instead
2 parents 4a5984e + 0cf3e95 commit ec61dbe

3 files changed

Lines changed: 25 additions & 7 deletions

File tree

package.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
"body-parser": "^1.20.0",
3232
"ember-auto-import": "^2.6.1",
3333
"ember-cli-babel": "^7.26.11",
34+
"fastboot": "^3.0.3 || ^4.1.1",
3435
"json-fn": "^1.1.1",
3536
"minimist": "^1.2.6",
3637
"nock": "^13.2.4",
@@ -50,7 +51,6 @@
5051
"broccoli-plugin": "^4.0.7",
5152
"broccoli-stew": "^3.0.0",
5253
"concurrently": "^8.0.1",
53-
"fastboot": "^4.1.0",
5454
"ember-cli": "~4.11.0",
5555
"ember-cli-addon-docs": "github:ember-learn/ember-cli-addon-docs#eb825bcc1e721dbebc73e5dbd98db2ebb3026dd3",
5656
"ember-cli-addon-docs-yuidoc": "^1.0.0",
@@ -92,8 +92,7 @@
9292
"webpack": "^5.75.0"
9393
},
9494
"peerDependencies": {
95-
"ember-source": "^3.28.0 || ^4.0.0 || ^5.0.0",
96-
"fastboot": "*"
95+
"ember-source": "^3.28.0 || ^4.0.0 || ^5.0.0"
9796
},
9897
"engines": {
9998
"node": "12.* || 14.* || 16.* || >= 18"

tests/dummy/config/ember-try.js

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,32 +34,38 @@ module.exports = async function () {
3434
{
3535
name: 'fastboot-1.2',
3636
npm: {
37+
dependencies: {
38+
fastboot: '~1.2.1',
39+
},
3740
devDependencies: {
3841
'ember-source': '~3.20.7',
3942
'ember-data': '~3.20.5',
4043
'ember-qunit': '^5.1.5',
41-
fastboot: '~1.2.1',
4244
},
4345
},
4446
},
4547
{
4648
name: 'fastboot-2.0',
4749
npm: {
50+
dependencies: {
51+
fastboot: '~2.0.3',
52+
},
4853
devDependencies: {
4954
'ember-cli-fastboot': '^2.0.0',
5055
'ember-data': '~3.20.5',
5156
'ember-qunit': '^5.1.5',
5257
'ember-source': '~3.20.7',
53-
fastboot: '~2.0.3',
5458
},
5559
},
5660
},
5761
{
5862
name: 'fastboot-3.0',
5963
npm: {
64+
dependencies: {
65+
fastboot: '^3.0.0',
66+
},
6067
devDependencies: {
6168
'ember-cli-fastboot': '^3.0.0',
62-
fastboot: '^3.0.0',
6369
},
6470
},
6571
},

yarn.lock

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7627,7 +7627,7 @@ fastboot-transform@^0.1.3:
76277627
broccoli-stew "^1.5.0"
76287628
convert-source-map "^1.5.1"
76297629

7630-
fastboot@4.1.0, fastboot@^4.1.0:
7630+
fastboot@4.1.0:
76317631
version "4.1.0"
76327632
resolved "https://registry.yarnpkg.com/fastboot/-/fastboot-4.1.0.tgz#4c2f62841d80b0a246e38adb3c35b626e2f42087"
76337633
integrity sha512-NoUUiWhLS4JfrYiHmbRjqqWmzttO+6hVyt+CawsZCg79ljTGAIhPThy8cxg11yiDNiaM9EY3kocWZrCMUM7o4g==
@@ -7640,6 +7640,19 @@ fastboot@4.1.0, fastboot@^4.1.0:
76407640
simple-dom "^1.4.0"
76417641
source-map-support "^0.5.21"
76427642

7643+
"fastboot@^3.0.3 || ^4.1.1":
7644+
version "4.1.1"
7645+
resolved "https://registry.yarnpkg.com/fastboot/-/fastboot-4.1.1.tgz#b686dc522ef805557ff76ded23328c486991cbaa"
7646+
integrity sha512-XG7YprsAuAGZrUDhmJ0NFuEP0gpWg9LZwGWSS1I5+f0ETHKPWqb4x59sN2rU1nvCEETBK70z68tLsWsl9daomg==
7647+
dependencies:
7648+
chalk "^4.1.2"
7649+
cookie "^0.4.1"
7650+
debug "^4.3.3"
7651+
jsdom "^19.0.0"
7652+
resolve "^1.22.0"
7653+
simple-dom "^1.4.0"
7654+
source-map-support "^0.5.21"
7655+
76437656
fastq@^1.6.0:
76447657
version "1.15.0"
76457658
resolved "https://registry.yarnpkg.com/fastq/-/fastq-1.15.0.tgz#d04d07c6a2a68fe4599fea8d2e103a937fae6b3a"

0 commit comments

Comments
 (0)