remove pointers

Author: joel-ling

codec.go

@@ -7,19 +7,19 @@ import (
 )
 
 type codec struct {
-	formatMetadataCache map[reflect.Type]*formatMetadata
+	formatMetadataCache map[reflect.Type]formatMetadata
 }
 
-func newCodec() (c *codec) {
-	c = &codec{
-		formatMetadataCache: make(map[reflect.Type]*formatMetadata),
+func newCodec() (c codec) {
+	c = codec{
+		formatMetadataCache: make(map[reflect.Type]formatMetadata),
 	}
 
 	return
 }
 
-func (c *codec) formatMetadataFromTypeReflection(reflection reflect.Type) (
-	format *formatMetadata, e error,
+func (c codec) formatMetadataFromTypeReflection(reflection reflect.Type) (
+	format formatMetadata, e error,
 ) {
 	var (
 		inCache bool
@@ -55,7 +55,7 @@ func (c *codec) formatMetadataFromTypeReflection(reflection reflect.Type) (
 	return
 }
 
-func (c *codec) newOperation(iface interface{}) (
+func (c codec) newOperation(iface interface{}) (
 	operation codecOperation, e error,
 ) {
 	operation.format, e = c.formatMetadataFromTypeReflection(
@@ -71,7 +71,7 @@ func (c *codec) newOperation(iface interface{}) (
 }
 
 type codecOperation struct {
-	format          *formatMetadata
+	format          formatMetadata
 	valueReflection reflect.Value
 }
 

metadata-bit-field.go

@@ -17,7 +17,7 @@ type bitFieldMetadata struct {
 func newBitFieldMetadataFromStructFieldReflection(
 	reflection reflect.StructField,
 ) (
-	bitField *bitFieldMetadata, e error,
+	bitField bitFieldMetadata, e error,
 ) {
 	const (
 		tagKey         = "bitfield"
@@ -61,7 +61,7 @@ func newBitFieldMetadataFromStructFieldReflection(
 		return
 	}
 
-	bitField = &bitFieldMetadata{
+	bitField = bitFieldMetadata{
 		kind: reflection.Type.Kind(),
 	}
 
@@ -92,7 +92,7 @@ func newBitFieldMetadataFromStructFieldReflection(
 	return
 }
 
-func (m *bitFieldMetadata) marshal(reflection reflect.Value) (value uint64) {
+func (m bitFieldMetadata) marshal(reflection reflect.Value) (value uint64) {
 	switch m.kind {
 	case reflect.Uint8, reflect.Uint16, reflect.Uint32, reflect.Uint64:
 		fallthrough
@@ -111,7 +111,7 @@ func (m *bitFieldMetadata) marshal(reflection reflect.Value) (value uint64) {
 	return
 }
 
-func (m *bitFieldMetadata) unmarshal(bytes []byte, reflection reflect.Value) {
+func (m bitFieldMetadata) unmarshal(bytes []byte, reflection reflect.Value) {
 	var (
 		value uint64
 	)

metadata-format.go

@@ -7,12 +7,12 @@ import (
 )
 
 type formatMetadata struct {
-	words         []*wordMetadata
+	words         []wordMetadata
 	lengthInBytes int
 }
 
 func newFormatMetadataFromTypeReflection(reflection reflect.Type) (
-	format *formatMetadata, e error,
+	format formatMetadata, e error,
 ) {
 	var (
 		i int
@@ -32,8 +32,8 @@ func newFormatMetadataFromTypeReflection(reflection reflect.Type) (
 		return
 	}
 
-	format = &formatMetadata{
-		words: make([]*wordMetadata,
+	format = formatMetadata{
+		words: make([]wordMetadata,
 			reflection.NumField(),
 		),
 	}
@@ -52,11 +52,11 @@ func newFormatMetadataFromTypeReflection(reflection reflect.Type) (
 	return
 }
 
-func (m *formatMetadata) marshal(reflection reflect.Value) (bytes []byte) {
+func (m formatMetadata) marshal(reflection reflect.Value) (bytes []byte) {
 	var (
 		copyIndex int
 		i         int
-		word      *wordMetadata
+		word      wordMetadata
 		wordBytes []byte
 	)
 
@@ -75,12 +75,12 @@ func (m *formatMetadata) marshal(reflection reflect.Value) (bytes []byte) {
 	return
 }
 
-func (m *formatMetadata) unmarshal(bytes []byte, reflection reflect.Value) {
+func (m formatMetadata) unmarshal(bytes []byte, reflection reflect.Value) {
 	var (
 		i    int
 		j    int
 		k    int
-		word *wordMetadata
+		word wordMetadata
 	)
 
 	for i, word = range m.words {

metadata-word.go

@@ -9,13 +9,13 @@ import (
 )
 
 type wordMetadata struct {
-	bitFields     []*bitFieldMetadata
+	bitFields     []bitFieldMetadata
 	lengthInBits  uint
 	lengthInBytes int
 }
 
 func newWordMetadataFromStructFieldReflection(reflection reflect.StructField) (
-	word *wordMetadata, e error,
+	word wordMetadata, e error,
 ) {
 	const (
 		tagKey         = "word"
@@ -79,8 +79,8 @@ func newWordMetadataFromStructFieldReflection(reflection reflect.StructField) (
 		return
 	}
 
-	word = &wordMetadata{
-		bitFields: make([]*bitFieldMetadata,
+	word = wordMetadata{
+		bitFields: make([]bitFieldMetadata,
 			reflection.Type.NumField(),
 		),
 		lengthInBits:  wordLength,
@@ -114,9 +114,9 @@ func newWordMetadataFromStructFieldReflection(reflection reflect.StructField) (
 	return
 }
 
-func (m *wordMetadata) marshal(reflection reflect.Value) (bytes []byte) {
+func (m wordMetadata) marshal(reflection reflect.Value) (bytes []byte) {
 	var (
-		bitField       *bitFieldMetadata
+		bitField       bitFieldMetadata
 		bitFieldUint64 uint64
 		i              int
 		wordUint64     uint64
@@ -139,7 +139,7 @@ func (m *wordMetadata) marshal(reflection reflect.Value) (bytes []byte) {
 	return
 }
 
-func (m *wordMetadata) unmarshal(bytes []byte, reflection reflect.Value) {
+func (m wordMetadata) unmarshal(bytes []byte, reflection reflect.Value) {
 	var (
 		bitFieldBytes []byte
 		i             int