RuboCop: resolve Style/WordArray issues

Author: orien

.rubocop_todo.yml

@@ -696,13 +696,6 @@ Style/SymbolProc:
     - 'lib/stack_master/command.rb'
     - 'spec/support/validator_spec.rb'
 
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: WordRegex.
-# SupportedStyles: percent, brackets
-Style/WordArray:
-  EnforcedStyle: percent
-  MinSize: 4
-
 # This cop supports unsafe autocorrection (--autocorrect-all).
 Style/ZeroLengthPredicate:
   Exclude:

lib/stack_master/change_set.rb

@@ -1,9 +1,9 @@
 module StackMaster
   class ChangeSet
-    END_STATES = [
-      'CREATE_COMPLETE',
-      'DELETE_COMPLETE',
-      'FAILED'
+    END_STATES = %w[
+      CREATE_COMPLETE
+      DELETE_COMPLETE
+      FAILED
     ]
 
     def self.generate_change_set_name(stack_name)

lib/stack_master/commands/apply.rb

@@ -177,7 +177,7 @@ def stack_options
           stack_name: stack_name,
           parameters: proposed_stack.aws_parameters,
           tags: proposed_stack.aws_tags,
-          capabilities: ['CAPABILITY_IAM', 'CAPABILITY_NAMED_IAM', 'CAPABILITY_AUTO_EXPAND'],
+          capabilities: %w[CAPABILITY_IAM CAPABILITY_NAMED_IAM CAPABILITY_AUTO_EXPAND],
           role_arn: proposed_stack.role_arn,
           notification_arns: proposed_stack.notification_arns,
           template_method => template_value

lib/stack_master/commands/drift.rb

@@ -6,9 +6,9 @@ class Drift
       include Command
       include Commander::UI
 
-      DETECTION_COMPLETE_STATES = [
-        'DETECTION_COMPLETE',
-        'DETECTION_FAILED'
+      DETECTION_COMPLETE_STATES = %w[
+        DETECTION_COMPLETE
+        DETECTION_FAILED
       ]
 
       def perform

spec/stack_master/commands/apply_spec.rb

@@ -61,7 +61,7 @@ def apply
         tags: [
           { key: 'environment', value: 'production' }
         ],
-        capabilities: ['CAPABILITY_IAM', 'CAPABILITY_NAMED_IAM', 'CAPABILITY_AUTO_EXPAND'],
+        capabilities: %w[CAPABILITY_IAM CAPABILITY_NAMED_IAM CAPABILITY_AUTO_EXPAND],
         role_arn: role_arn,
         notification_arns: [notification_arn]
       )
@@ -182,7 +182,7 @@ def apply
         tags: [
           { key: 'environment', value: 'production' }
         ],
-        capabilities: ['CAPABILITY_IAM', 'CAPABILITY_NAMED_IAM', 'CAPABILITY_AUTO_EXPAND'],
+        capabilities: %w[CAPABILITY_IAM CAPABILITY_NAMED_IAM CAPABILITY_AUTO_EXPAND],
         role_arn: role_arn,
         notification_arns: [notification_arn],
         change_set_type: 'CREATE'
@@ -200,7 +200,7 @@ def apply
           template_body: proposed_stack.template_body,
           parameters: [{ parameter_key: 'param_1', parameter_value: 'hello' }],
           tags: [{ key: 'environment', value: 'production' }],
-          capabilities: ['CAPABILITY_IAM', 'CAPABILITY_NAMED_IAM', 'CAPABILITY_AUTO_EXPAND'],
+          capabilities: %w[CAPABILITY_IAM CAPABILITY_NAMED_IAM CAPABILITY_AUTO_EXPAND],
           role_arn: role_arn,
           notification_arns: [notification_arn],
           on_failure: 'ROLLBACK'

spec/stack_master/config_spec.rb

@@ -10,7 +10,7 @@
       allowed_accounts: ["555555555"],
       tags: { 'application' => 'my-awesome-blog', 'environment' => 'production' },
       s3: { 'bucket' => 'my-bucket', 'region' => 'us-east-1' },
-      notification_arns: ['test_arn', 'test_arn_2'],
+      notification_arns: %w[test_arn test_arn_2],
       role_arn: 'test_service_role_arn2',
       base_dir: base_dir,
       stack_policy_file: 'my_policy.json',
@@ -154,7 +154,7 @@
           tags: { 'application' => 'my-awesome-blog', 'environment' => 'staging', 'test_override' => 1 },
           s3: { 'bucket' => 'my-bucket', 'region' => 'us-east-1' },
           role_arn: 'test_service_role_arn4',
-          notification_arns: ['test_arn_3', 'test_arn_4'],
+          notification_arns: %w[test_arn_3 test_arn_4],
           template: 'myapp_vpc.rb',
           base_dir: base_dir,
           additional_parameter_lookup_dirs: ['staging']
@@ -166,7 +166,7 @@
           stack_name: 'myapp-web',
           region: 'ap-southeast-2',
           region_alias: 'staging',
-          allowed_accounts: ["1234567890", "9876543210"],
+          allowed_accounts: %w[1234567890 9876543210],
           tags: { 'application' => 'my-awesome-blog', 'environment' => 'staging', 'test_override' => 2 },
           s3: { 'bucket' => 'my-bucket', 'region' => 'us-east-1' },
           role_arn: 'test_service_role_arn3',

spec/stack_master/parameter_resolvers/latest_container_spec.rb

@@ -59,7 +59,7 @@
               registry_id: '012345678910',
               image_digest: 'sha256:decafc0ffee',
               image_pushed_at: Time.utc(2015, 1, 2, 0, 0),
-              image_tags: ['v1', 'production']
+              image_tags: %w[v1 production]
             },
             {
               registry_id: '012345678910',
@@ -137,7 +137,7 @@
                 registry_id: '012345678910',
                 image_digest: 'sha256:deadbeef',
                 image_pushed_at: Time.utc(2015, 1, 3, 0, 0),
-                image_tags: ['latest', 'v2']
+                image_tags: %w[latest v2]
               }
             ]
           },

spec/stack_master/sparkle_formation/compile_time/value_build_spec.rb

@@ -7,8 +7,8 @@
     { definition: { type: :string, default: 'a' }, parameter: nil, expected: 'a' },
 
     { definition: { type: :string, multiple: true }, parameter: 'a', expected: ['a'] },
-    { definition: { type: :string, multiple: true }, parameter: 'a,b', expected: ['a', 'b'] },
-    { definition: { type: :string, multiple: true }, parameter: 'a, b', expected: ['a', 'b'] },
+    { definition: { type: :string, multiple: true }, parameter: 'a,b', expected: %w[a b] },
+    { definition: { type: :string, multiple: true }, parameter: 'a, b', expected: %w[a b] },
 
     { definition: { type: :string, multiple: true, default: 'a' }, parameter: nil, expected: ['a'] },
 

spec/stack_master/test_driver/cloud_formation_spec.rb

@@ -7,15 +7,15 @@
     it 'creates and describes stacks' do
       test_cf_driver.create_stack(stack_id: "1", stack_name: 'stack-1')
       test_cf_driver.create_stack(stack_id: "2", stack_name: 'stack-2')
-      expect(test_cf_driver.describe_stacks.stacks.map(&:stack_id)).to eq(["1", "2"])
+      expect(test_cf_driver.describe_stacks.stacks.map(&:stack_id)).to eq(%w[1 2])
     end
 
     it 'adds and gets stack events' do
       test_cf_driver.add_stack_event(stack_name: 'stack-1', resource_status: "UPDATE_COMPLETE")
       test_cf_driver.add_stack_event(stack_name: 'stack-1', resource_status: "UPDATE_COMPLETE")
       test_cf_driver.add_stack_event(stack_name: 'stack-2')
       expect(test_cf_driver.describe_stack_events(stack_name: 'stack-1').stack_events.map(&:stack_name))
-        .to eq(['stack-1', 'stack-1'])
+        .to eq(%w[stack-1 stack-1])
     end
 
     it 'sets and gets templates' do
@@ -59,7 +59,7 @@
       )
       test_cf_driver.execute_change_set(change_set_name: change_set1.id)
       test_cf_driver.execute_change_set(change_set_name: change_set2.id)
-      expect(test_cf_driver.describe_stacks.stacks.map(&:stack_name)).to eq(['stack-1', 'stack-2'])
+      expect(test_cf_driver.describe_stacks.stacks.map(&:stack_name)).to eq(%w[stack-1 stack-2])
     end
   end