Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.

Commit b2db6cc

Browse files
author
Bin Liu
committed
remove public interface for ASCV with facilitator
1 parent aa0c64e commit b2db6cc

5 files changed

Lines changed: 25 additions & 9 deletions

File tree

AsyncDisplayKit.xcodeproj/project.pbxproj

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -359,6 +359,8 @@
359359
B0F8805B1BEAEC7500D17647 /* ASTableNode.m in Sources */ = {isa = PBXBuildFile; fileRef = B0F880591BEAEC7500D17647 /* ASTableNode.m */; };
360360
B13CA0F71C519E9400E031AB /* ASCollectionViewLayoutFacilitatorProtocol.h in Headers */ = {isa = PBXBuildFile; fileRef = B13CA0F61C519E9400E031AB /* ASCollectionViewLayoutFacilitatorProtocol.h */; };
361361
B13CA0F81C519EBA00E031AB /* ASCollectionViewLayoutFacilitatorProtocol.h in Headers */ = {isa = PBXBuildFile; fileRef = B13CA0F61C519E9400E031AB /* ASCollectionViewLayoutFacilitatorProtocol.h */; };
362+
B13CA1001C52004900E031AB /* ASCollectionNode+Beta.h in Headers */ = {isa = PBXBuildFile; fileRef = B13CA0FF1C52004900E031AB /* ASCollectionNode+Beta.h */; };
363+
B13CA1011C52004900E031AB /* ASCollectionNode+Beta.h in Headers */ = {isa = PBXBuildFile; fileRef = B13CA0FF1C52004900E031AB /* ASCollectionNode+Beta.h */; };
362364
B35061F31B010EFD0018CF92 /* ASCellNode.h in Headers */ = {isa = PBXBuildFile; fileRef = 055F1A3A19ABD43F004DAFF1 /* ASCellNode.h */; settings = {ATTRIBUTES = (Public, ); }; };
363365
B35061F51B010EFD0018CF92 /* ASCollectionView.h in Headers */ = {isa = PBXBuildFile; fileRef = AC3C4A4F1A1139C100143C57 /* ASCollectionView.h */; settings = {ATTRIBUTES = (Public, ); }; };
364366
B35061F61B010EFD0018CF92 /* ASCollectionView.mm in Sources */ = {isa = PBXBuildFile; fileRef = AC3C4A501A1139C100143C57 /* ASCollectionView.mm */; };
@@ -768,6 +770,7 @@
768770
B0F880581BEAEC7500D17647 /* ASTableNode.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ASTableNode.h; sourceTree = "<group>"; };
769771
B0F880591BEAEC7500D17647 /* ASTableNode.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = ASTableNode.m; sourceTree = "<group>"; };
770772
B13CA0F61C519E9400E031AB /* ASCollectionViewLayoutFacilitatorProtocol.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ASCollectionViewLayoutFacilitatorProtocol.h; sourceTree = "<group>"; };
773+
B13CA0FF1C52004900E031AB /* ASCollectionNode+Beta.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = "ASCollectionNode+Beta.h"; sourceTree = "<group>"; };
771774
B35061DA1B010EDF0018CF92 /* AsyncDisplayKit.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = AsyncDisplayKit.framework; sourceTree = BUILT_PRODUCTS_DIR; };
772775
B35061DD1B010EDF0018CF92 /* Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; name = Info.plist; path = "../AsyncDisplayKit-iOS/Info.plist"; sourceTree = "<group>"; };
773776
CC7FD9DC1BB5E962005CCB2B /* ASPhotosFrameworkImageRequest.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ASPhotosFrameworkImageRequest.h; sourceTree = "<group>"; };
@@ -908,6 +911,7 @@
908911
AC6456071B0A335000CF11B8 /* ASCellNode.m */,
909912
18C2ED7C1B9B7DE800F627B3 /* ASCollectionNode.h */,
910913
18C2ED7D1B9B7DE800F627B3 /* ASCollectionNode.mm */,
914+
B13CA0FF1C52004900E031AB /* ASCollectionNode+Beta.h */,
911915
AC3C4A4F1A1139C100143C57 /* ASCollectionView.h */,
912916
AC3C4A501A1139C100143C57 /* ASCollectionView.mm */,
913917
AC3C4A531A113EEC00143C57 /* ASCollectionViewProtocols.h */,
@@ -1351,6 +1355,7 @@
13511355
AC026B6F1BD57DBF00BBC17E /* _ASHierarchyChangeSet.h in Headers */,
13521356
0516FA3D1A15563400B4EBED /* ASLog.h in Headers */,
13531357
257754AA1BEE44CD00737CA5 /* ASTextKitEntityAttribute.h in Headers */,
1358+
B13CA1001C52004900E031AB /* ASCollectionNode+Beta.h in Headers */,
13541359
0442850D1BAA64EC00D16268 /* ASMultidimensionalArrayUtils.h in Headers */,
13551360
0516FA401A1563D200B4EBED /* ASMultiplexImageNode.h in Headers */,
13561361
058D0A59195D05DC00B7D73C /* ASMutableAttributedStringBuilder.h in Headers */,
@@ -1405,6 +1410,7 @@
14051410
B350623C1B010EFD0018CF92 /* _ASAsyncTransaction.h in Headers */,
14061411
B350623E1B010EFD0018CF92 /* _ASAsyncTransactionContainer+Private.h in Headers */,
14071412
B350623F1B010EFD0018CF92 /* _ASAsyncTransactionContainer.h in Headers */,
1413+
B13CA1011C52004900E031AB /* ASCollectionNode+Beta.h in Headers */,
14081414
DECC2ECE1C35C1C600388446 /* ASRangeControllerBeta.h in Headers */,
14091415
254C6B7E1BF94DF4003EC431 /* ASTextKitTailTruncater.h in Headers */,
14101416
B35062411B010EFD0018CF92 /* _ASAsyncTransactionGroup.h in Headers */,
Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
/* Copyright (c) 2014-present, Facebook, Inc.
2+
* All rights reserved.
3+
*
4+
* This source code is licensed under the BSD-style license found in the
5+
* LICENSE file in the root directory of this source tree. An additional grant
6+
* of patent rights can be found in the PATENTS file in the same directory.
7+
*/
8+
9+
@protocol ASCollectionViewLayoutFacilitatorProtocol;
10+
11+
NS_ASSUME_NONNULL_BEGIN
12+
13+
@interface ASCollectionNode (Beta)
14+
15+
- (instancetype)initWithFrame:(CGRect)frame collectionViewLayout:(UICollectionViewLayout *)layout layoutFacilitator:(nullable id<ASCollectionViewLayoutFacilitatorProtocol>)layoutFacilitator;
16+
17+
@end
18+
19+
NS_ASSUME_NONNULL_END

AsyncDisplayKit/ASCollectionNode.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ NS_ASSUME_NONNULL_BEGIN
2020

2121
- (instancetype)initWithCollectionViewLayout:(UICollectionViewLayout *)layout;
2222
- (instancetype)initWithFrame:(CGRect)frame collectionViewLayout:(UICollectionViewLayout *)layout;
23-
- (instancetype)initWithFrame:(CGRect)frame collectionViewLayout:(UICollectionViewLayout *)layout layoutFacilitator:(nullable id<ASCollectionViewLayoutFacilitatorProtocol>)layoutFacilitator;
2423

2524
@property (weak, nonatomic) id <ASCollectionDelegate> delegate;
2625
@property (weak, nonatomic) id <ASCollectionDataSource> dataSource;

AsyncDisplayKit/ASCollectionView.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ NS_ASSUME_NONNULL_BEGIN
4444
*/
4545
- (instancetype)initWithCollectionViewLayout:(UICollectionViewLayout *)layout;
4646
- (instancetype)initWithFrame:(CGRect)frame collectionViewLayout:(UICollectionViewLayout *)layout;
47-
- (instancetype)initWithFrame:(CGRect)frame collectionViewLayout:(UICollectionViewLayout *)layout layoutFacilitator:(id<ASCollectionViewLayoutFacilitatorProtocol>)layoutFacilitator;
4847

4948
// The corresponding ASCollectionNode, which exists even if directly allocating & handling the view class.
5049
@property (nonatomic, weak, readonly) ASCollectionNode *collectionNode;

AsyncDisplayKit/ASCollectionView.mm

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -140,13 +140,6 @@ - (instancetype)initWithFrame:(CGRect)frame collectionViewLayout:(UICollectionVi
140140
return [self _initWithFrame:frame collectionViewLayout:layout ownedByNode:NO];
141141
}
142142

143-
- (instancetype)initWithFrame:(CGRect)frame collectionViewLayout:(UICollectionViewLayout *)layout layoutFacilitator:(id<ASCollectionViewLayoutFacilitatorProtocol>)layoutFacilitator
144-
{
145-
self = [self _initWithFrame:frame collectionViewLayout:layout ownedByNode:NO];
146-
_layoutFacilitator = layoutFacilitator;
147-
return self;
148-
}
149-
150143
// FIXME: This method is deprecated and will probably be removed in or shortly after 2.0.
151144
- (instancetype)initWithFrame:(CGRect)frame collectionViewLayout:(UICollectionViewLayout *)layout asyncDataFetching:(BOOL)asyncDataFetchingEnabled
152145
{

0 commit comments

Comments
 (0)