Fix Pinterest Xcode 7.3.1 Analyzer Warnings (#1988)

Author: Hannah Troisi

AsyncDisplayKit/ASCellNode.h

@@ -120,7 +120,7 @@ typedef NS_ENUM(NSUInteger, ASCellNodeVisibilityEvent) {
  */
 - (instancetype)initWithViewControllerBlock:(ASDisplayNodeViewControllerBlock)viewControllerBlock didLoadBlock:(nullable ASDisplayNodeDidLoadBlock)didLoadBlock;
 
-- (void)cellNodeVisibilityEvent:(ASCellNodeVisibilityEvent)event inScrollView:(UIScrollView *)scrollView withCellFrame:(CGRect)cellFrame;
+- (void)cellNodeVisibilityEvent:(ASCellNodeVisibilityEvent)event inScrollView:(nullable UIScrollView *)scrollView withCellFrame:(CGRect)cellFrame;
 
 @end
 

AsyncDisplayKit/ASCollectionView.mm

@@ -721,9 +721,10 @@ - (void)scrollViewDidScroll:(UIScrollView *)scrollView
 
 - (void)scrollViewWillEndDragging:(UIScrollView *)scrollView withVelocity:(CGPoint)velocity targetContentOffset:(inout CGPoint *)targetContentOffset
 {
+  CGPoint contentOffset = scrollView.contentOffset;
   _deceleratingVelocity = CGPointMake(
-    scrollView.contentOffset.x - ((targetContentOffset != NULL) ? targetContentOffset->x : 0),
-    scrollView.contentOffset.y - ((targetContentOffset != NULL) ? targetContentOffset->y : 0)
+    contentOffset.x - ((targetContentOffset != NULL) ? targetContentOffset->x : 0),
+    contentOffset.y - ((targetContentOffset != NULL) ? targetContentOffset->y : 0)
   );
 
   if (targetContentOffset != NULL) {
@@ -732,7 +733,7 @@ - (void)scrollViewWillEndDragging:(UIScrollView *)scrollView withVelocity:(CGPoi
   }
 
   if (_asyncDelegateFlags.asyncDelegateScrollViewWillEndDraggingWithVelocityTargetContentOffset) {
-    [_asyncDelegate scrollViewWillEndDragging:scrollView withVelocity:velocity targetContentOffset:targetContentOffset];
+    [_asyncDelegate scrollViewWillEndDragging:scrollView withVelocity:velocity targetContentOffset:(targetContentOffset ? : &contentOffset)];
   }
 }
 

AsyncDisplayKit/ASDisplayNode.mm

@@ -2071,7 +2071,8 @@ - (ASLayoutSpec *)layoutSpecThatFits:(ASSizeRange)constrainedSize
     return _layoutSpecBlock(self, constrainedSize);
   }
 
-  return nil;
+  ASDisplayNodeAssert(NO, @"-[ASDisplayNode layoutSpecThatFits:] should never fall through to return empty value");
+  return [[ASLayoutSpec alloc] init];
 }
 
 - (ASLayout *)calculatedLayout

AsyncDisplayKit/ASTableView.mm

@@ -704,18 +704,19 @@ - (void)scrollViewDidScroll:(UIScrollView *)scrollView
 
 - (void)scrollViewWillEndDragging:(UIScrollView *)scrollView withVelocity:(CGPoint)velocity targetContentOffset:(inout CGPoint *)targetContentOffset
 {
+  CGPoint contentOffset = scrollView.contentOffset;
   _deceleratingVelocity = CGPointMake(
-    scrollView.contentOffset.x - ((targetContentOffset != NULL) ? targetContentOffset->x : 0),
-    scrollView.contentOffset.y - ((targetContentOffset != NULL) ? targetContentOffset->y : 0)
+    contentOffset.x - ((targetContentOffset != NULL) ? targetContentOffset->x : 0),
+    contentOffset.y - ((targetContentOffset != NULL) ? targetContentOffset->y : 0)
   );
 
   if (targetContentOffset != NULL) {
     ASDisplayNodeAssert(_batchContext != nil, @"Batch context should exist");
     [self _beginBatchFetchingIfNeededWithScrollView:self forScrollDirection:[self scrollDirection] contentOffset:*targetContentOffset];
   }
-
+  
   if (_asyncDelegateFlags.asyncDelegateScrollViewWillEndDraggingWithVelocityTargetContentOffset) {
-    [_asyncDelegate scrollViewWillEndDragging:scrollView withVelocity:velocity targetContentOffset:targetContentOffset];
+    [_asyncDelegate scrollViewWillEndDragging:scrollView withVelocity:velocity targetContentOffset:(targetContentOffset ? : &contentOffset)];
   }
 }
 

AsyncDisplayKit/Details/ASCollectionViewFlowLayoutInspector.h

@@ -48,14 +48,14 @@ NS_ASSUME_NONNULL_BEGIN
  *
  * @discussion A great time to update perform selector caches!
  */
-- (void)didChangeCollectionViewDelegate:(id<ASCollectionDelegate>)delegate;
+- (void)didChangeCollectionViewDelegate:(nullable id<ASCollectionDelegate>)delegate;
 
 /**
  * Allow the inspector to respond to dataSource changes.
  *
  * @discussion A great time to update perform selector caches!
  */
-- (void)didChangeCollectionViewDataSource:(id<ASCollectionDataSource>)dataSource;
+- (void)didChangeCollectionViewDataSource:(nullable id<ASCollectionDataSource>)dataSource;
 
 @end
 

AsyncDisplayKit/Details/ASImageProtocols.h

@@ -17,8 +17,8 @@ NS_ASSUME_NONNULL_BEGIN
 
 @protocol ASImageContainerProtocol <NSObject>
 
-- (UIImage *)asdk_image;
-- (NSData *)asdk_animatedImageData;
+- (nullable UIImage *)asdk_image;
+- (nullable NSData *)asdk_animatedImageData;
 
 @end