Skip to content

Commit 9895668

Browse files
committed
added tests for more drivers and increased version as it is now working on InternetExplorer
1 parent dbc5937 commit 9895668

2 files changed

Lines changed: 32 additions & 3 deletions

File tree

pom.xml

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212
<groupId>ch.racic.selenium.helper</groupId>
1313
<artifactId>SeleniumDownloadHelper</artifactId>
14-
<version>0.1-SNAPSHOT</version>
14+
<version>0.2-SNAPSHOT</version>
1515
<packaging>jar</packaging>
1616

1717
<name>Selenium Download Helper library</name>
@@ -58,7 +58,19 @@
5858
<version>${selenium.version}</version>
5959
</dependency>
6060
<dependency>
61-
<groupId>junit</groupId>
61+
<groupId>com.github.detro.ghostdriver</groupId>
62+
<artifactId>phantomjsdriver</artifactId>
63+
<version>1.1.0</version>
64+
<exclusions>
65+
<exclusion>
66+
<groupId>org.mortbay.jetty</groupId>
67+
<artifactId>servlet-api-2.5</artifactId>
68+
</exclusion>
69+
</exclusions>
70+
<scope>test</scope>
71+
</dependency>
72+
<dependency>
73+
<groupId>junit</groupId>
6274
<artifactId>junit</artifactId>
6375
<version>4.11</version>
6476
<scope>test</scope>
@@ -101,7 +113,7 @@
101113
<version>1.4</version>
102114
<executions>
103115
<execution>
104-
<phase>install</phase>
116+
<phase>verify</phase>
105117
<goals>
106118
<goal>sign</goal>
107119
</goals>

src/test/java/ch/racic/selenium/helper/download/SeleniumDownloadHelperTest.java

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@
1515
import org.openqa.selenium.chrome.ChromeDriver;
1616
import org.openqa.selenium.firefox.FirefoxDriver;
1717
import org.openqa.selenium.htmlunit.HtmlUnitDriver;
18+
import org.openqa.selenium.ie.InternetExplorerDriver;
19+
import org.openqa.selenium.phantomjs.PhantomJSDriver;
1820
import org.openqa.selenium.safari.SafariDriver;
1921

2022
import java.io.File;
@@ -76,6 +78,7 @@ public void testGetFileFromUrlHtmlUnit() throws Exception {
7678

7779
@Test
7880
public void testGetFileFromUrlChrome() throws Exception {
81+
//TODO put this into pom profiles which are OS specific
7982
System.setProperty("webdriver.chrome.driver", "driver/chromedriver");
8083
driver = new ChromeDriver();
8184
invokeGetFileDataFromUrl();
@@ -96,6 +99,20 @@ public void testGetFileFromUrlFireFox() throws Exception {
9699
invokeGetFileFromUrl();
97100
}
98101

102+
@Test
103+
public void testGetFileFromUrlInternetExplorer() throws Exception {
104+
driver = new InternetExplorerDriver();
105+
invokeGetFileDataFromUrl();
106+
invokeGetFileFromUrl();
107+
}
108+
109+
@Test
110+
public void testGetFileFromUrlPhantomJS() throws Exception {
111+
driver = new PhantomJSDriver();
112+
invokeGetFileDataFromUrl();
113+
invokeGetFileFromUrl();
114+
}
115+
99116
private void invokeGetFileDataFromUrl() throws Exception {
100117
driver.get(baseUrl + indexPage);
101118
SeleniumDownloadHelper sdlh = new SeleniumDownloadHelper(driver);

0 commit comments

Comments
 (0)