Add OutputParameter. Fix warning in VS2022. Update clang format file for llvm 14.0.0RC1.

Author: fdwr

_clang-format.disabled

@@ -1,47 +1,73 @@
-{
-# Disable until clang format supports closing brace on new line.
-# https://reviews.llvm.org/D109557
-Language: Cpp,
-AlignAfterOpenBracket: AlwaysBreak,
-UseTab: Never,
-IndentWidth: 4,
-BreakBeforeBraces: Allman,
-AllowShortIfStatementsOnASingleLine: false,
-IndentCaseLabels: false,
-ColumnLimit: 120,
+# Run manually to reformat a file:
+#
+# LLVM14.0.0RC1\bin\clang-format.exe -i -style=file:clang-format.txt <file>
+#
+# To reformat all files using cmd.exe:
+# for /r %t in (*.cc *.h) do clang-format.exe -i -style=file "%t"
+#
 
-Language: JavaScript,
-AlignAfterOpenBracket: AlwaysBreak,
-UseTab: Never,
-IndentWidth: 4,
-BreakBeforeBraces: Allman,
-AllowShortIfStatementsOnASingleLine: false,
-IndentCaseLabels: false,
-ColumnLimit: 200,
+#DisableFormat: true
+---
+BasedOnStyle: Microsoft
+---
+Language: Cpp
+AlignAfterOpenBracket: BlockIndent
+UseTab: Never
+IndentWidth: 4
+ColumnLimit: 120
+DerivePointerAlignment: false
+PointerAlignment: Left
+AllowShortIfStatementsOnASingleLine: false
+IndentCaseLabels: false
+AlignAfterOpenBracket: BlockIndent #DontAlign AlwaysBreak
+BinPackArguments: false
+BinPackParameters: false
+AllowAllArgumentsOnNextLine: false
+AllowAllParametersOfDeclarationOnNextLine: false
+AllowAllConstructorInitializersOnNextLine: false
+BreakConstructorInitializers: BeforeColon
+AllowShortLambdasOnASingleLine: true
+AllowShortFunctionsOnASingleLine: true
+AllowShortCaseLabelsOnASingleLine: true
+ConstructorInitializerAllOnOneLineOrOnePerLine: true
+BreakBeforeBraces: AllMan #Custom
+BraceWrapping:
+  BeforeLambdaBody: true
+AccessModifierOffset: -4
+IndentAccessModifiers: false
+---
+Language: JavaScript
+AlignAfterOpenBracket: AlwaysBreak
+UseTab: Never
+IndentWidth: 4
+BreakBeforeBraces: Allman
+AllowShortIfStatementsOnASingleLine: false
+IndentCaseLabels: false
+ColumnLimit: 200
 
-#BasedOnStyle: VisualStudio,
-#BreakBeforeBraces: Allman,
-#AlignAfterOpenBracket: AlwaysBreak,
-#AllowShortIfStatementsOnASingleLine: false,
-#AllowShortCaseLabelsOnASingleLine: true,
-#AllowShortFunctionsOnASingleLine: true,
-#AlwaysBreakTemplateDeclarations: true,
-#ConstructorInitializerAllOnOneLineOrOnePerLine: true,
-#BinPackParameters: false,
-#IndentCaseLabels: false,
-#IndentWidth: 4,
-#TabWidth: 4,
-#UseTab: Never,
-#MaxEmptyLinesToKeep: 2,
-PointerAlignment: Left,
-## SpaceBeforeInheritanceColon: true,
-#SpaceBeforeParens: ControlStatements,
-## SpaceBeforeRangeBasedForLoopColon: true,
-#SpacesInSquareBrackets: false,
-#AllowShortIfStatementsOnASingleLine: false,
-#ColumnLimit: 0,
-#SpaceInEmptyParentheses: false,
-## BreakBeforeClosingBrace: true,
-## BreakBeforeClosingParen: true,
-## DanglingParenthesis: true,
-}
+---
+#BasedOnStyle: VisualStudio
+#BreakBeforeBraces: Allman
+#AlignAfterOpenBracket: AlwaysBreak
+#AllowShortIfStatementsOnASingleLine: false
+#AllowShortCaseLabelsOnASingleLine: true
+#AllowShortFunctionsOnASingleLine: true
+#AlwaysBreakTemplateDeclarations: true
+#ConstructorInitializerAllOnOneLineOrOnePerLine: true
+#BinPackParameters: false
+#IndentCaseLabels: false
+#IndentWidth: 4
+#TabWidth: 4
+#UseTab: Never
+#MaxEmptyLinesToKeep: 2
+#PointerAlignment: Left
+#SpaceBeforeInheritanceColon: true
+#SpaceBeforeParens: ControlStatements
+#SpaceBeforeRangeBasedForLoopColon: true
+#SpacesInSquareBrackets: false
+#AllowShortIfStatementsOnASingleLine: false
+#ColumnLimit: 0
+#SpaceInEmptyParentheses: false
+#BreakBeforeClosingBrace: true
+#BreakBeforeClosingParen: true
+#DanglingParenthesis: true

source/Common.h

@@ -118,6 +118,36 @@ template <typename FunctorType>
 DismissableCleanupType<FunctorType> inline DismissableCleanup(FunctorType const& f) { return DismissableCleanupType<FunctorType>(f); }
 
 
+template <typename T>
+class OutputParameter
+{
+public:
+    explicit OutputParameter(T& object)
+    :   p_(&object)
+    {}
+
+    // Disable assignment because it would have totally different semantics then the other operator=
+    // also it is really not needed
+    OutputParameter& operator=(const OutputParameter&) = delete;
+
+    OutputParameter& operator=(T&& object)
+    {
+        *p_ = std::move(object);
+        return *p_;
+    }
+
+private:
+    T* p_;
+};
+
+
+template<typename T>
+OutputParameter<T> Output(T& t)
+{
+    return OutputParameter<T>(t);
+}
+
+
 // Range of iterators that can be used in a ranged for loop.
 template<typename ForwardIteratorType>
 class iterator_range

source/MainWindow.ixx

@@ -2914,7 +2914,7 @@ MainWindow::DialogProcResult CALLBACK MainWindow::OnNotification(HWND hwnd, int
                     auto const& drawableObject = drawableObjects_[index];
                     if (drawableObject.IsPointInside(point.x, point.y))
                     {
-                        clickedIndex = index;
+                        clickedIndex = uint32_t(index);
                         break;
                     }
                 }