Fix setting DWrite rendering mode on Windows 7, plus some comment updates

Author: fdwr

source/Attributes.h

@@ -200,7 +200,7 @@ struct AttributeValue
     Attribute::Variant data; // Room for one element, which is the common case.
     std::vector<uint8_t> dataArray; // Variable length data in case the fixed size variant is too small.
     std::u16string stringValue; // string representation, typed by user or read from data file.
-    uint32_t cookieValue = 0; // useful to compare for value changes, incremented each time.
+    uint32_t cookieValue = 0; // useful to compare for value changes, incremented each time data is changed.
 
     array_ref<uint8_t> Get(); // Get the data.
     HRESULT Set(Attribute const& attribute, _In_z_ char16_t const* newStringValue);
@@ -249,8 +249,8 @@ struct IAttributeSource
 
     // Get single value of specific type (not binary data).
     // If the actual type is incompatible with the desired type or the value
-    // is empty, it returns the default value and HRESULT for
-    // ERROR_UNMAPPED_SUBSTITUTION_STRING.
+    // is empty or it gets ERROR_UNMAPPED_SUBSTITUTION_STRING, then it returns
+    // the default value.
     template <typename T>
     T GetValue(uint32_t id, T defaultValue)
     {
@@ -319,7 +319,7 @@ struct IAttributeSource
 
     // Get an array of specific data types.
     // If the actual type is incompatible with the desired type, it returns
-    // an empty array and HRESULT for ERROR_UNMAPPED_SUBSTITUTION_STRING.
+    // an empty array.
     template <typename T>
     array_ref<T> GetValues(uint32_t id)
     {

source/Attributes.ixx

@@ -702,7 +702,7 @@ array_ref<uint8_t> AttributeValue::Get()
 }
 
 
-// Return a wstring copy of the string as a wstring rather than
+// Return a UTF-16 string copy of the string as a wstring rather than
 // a lightweight view into the text.
 HRESULT IAttributeSource::GetString(uint32_t id, _Out_ std::u16string& s)
 {

source/Common.OptionalValue.h

@@ -76,7 +76,7 @@ class optional_value
     T const& operator*() const { return value(); }
 
     // Container compatible helpers to accomodate generic template algorithms,
-    // treating std::optional like an std::vecto of size 0 or 1.
+    // treating std::optional like an std::vector of size 0 or 1.
     bool empty() { return !valueExists_; }
     T* data() { return &value(); }
     T const* data() const { return &value(); }

source/DrawableObject.ixx

@@ -1993,7 +1993,7 @@ HRESULT CachedDWriteRenderingParams::Update(IAttributeSource& attributeSource, D
     // Otherwise create custom one, using the default one as a template for any unspecified parameters.
     auto* dwriteFactory = drawingCanvas.GetDWriteFactoryWeakRef();
     ComPtr<IDWriteFactory2> dwriteFactory2;
-    IFR(drawingCanvas.GetDWriteFactoryWeakRef()->QueryInterface(OUT &dwriteFactory2));
+    drawingCanvas.GetDWriteFactoryWeakRef()->QueryInterface(OUT &dwriteFactory2);
 
     // Get defaults for gamma, contrast, CT level, pixel geometry...
     ComPtr<IDWriteRenderingParams> defaultRenderingParams;

source/MainWindow.ixx

@@ -700,10 +700,10 @@ void MainWindow::FillAttributesListView()
         auto weight = substringPrioritizer.GetStringWeight(ToChar16ArrayRef(attribute.display));
         substringPrioritizer.SetItemWeight(i, weight);
     }
-    auto clampedListIndices = substringPrioritizer.GetItemIndices(OUT listIndices, /*excludeMismatches*/true);
+    auto listIndicesSubset = substringPrioritizer.GetItemIndices(OUT listIndices, /*excludeMismatches*/false);
 
     // Add matching items to the ListView.
-    for (auto& index : clampedListIndices)
+    for (auto& index : listIndicesSubset)
     {
         auto& attribute = DrawableObject::attributeList[index];
         lw.lParam = attribute.id;