Skip to content

Commit 43786bd

Browse files
author
Varun Rathore
committed
resolved comments
1 parent 8b9b722 commit 43786bd

2 files changed

Lines changed: 7 additions & 3 deletions

File tree

src/main/java/com/google/firebase/remoteconfig/ParameterValue.java

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,8 +121,13 @@ static ParameterValue fromParameterValueResponse(
121121
new ExperimentVariantValue(
122122
evv.getVariantId(), evv.getValue(), evv.getNoChange()))
123123
.collect(toList());
124+
// Handle null exposurePercent by defaulting to 0
125+
double exposurePercent = 0;
126+
if (ev.getExposurePercent() != null) {
127+
exposurePercent = ev.getExposurePercent();
128+
}
124129
return ParameterValue.ofExperiment(
125-
ev.getExperimentId(), variantValues, ev.getExposurePercent());
130+
ev.getExperimentId(), variantValues, exposurePercent);
126131
}
127132
return ParameterValue.of(parameterValueResponse.getValue());
128133
}
@@ -457,7 +462,7 @@ public boolean equals(Object o) {
457462
ExperimentValue that = (ExperimentValue) o;
458463
return Objects.equals(experimentId, that.experimentId)
459464
&& Objects.equals(variantValues, that.variantValues)
460-
&& Objects.equals(that.exposurePercent, exposurePercent);
465+
&& Double.compare(that.exposurePercent, exposurePercent) == 0;
461466
}
462467

463468
@Override

src/test/java/com/google/firebase/remoteconfig/ParameterValueTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,6 @@ public void testCreateExperimentValue() {
8080
assertEquals("variant_2", variant2.getVariantId());
8181
assertEquals(null, variant2.getValue());
8282
assertEquals(true, variant2.isNoChange());
83-
assertEquals(10.0, parameterValue.getExposurePercent(), 0.0);
8483

8584
}
8685

0 commit comments

Comments
 (0)