Skip to content

Commit 9b862b1

Browse files
author
Varun Rathore
committed
fix comments
1 parent 4730f73 commit 9b862b1

3 files changed

Lines changed: 20 additions & 7 deletions

File tree

src/main/java/com/google/firebase/remoteconfig/ParameterValue.java

Lines changed: 18 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -82,10 +82,12 @@ public static PersonalizationValue ofPersonalization(String personalizationId) {
8282
*
8383
* @param experimentId The experiment ID.
8484
* @param variantValues The list of experiment variant values.
85+
* @param exposurePercent The percentage of users exposed to the experiment.
8586
* @return A {@link ParameterValue.ExperimentValue} instance.
8687
*/
87-
public static ExperimentValue ofExperiment(String experimentId,
88-
List<ExperimentVariantValue> variantValues, Double exposurePercent) {
88+
public static ExperimentValue of(
89+
String experimentId,
90+
List<ExperimentVariantValue> variantValues, Double exposurePercent) {
8991
return new ExperimentValue(experimentId, variantValues, exposurePercent);
9092
}
9193

@@ -119,7 +121,8 @@ static ParameterValue fromParameterValueResponse(
119121
.map(evv -> new ExperimentVariantValue(
120122
evv.getVariantId(), evv.getValue(), evv.getNoChange()))
121123
.collect(toList());
122-
return ParameterValue.ofExperiment(ev.getExperimentId(), variantValues, ev.getExposurePercent());
124+
return ParameterValue.ofExperiment(
125+
ev.getExperimentId(), variantValues, ev.getExposurePercent());
123126
}
124127
return ParameterValue.of(parameterValueResponse.getValue());
125128
}
@@ -418,6 +421,15 @@ public String getExperimentId() {
418421
return experimentId;
419422
}
420423

424+
425+
/**
426+
* Gets the percentage of users exposed to the experiment.
427+
*
428+
* @return The exposure percent
429+
*/
430+
public Double getExposurePercent() { return exposurePercent; }
431+
432+
421433
/**
422434
* Gets a collection of variant values served by the experiment.
423435
*
@@ -451,12 +463,13 @@ public boolean equals(Object o) {
451463
}
452464
ExperimentValue that = (ExperimentValue) o;
453465
return Objects.equals(experimentId, that.experimentId)
454-
&& Objects.equals(variantValues, that.variantValues);
466+
&& Objects.equals(variantValues, that.variantValues)
467+
&& Objects.equals(exposurePercent, that.exposurePercent);
455468
}
456469

457470
@Override
458471
public int hashCode() {
459-
return Objects.hash(experimentId, variantValues);
472+
return Objects.hash(experimentId, variantValues, exposurePercent);
460473
}
461474
}
462475
}

src/main/java/com/google/firebase/remoteconfig/internal/TemplateResponse.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,6 @@
2121
import java.util.List;
2222
import java.util.Map;
2323

24-
import org.checkerframework.checker.units.qual.K;
25-
2624
/**
2725
* The Data Transfer Object for parsing Remote Config template responses from the
2826
* Remote Config service.

src/test/java/com/google/firebase/remoteconfig/ParameterValueTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,8 @@ public void testCreateExperimentValue() {
7777
assertEquals("variant_2", variant2.getVariantId());
7878
assertEquals(null, variant2.getValue());
7979
assertEquals(true, variant2.isNoChange());
80+
assertEquals(10.0, parameterValue.getExposurePercent(), 0.0);
81+
8082
}
8183

8284
@Test

0 commit comments

Comments
 (0)