revert OperationRef.execute() API to executeOperation API

Author: stephenarosaj

src/data-connect/data-connect-api-client-internal.ts

@@ -23,7 +23,7 @@ import {
 import { PrefixedFirebaseError } from '../utils/error';
 import * as utils from '../utils/index';
 import * as validator from '../utils/validator';
-import { ConnectorConfig, ExecuteGraphqlResponse, GraphqlOptions, RefOptions } from './data-connect-api';
+import { ConnectorConfig, ExecuteGraphqlResponse, GraphqlOptions, OperationOptions } from './data-connect-api';
 
 const API_VERSION = 'v1';
 
@@ -176,7 +176,7 @@ export class DataConnectApiClient {
   public async executeQuery<GraphqlResponse, Variables>(
     name: string,
     variables: Variables, 
-    options?: RefOptions
+    options?: OperationOptions
   ): Promise<ExecuteGraphqlResponse<GraphqlResponse>> {
     return this.executeOperationHelper(IMPERSONATE_QUERY_ENDPOINT, name, variables, options);
   }
@@ -190,7 +190,7 @@ export class DataConnectApiClient {
   public async executeMutation<GraphqlResponse, Variables>(
     name: string,
     variables: Variables, 
-    options?: RefOptions
+    options?: OperationOptions
   ): Promise<ExecuteGraphqlResponse<GraphqlResponse>> {
     return this.executeOperationHelper(IMPERSONATE_MUTATION_ENDPOINT, name, variables, options);
   }
@@ -207,7 +207,7 @@ export class DataConnectApiClient {
     endpoint: string,
     name: string,
     variables: Variables, 
-    options?: RefOptions
+    options?: OperationOptions
   ): Promise<ExecuteGraphqlResponse<GraphqlResponse>> {
     if (
       typeof name === 'undefined' ||

src/data-connect/data-connect-api.ts

@@ -48,7 +48,7 @@ export interface ExecuteGraphqlResponse<GraphqlResponse> {
 }
 
 /**
- * Interface representing GraphQL options.
+ * Interface representing GraphQL options for executing arbitrary GraphQL operations.
  */
 export interface GraphqlOptions<Variables> {
   /**
@@ -71,9 +71,9 @@ export interface GraphqlOptions<Variables> {
 }
 
 /**
- * Interface representing options for OperationRefs.
+ * Interface representing options for executing defined operations.
  */
-export interface RefOptions {
+export interface OperationOptions {
   /**
    * If set, impersonate a request with given Firebase Auth context and evaluate the auth
    * policies on the operation. If omitted, bypass any defined auth policies.

src/data-connect/data-connect.ts

@@ -22,7 +22,7 @@ import {
   ConnectorConfig,
   ExecuteGraphqlResponse,
   GraphqlOptions,
-  RefOptions,
+  OperationOptions,
 } from './data-connect-api';
 
 export class DataConnectService {
@@ -160,7 +160,7 @@ export class DataConnect {
   }
 
   /**
-   * Executes a pre-defined GraphQL query with impersonation.
+   * Executes a deployed GraphQL query, optionally with auth impersonation.
    *
    * The query must be defined in your Data Connect GraphQL files.
    *
@@ -169,11 +169,11 @@ export class DataConnect {
    */
   public executeQuery<Data>(
     name: string,
-    options?: RefOptions
+    options?: OperationOptions
   ): Promise<ExecuteGraphqlResponse<Data>>;
 
   /**
-   * Executes a pre-defined GraphQL query with impersonation.
+   * Executes a pre-defined GraphQL query, optionally with auth impersonation.
    *
    * The query must be defined in your Data Connect GraphQL files.
    *
@@ -184,19 +184,19 @@ export class DataConnect {
   public executeQuery<Data, Variables>(
     name: string,
     variables: Variables, 
-    options?: RefOptions
+    options?: OperationOptions
   ): Promise<ExecuteGraphqlResponse<Data>>;
 
   public executeQuery<Data, Variables>(
     name: string,
     variables: Variables, 
-    options?: RefOptions
+    options?: OperationOptions
   ): Promise<ExecuteGraphqlResponse<Data>> {
     return this.client.executeQuery<Data, Variables>(name, variables, options);
   }
 
   /**
-   * Executes a pre-defined GraphQL mutation with impersonation.
+   * Executes a pre-defined GraphQL mutation, optionally with auth impersonation.
    *
    * The mutation must be defined in your Data Connect GQL files. 
    * 
@@ -205,11 +205,11 @@ export class DataConnect {
    */
   public executeMutation<Data>(
     name: string,
-    options?: RefOptions
+    options?: OperationOptions
   ): Promise<ExecuteGraphqlResponse<Data>>;
 
   /**
-   * Executes a pre-defined GraphQL mutation with impersonation.
+   * Executes a pre-defined GraphQL mutation, optionally with auth impersonation.
    *
    * The mutation must be defined in your Data Connect GQL files. 
    * 
@@ -220,13 +220,13 @@ export class DataConnect {
   public executeMutation<Data, Variables>(
     name: string,
     variables: Variables, 
-    options?: RefOptions
+    options?: OperationOptions
   ): Promise<ExecuteGraphqlResponse<Data>>;
 
   public executeMutation<Data, Variables>(
     name: string,
     variables: Variables, 
-    options?: RefOptions
+    options?: OperationOptions
   ): Promise<ExecuteGraphqlResponse<Data>> {
     return this.client.executeMutation<Data, Variables>(name, variables, options);
   }

src/data-connect/index.ts

@@ -33,16 +33,10 @@ export {
   ImpersonateAuthenticated,
   ImpersonateUnauthenticated,
   AuthClaims,
-  RefOptions,
+  OperationOptions,
 } from './data-connect-api'
 export {
   DataConnect,
-  OperationRef,
-  QueryRef,
-  MutationRef,
-  OperationResult,
-  QueryResult,
-  MutationResult,
 } from './data-connect'
 
 /**