Skip to content

Commit a9b5f39

Browse files
committed
address comments
1 parent e1d5c08 commit a9b5f39

10 files changed

Lines changed: 35 additions & 131 deletions

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "firebase-admin",
3-
"version": "13.4.0",
3+
"version": "13.5.0",
44
"description": "Firebase admin SDK for Node.js",
55
"author": "Firebase <firebase-support@google.com> (https://firebase.google.com/)",
66
"license": "Apache-2.0",

src/data-connect/data-connect.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,4 +239,4 @@ export class DataConnect {
239239
): Promise<ExecuteOperationResponse<Data>> {
240240
return this.client.executeMutation<Data, Variables>(name, variables, options);
241241
}
242-
}
242+
}

src/data-connect/index.ts

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
2+
13
/*!
24
* @license
35
* Copyright 2024 Google LLC
@@ -15,12 +17,6 @@
1517
* limitations under the License.
1618
*/
1719

18-
/**
19-
* Firebase Data Connect service.
20-
*
21-
* @packageDocumentation
22-
*/
23-
2420
import { _validateAdminArgs } from './validate-admin-args';
2521
import { App, getApp } from '../app';
2622
import { FirebaseApp } from '../app/firebase-app';
@@ -88,4 +84,4 @@ export function getDataConnect(connectorConfig: ConnectorConfig, app?: App): Dat
8884
/**
8985
* @internal
9086
*/
91-
export const validateAdminArgs = _validateAdminArgs;
87+
export const validateAdminArgs = _validateAdminArgs;

src/data-connect/validate-admin-args.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*!
22
* @license
3-
* Copyright 2024 Google LLC
3+
* Copyright 2025 Google LLC
44
*
55
* Licensed under the Apache License, Version 2.0 (the "License");
66
* you may not use this file except in compliance with the License.

test/integration/data-connect.spec.ts

Lines changed: 23 additions & 115 deletions
Large diffs are not rendered by default.

test/unit/data-connect/data-connect-api-client-internal.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -928,4 +928,4 @@ describe('DataConnectApiClient CRUD helpers', () => {
928928
.to.be.rejectedWith(FirebaseDataConnectError, `${serverErrorString}. ${additionalErrorMessageForBulkImport}`);
929929
});
930930
});
931-
});
931+
});

test/unit/data-connect/data-connect.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -223,4 +223,4 @@ describe('DataConnect', () => {
223223
});
224224
});
225225
});
226-
});
226+
});

test/unit/data-connect/validate-admin-args.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*!
22
* @license
3-
* Copyright 2024 Google LLC
3+
* Copyright 2025 Google LLC
44
*
55
* Licensed under the Apache License, Version 2.0 (the "License");
66
* you may not use this file except in compliance with the License.

test/unit/index.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,4 +122,4 @@ import './extensions/extensions-api-client-internal.spec';
122122
import './data-connect/index.spec';
123123
import './data-connect/data-connect-api-client-internal.spec';
124124
import './data-connect/data-connect.spec';
125-
import './data-connect/validate-admin-args.spec';
125+
import './data-connect/validate-admin-args.spec';

0 commit comments

Comments
 (0)